From: Mark Brown <broonie@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
kernel-janitors@vger.kernel.org, Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Andrew Lunn <andrew@lunn.ch>, Bjorn Helgaas <bhelgaas@google.com>,
Jason Cooper <jason@lakedaemon.net>,
linux-kernel@vger.kernel.org
Subject: Applied "regulator: of: Add a missing 'of_node_put()' in an error handling path of 'of_regulator_match()'" to the regulator tree
Date: Mon, 12 Feb 2018 12:09:21 +0000 [thread overview]
Message-ID: <E1elCvB-0007XX-0o@debutante> (raw)
In-Reply-To: <1444480254-14399-5-git-send-email-Julia.Lawall@lip6.fr>
The patch
regulator: of: Add a missing 'of_node_put()' in an error handling path of 'of_regulator_match()'
has been applied to the regulator tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 30966861a7a2051457be8c49466887d78cc47e97 Mon Sep 17 00:00:00 2001
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Date: Fri, 26 Jan 2018 23:13:44 +0100
Subject: [PATCH] regulator: of: Add a missing 'of_node_put()' in an error
handling path of 'of_regulator_match()'
If an unlikely failure in 'of_get_regulator_init_data()' occurs, we must
release the reference on the current 'child' node before returning.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/regulator/of_regulator.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/regulator/of_regulator.c b/drivers/regulator/of_regulator.c
index 092ed6efb3ec..f47264fa1940 100644
--- a/drivers/regulator/of_regulator.c
+++ b/drivers/regulator/of_regulator.c
@@ -321,6 +321,7 @@ int of_regulator_match(struct device *dev, struct device_node *node,
dev_err(dev,
"failed to parse DT for regulator %s\n",
child->name);
+ of_node_put(child);
return -EINVAL;
}
match->of_node = of_node_get(child);
--
2.16.1
next prev parent reply other threads:[~2018-02-12 12:09 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-10 12:30 [PATCH 0/5] add missing of_node_put Julia Lawall
2015-10-10 12:30 ` [PATCH 1/5] backlight: 88pm860x_bl: " Julia Lawall
2015-10-13 8:15 ` Lee Jones
2015-10-10 12:30 ` [PATCH 2/5] power_supply: charger-manager: " Julia Lawall
2015-10-12 2:20 ` Krzysztof Kozlowski
2015-10-15 8:56 ` Sebastian Reichel
2015-10-10 12:30 ` [PATCH 3/5] ARM: shmobile: R-Mobile: " Julia Lawall
2015-10-12 0:16 ` Simon Horman
2015-10-12 7:18 ` Geert Uytterhoeven
2015-10-12 7:24 ` Julia Lawall
2015-10-12 7:26 ` Geert Uytterhoeven
2015-10-12 7:29 ` Thomas Petazzoni
2015-10-12 7:30 ` Geert Uytterhoeven
2015-10-10 12:30 ` [PATCH 4/5] regulator: of: " Julia Lawall
2015-10-12 0:33 ` Krzysztof Kozlowski
2015-10-12 5:35 ` Julia Lawall
2015-10-12 12:44 ` Julia Lawall
2015-10-12 12:58 ` Krzysztof Kozlowski
2018-02-12 12:09 ` Mark Brown [this message]
2015-10-10 12:30 ` [PATCH 5/5] arm: " Julia Lawall
2015-10-10 21:02 ` Arnd Bergmann
2015-10-10 21:08 ` Thomas Petazzoni
2015-10-10 21:12 ` Julia Lawall
2015-10-10 21:10 ` Julia Lawall
2015-10-10 21:15 ` Arnd Bergmann
2015-10-10 21:41 ` [PATCH 5/5 v2] " Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1elCvB-0007XX-0o@debutante \
--to=broonie@kernel.org \
--cc=andrew@lunn.ch \
--cc=bhelgaas@google.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=jason@lakedaemon.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox