Re: [PATCH 3/4] ARM: change vmalloc_min to vmalloc_start

Xu, Yanfei
2021-05-28T02:53:19Z

On 5/20/21 5:00 PM, Russell King (Oracle) wrote:
> [Please note: This e-mail is from an EXTERNAL e-mail address]
>
> On Wed, May 19, 2021 at 12:41:10PM +0800, Xu, Yanfei wrote:
>> On 5/18/21 8:15 PM, Russell King (Oracle) wrote:
>>> -static unsigned long __initdata vmalloc_min =
>>> - VMALLOC_END - (240 << 20) - VMALLOC_OFFSET;
>>> +static unsigned long __initdata vmalloc_start = VMALLOC_END - (240 << 20);
>>>
>>> /*
>>> * vmalloc=size forces the vmalloc area to be exactly 'size'
>>> @@ -1169,7 +1168,8 @@ void __init adjust_lowmem_bounds(void)
>>> * and may itself be outside the valid range for which phys_addr_t
>>> * and therefore __pa() is defined.
>>> */
>>> - vmalloc_limit = (u64)vmalloc_min - PAGE_OFFSET + PHYS_OFFSET;
>>> + vmalloc_limit = (u64)vmalloc_start -
>>> + (PAGE_OFFSET + PHYS_OFFSET + VMALLOC_OFFSET);
>>>
>> Here is bug, it should be
>>
>> vmalloc_limit = (u64)vmalloc_start -
>> (PAGE_OFFSET + VMALLOC_OFFSET) + PHYS_OFFSET;
>
> Yes, you're absolutely right, thanks for catching that!
>

Hi Russell,

Will you send v2? (or I missed something.)

Thanks,
Yanfei

> --
> RMK's Patch system: https://urldefense.com/v3/__https://www.armlinux.org.uk/developer/patches/__;!!AjveYdw8EvQ!M3h7vuBembpLOcv9xTj5vzxlU0dxXMOa1lDX4yN6u4l-TwnuZ3-ldjYom-7ZQYpsVYc$
> FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
>