From: Thorsten Blum <thorsten.blum@linux.dev>
To: Josh Poimboeuf <jpoimboe@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
Sean Christopherson <seanjc@google.com>,
Kai Huang <kai.huang@intel.com>, Brian Gerst <brgerst@gmail.com>,
Thomas Huth <thuth@redhat.com>,
Patryk Wlazlyn <patryk.wlazlyn@linux.intel.com>,
Zheyun Shen <szy0127@sjtu.edu.cn>,
Kevin Loughlin <kevinloughlin@google.com>,
K Prateek Nayak <kprateek.nayak@amd.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Li Chen <chenl311@chinatelecom.cn>,
Tim Chen <tim.c.chen@linux.intel.com>,
Ingo Molnar <mingo@kernel.org>,
Tom Lendacky <thomas.lendacky@amd.com>,
Kevin Brodsky <kevin.brodsky@arm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/smpboot: Mark native_play_dead() as __noreturn
Date: Mon, 27 Oct 2025 20:56:18 +0100 [thread overview]
Message-ID: <EA25BB49-DCF0-4868-878D-8BC5217380A1@linux.dev> (raw)
In-Reply-To: <i4o6cr4x364xsk7ftas5guggjt4xdvawurrohveahi75iba5aj@dl6plusoxtin>
On 27. Oct 2025, at 20:28, Josh Poimboeuf wrote:
> On Mon, Oct 27, 2025 at 04:51:02PM +0100, Thorsten Blum wrote:
>> native_play_dead() ends by calling the non-returning function
>> hlt_play_dead() and therefore also never returns.
>>
>> The !CONFIG_HOTPLUG_CPU stub version of native_play_dead()
>> unconditionally calls BUG() and does not return either.
>>
>> Add the __noreturn attribute to both function definitions and their
>> declaration to document this behavior and to potentially improve
>> compiler optimizations.
>>
>> Remove the obsolete comment, and add native_play_dead() to the objtool's
>> list of __noreturn functions.
>>
>> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
>
> Is there an objtool warning that this fixes? If so, it would be helpful
> to put it in the description above.
Not that I'm aware of.
next prev parent reply other threads:[~2025-10-27 19:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 15:51 [PATCH] x86/smpboot: Mark native_play_dead() as __noreturn Thorsten Blum
2025-10-27 19:28 ` Josh Poimboeuf
2025-10-27 19:56 ` Thorsten Blum [this message]
2025-10-27 20:32 ` Josh Poimboeuf
2025-10-31 11:04 ` [tip: objtool/core] " tip-bot2 for Thorsten Blum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EA25BB49-DCF0-4868-878D-8BC5217380A1@linux.dev \
--to=thorsten.blum@linux.dev \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=chenl311@chinatelecom.cn \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@kernel.org \
--cc=kai.huang@intel.com \
--cc=kevin.brodsky@arm.com \
--cc=kevinloughlin@google.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=patryk.wlazlyn@linux.intel.com \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=seanjc@google.com \
--cc=szy0127@sjtu.edu.cn \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=thuth@redhat.com \
--cc=tim.c.chen@linux.intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox