From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0BEDC4332F for ; Sun, 13 Feb 2022 19:25:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238023AbiBMTZq convert rfc822-to-8bit (ORCPT ); Sun, 13 Feb 2022 14:25:46 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:36282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238006AbiBMTZp (ORCPT ); Sun, 13 Feb 2022 14:25:45 -0500 Received: from aposti.net (aposti.net [89.234.176.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E608318; Sun, 13 Feb 2022 11:25:38 -0800 (PST) Date: Sun, 13 Feb 2022 19:25:26 +0000 From: Paul Cercueil Subject: Re: [PATCH v2 01/12] iio: buffer-dma: Get rid of outgoing queue To: Jonathan Cameron Cc: Michael Hennerich , Lars-Peter Clausen , Christian =?iso-8859-1?b?S/ZuaWc=?= , Sumit Semwal , Jonathan Corbet , Alexandru Ardelean , dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Message-Id: In-Reply-To: <20220213185740.0322a83d@jic23-huawei> References: <20220207125933.81634-1-paul@crapouillou.net> <20220207125933.81634-2-paul@crapouillou.net> <20220213185740.0322a83d@jic23-huawei> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jonathan, Le dim., févr. 13 2022 at 18:57:40 +0000, Jonathan Cameron a écrit : > On Mon, 7 Feb 2022 12:59:22 +0000 > Paul Cercueil wrote: > >> The buffer-dma code was using two queues, incoming and outgoing, to >> manage the state of the blocks in use. >> >> While this totally works, it adds some complexity to the code, >> especially since the code only manages 2 blocks. It is much easier >> to >> just check each block's state manually, and keep a counter for the >> next >> block to dequeue. >> >> Since the new DMABUF based API wouldn't use the outgoing queue >> anyway, >> getting rid of it now makes the upcoming changes simpler. >> >> With this change, the IIO_BLOCK_STATE_DEQUEUED is now useless, and >> can >> be removed. >> >> v2: - Only remove the outgoing queue, and keep the incoming queue, >> as we >> want the buffer to start streaming data as soon as it is >> enabled. >> - Remove IIO_BLOCK_STATE_DEQUEUED, since it is now functionally >> the >> same as IIO_BLOCK_STATE_DONE. >> >> Signed-off-by: Paul Cercueil >> --- > > Trivial process thing but change log should be here, not above as we > don't > want it to end up in the main git log. I'm kinda used to do this now, it's the policy for sending patches to the DRM tree. I like it because "git notes" disappear after rebases and it's a pain. At least like this I don't lose the changelog. But okay, I'll change it for v3, if there's a v3. Cheers, -Paul >> drivers/iio/buffer/industrialio-buffer-dma.c | 44 >> ++++++++++---------- >> include/linux/iio/buffer-dma.h | 7 ++-- >> 2 files changed, 26 insertions(+), 25 deletions(-) >>