From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-172.mta1.migadu.com (out-172.mta1.migadu.com [95.215.58.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98AF97FBAC for ; Tue, 19 Aug 2025 00:34:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755563660; cv=none; b=SdAyvirUo+u6tBNQauo4EopVZhEymYuy81koOuDG8jkmpalEOKn55/de2UNuNNQCCqBQ2BB48MRn4Jxzr1sHaWbZi+SOJD9UqjT6fHacxsxnXS79zx4gxa/QtaNPAkt863ee/aefEubWyCsenSeskOAhYwgzKZjHm7nNn8TJ6Ek= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755563660; c=relaxed/simple; bh=VIj2YbU5o1RNHaFfyeLVtpSo78+d55miYm5h6O1qnN4=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=fcDSZmfJPgXQDjuJVfzOV9FWYoqFZcf8qTY4SW3FbepMLoabMZI2vm2dGHr93fxSq5EMsWqIvkNU8RzzLXOQ+L6szQ+i4hygDMjLoeo0ZhrVW3bTP+6rd5ua5t7i2nkGLomJ19aHbIRDbDf+eS9cPGpaGf0ckHHcn3z8feW/T/Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=KxI8Cjev; arc=none smtp.client-ip=95.215.58.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="KxI8Cjev" Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1755563646; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VIj2YbU5o1RNHaFfyeLVtpSo78+d55miYm5h6O1qnN4=; b=KxI8CjevBfsn7Z0BxhF1SbGMKg+RgAwIxiXyAWUW/S1KSGEbLLDNayeWDLdFvYxRLte4+T 4MngId6ICTspUMQqmzRCZBaw5ksNq7Pe9qczEV24tZ7/8flpgQ8QMseMNqTqLN4Dyrtx7/ 3PpVbxzore0atenB9myOpoqSoB4EDYU= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\)) Subject: Re: [PATCH 2/8] MIPS: sgi-ip32: Replace deprecated strcpy() in plat_mem_setup() X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Thorsten Blum In-Reply-To: <6d7mznlomgbhqexp64tswbozmlqk7svrek66zggjnhljsdzan3@3f66zsc5jm5y> Date: Tue, 19 Aug 2025 02:33:53 +0200 Cc: Thomas Bogendoerfer , linux-hardening@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <20250817183728.612012-1-thorsten.blum@linux.dev> <20250817183728.612012-2-thorsten.blum@linux.dev> <6d7mznlomgbhqexp64tswbozmlqk7svrek66zggjnhljsdzan3@3f66zsc5jm5y> To: Justin Stitt X-Migadu-Flow: FLOW_OUT On 19. Aug 2025, at 01:40, Justin Stitt wrote: > On Sun, Aug 17, 2025 at 08:37:12PM +0200, Thorsten Blum wrote: >> strcpy() is deprecated; use strscpy() instead. >>=20 >> Link: https://github.com/KSPP/linux/issues/88 >> Signed-off-by: Thorsten Blum >> --- >> arch/mips/sgi-ip32/ip32-setup.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >>=20 >> diff --git a/arch/mips/sgi-ip32/ip32-setup.c = b/arch/mips/sgi-ip32/ip32-setup.c >> index aeb0805aae57..c2ebc4bbd866 100644 >> --- a/arch/mips/sgi-ip32/ip32-setup.c >> +++ b/arch/mips/sgi-ip32/ip32-setup.c >> @@ -14,6 +14,7 @@ >> #include >> #include >> #include >> +#include >=20 > This new include isn't strictly necessary as it was building with > strcpy() fine before? It's not strictly necessary, but since I was often asked to explicitly include it, I made it a habit. Best, Thorsten