From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A86E14AD20 for ; Thu, 25 Dec 2025 11:17:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766661466; cv=none; b=oTgEpQ8V4LZP2aD7UI1U1uD2TVr0FrvbnRIL4oZMLLCRoi+OgvX37r+uZXUyBOh/A1eVR/M9SflmLzmvPtpblVgjsIANjuDKqxuv5CIZGjtPSNvTZCHkqUFrXgMbiAtuiv7qG8lti9VFH9JtnHXAJqnp8FwDGOP0NrriAWpMsZ8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766661466; c=relaxed/simple; bh=xTwz/Q1jEnqK005QeUiOnzmznY+btgm9RCzNo6FyeqM=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=RItOPDilo4gV1m1L40Gm0SOrpkfGXYzrIUQGvCoCIykKgNQ3q6wNg3HDs1KBSEhI/9jyr6kNeHex2G1xtdNbqpxf7uKRW0PfIdroZReQJoyPdcN/Ct804otlDmQpKSQi1SbdobD1DMD7aVVwC3BlX/HUuZeMQJXeQybAFwY/Bpo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=e3cf6maa; arc=none smtp.client-ip=209.85.214.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="e3cf6maa" Received: by mail-pl1-f194.google.com with SMTP id d9443c01a7336-2a137692691so75462595ad.0 for ; Thu, 25 Dec 2025 03:17:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766661464; x=1767266264; darn=vger.kernel.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=NR9ewMLjXFiPPdUADJ8UIVWJfNnUqlBWb4FQrwaT2qY=; b=e3cf6maaPSVUV8F9/F4bxTj59AqUyo6BesWd6cfX87J4IjIHMw5vtJ9GaVhZDiXvQ3 t2pmCsGxUivZxtHY6jgzr39fdfZr4oWSW+YNxYk6NEW2gCxo5ULg7vgbF7Wfg/a0QBEv PG8qV9M0eO3Pq6Aq/Rv8tYhXq/QetbA9+2Ii3RjI201OzlbqXb39jE/CbW0KN6tfMnHc +JbE+PEX5FtBqLgj77Co6SfGItMif8LTf8nQ0SmJWLI6fSyUSNvPyvhlYjYwAXqIqIf7 R5LJiDc9KqOFxur072YU9x/2UAKbDOU7/162tRv1BhroJC/YbJ9Hbwi9aOeF4E9q2UfS JmAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766661464; x=1767266264; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=NR9ewMLjXFiPPdUADJ8UIVWJfNnUqlBWb4FQrwaT2qY=; b=GqZP2FdadGxy04/k5GVmxCbh/W6l7diDLX2TgoIYNgfQ/UGgtWUNZZHzIVIzjnAFsF pPuHT5YpO9vW7DY8sUase888Sz4bo+rgD7pGlw0ECe+rtROnqkAImzy5SNjaXyxU9FVK p6171zWSTgE1grT7QCln1Awo22WEDt7VLUpgwqK6kjLLwvYl5fbgVTrNkaRDYwdn4oRp Dd7Lr4wgZdcLGd4JOdr06LK31cZ/5ZzuWXxOUiNFsBWUkueF92M8dZnjZ+NK418ZrjcC ypTYoIO2s9J+YPi5ODto6TUItwb9imWLHEwGp+fUCTu+sUn8lz9M5nL0NWlbBnYWhPH7 zy0Q== X-Forwarded-Encrypted: i=1; AJvYcCX/rovf+cN8KF/bhRKFPScw2KWIQM7l43EXlVClvaIxkjFmGWXpY3M0sQdf1G6cnQ3liFYA2bW/j+xHNUM=@vger.kernel.org X-Gm-Message-State: AOJu0YwXqu/IJNYTpvucPW8GYxcG8xSrnKIN8eEH3erEQIEeE+tcltHJ pNFDfrVtaZTeCibM3qKiRQuUtAeC1WgVXqSpGRD7DJ/iyPgWviCHcfH33bueH81igdMf3zwk X-Gm-Gg: AY/fxX6GcIQKehEsQy+v+FC9PDwVRSwO43zwwGXezS9hp7NgOQc+2H894O/I5onvr3W ecQYdfaURWntbNUXxIlW0Ip16FALqR+0MlPWiVTwm4uvOcscPHFlmgA9DwqN6H85HbE3tHGsXlm a6vN3GLkp9ml+M8nOwY9BJ4b9vz1Zo75SP+xUlEft5jgmv2KD2w4MMBmskv43v1fvgi2ZwAY9nM AYXTK6P//cVXQCZHcUfsWgUhMTrFEBM9zwF4pu8ECgDARryZ0cHGqzQZWMDBxnDf24nO5SllmM/ GgRYOPVX9bhxmMx0e+BYzbkmtavHTNCHePjlxh8RYNkW2YXqi1eN4fKXat1gdbfagqtcktMGokn a3KekzAap3oE9jvJv4+kuxtCT1x+iKQ1OYnHkJlmupeNZhsZcQO3pfBXIG4G4NNOaq25mnvhKyX HtpvTtz/3Yd2XKbSikZ89JvYFLMh70VIehDt7MBzVd4yjtnwXreG44zdrS0qkryfXZQEvEkF6xm y5++d4aPknTY/guEA== X-Google-Smtp-Source: AGHT+IG2M8a8qGctLFSHsXVBGxXFam1e3c0AO/WF6f8CTG9U4DPalhsEV923XI9BxX9JmKKZ65n0vg== X-Received: by 2002:a05:6a20:12cb:b0:34f:a16f:15ad with SMTP id adf61e73a8af0-376aa7f0de4mr19263347637.53.1766655352891; Thu, 25 Dec 2025 01:35:52 -0800 (PST) Received: from smtpclient.apple (125x103x213x40.ap125.ftth.ucom.ne.jp. [125.103.213.40]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34e76de1e41sm10145504a91.2.2025.12.25.01.35.46 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Dec 2025 01:35:52 -0800 (PST) Content-Type: text/plain; charset=us-ascii Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.300.41.1.7\)) Subject: Re: [PATCH v4 2/9] dt-bindings: display: add verisilicon,dc From: "Han Gao (Revy)" In-Reply-To: <20251224161205.1132149-3-zhengxingda@iscas.ac.cn> Date: Thu, 25 Dec 2025 17:35:34 +0800 Cc: "Han Gao (Revy)" , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Drew Fustini , Guo Ren , Fu Wei , Philipp Zabel , Heiko Stuebner , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Michal Wilczynski , Yao Zi , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Icenowy Zheng Content-Transfer-Encoding: quoted-printable Message-Id: References: <20251224161205.1132149-1-zhengxingda@iscas.ac.cn> <20251224161205.1132149-3-zhengxingda@iscas.ac.cn> To: Icenowy Zheng X-Mailer: Apple Mail (2.3864.300.41.1.7) > On Dec 25, 2025, at 00:11, Icenowy Zheng = wrote: >=20 > From: Icenowy Zheng >=20 > Verisilicon has a series of display controllers prefixed with DC and > with self-identification facility like their GC series GPUs. >=20 > Add a device tree binding for it. >=20 > Depends on the specific DC model, it can have either one or two = display > outputs, and each display output could be set to DPI signal or "DP" > signal (which seems to be some plain parallel bus to HDMI = controllers). >=20 > Signed-off-by: Icenowy Zheng > Signed-off-by: Icenowy Zheng > --- > Changes in v4: > - Added a comment for "verisilicon,dc" that says the ID/revision is > discoverable via registers. > - Removed clock minItems constraint w/o specific compatible strings. >=20 > Changes in v3: > - Added SoC-specific compatible string, and arm the binding with clock = / > port checking for the specific SoC (with a 2-output DC). >=20 > Changes in v2: > - Fixed misspelt "versilicon" in title. > - Moved minItems in clock properties to be earlier than items. > - Re-aligned multi-line clocks and resets in example. >=20 > .../bindings/display/verisilicon,dc.yaml | 144 ++++++++++++++++++ > 1 file changed, 144 insertions(+) > create mode 100644 = Documentation/devicetree/bindings/display/verisilicon,dc.yaml >=20 > diff --git = a/Documentation/devicetree/bindings/display/verisilicon,dc.yaml = b/Documentation/devicetree/bindings/display/verisilicon,dc.yaml > new file mode 100644 > index 0000000000000..fe64cc1466690 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/verisilicon,dc.yaml > @@ -0,0 +1,144 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/verisilicon,dc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Verisilicon DC-series display controllers > + > +maintainers: > + - Icenowy Zheng > + > +properties: > + $nodename: > + pattern: "^display@[0-9a-f]+$" > + > + compatible: > + items: > + - enum: > + - thead,th1520-dc8200 > + - const: verisilicon,dc # DC IPs have discoverable ID/revision = registers > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + items: > + - description: DC Core clock > + - description: DMA AXI bus clock > + - description: Configuration AHB bus clock > + - description: Pixel clock of output 0 > + - description: Pixel clock of output 1 > + > + clock-names: > + items: > + - const: core > + - const: axi > + - const: ahb > + - const: pix0 > + - const: pix1 > + > + resets: > + items: > + - description: DC Core reset > + - description: DMA AXI bus reset > + - description: Configuration AHB bus reset > + > + reset-names: > + items: > + - const: core > + - const: axi > + - const: ahb > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: The first output channel , endpoint 0 should be > + used for DPI format output and endpoint 1 should be used > + for DP format output. > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: The second output channel if the DC variant > + supports. Follow the same endpoint addressing rule with > + the first port. > + > + required: > + - port@0 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - ports > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + const: thead,th1520-dc8200 > + then: > + properties: > + clocks: > + minItems: 5 > + ports: > + required: > + - port@0 > + - port@1 > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + soc { > + #address-cells =3D <2>; > + #size-cells =3D <2>; > + > + display@ffef600000 { > + compatible =3D "thead,th1520-dc8200", "verisilicon,dc"; > + reg =3D <0xff 0xef600000 0x0 0x100000>; > + interrupts =3D <93 IRQ_TYPE_LEVEL_HIGH>; > + clocks =3D <&clk_vo CLK_DPU_CCLK>, > + <&clk_vo CLK_DPU_ACLK>, > + <&clk_vo CLK_DPU_HCLK>, > + <&clk_vo CLK_DPU_PIXELCLK0>, > + <&clk_vo CLK_DPU_PIXELCLK1>; > + clock-names =3D "core", "axi", "ahb", "pix0", "pix1"; > + resets =3D <&rst TH1520_RESET_ID_DPU_CORE>, > + <&rst TH1520_RESET_ID_DPU_AXI>, > + <&rst TH1520_RESET_ID_DPU_AHB>; > + reset-names =3D "core", "axi", "ahb"; > + > + ports { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + port@0 { > + reg =3D <0>; > + }; > + > + port@1 { > + reg =3D <1>; > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + dpu_out_dp1: endpoint@1 { > + reg =3D <1>; > + remote-endpoint =3D <&hdmi_in>; > + }; > + }; > + }; > + }; > + }; > --=20 > 2.52.0 >=20 Tested-by: Han Gao >