From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f46.google.com (mail-dl1-f46.google.com [74.125.82.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 115263B9D84 for ; Fri, 15 May 2026 16:11:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778861512; cv=none; b=ddtWmw4GEX4k7swy56k1RkS54IXuoKgZondWKTqet7Lzm6Tiq4A1cA6TqYwQO6yBVZw4RDr5Uev4Vk+Vp9lG+pC0FfB77XSIf1bW7sz8yV4YcRNG/awOsEOgjD/Gh/QEFVqdyYUOquGkgAWWBmLJavDiZ4wu6q8JI39t6vqbxAA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778861512; c=relaxed/simple; bh=m+RXjR8nAzv231UlDkcWg9DwGop1tH+x1SRV+qsOiBc=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=aOWpiTtMR3qvM6CgeWtZWGRtGvdWKEN4TtLwe9vuI15U3ghSN8/YARlK4G4iSPuUtWxlgXl8fZ1mJwfYykh2XVU82KmJwgwIQlPtATunKHkJlCIlU9Zu2YnmkIpmXSHFdu3J0bZhAQNa8Iqepd2P6hM4MZK7kWv6tAcHrsWb8Wc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=D3ZAEr2y; arc=none smtp.client-ip=74.125.82.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D3ZAEr2y" Received: by mail-dl1-f46.google.com with SMTP id a92af1059eb24-1334825de43so4998823c88.0 for ; Fri, 15 May 2026 09:11:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778861510; x=1779466310; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=eOUGu7otXKU83Ptl5ObFnUx6XOop4vjyk0yP3QaWBlM=; b=D3ZAEr2yFsKyhwIiXMFMo8q8DbGGddroHuz4TuUZKqp4a46Gj7ebCLEFtlb+KFKKe1 J9qti3xJgASb9RXIDIKV2qf53c+ZZbhlTzA3KYSru3PVd0q9ytu/1KAnXEpEl/NJyG+I v+lw2nCTM4k1jPXa/tHiLIJPJhzVM8zZG1Vci0t89BROYbZhYcFXr+aotRoncLL6aSdv k2tJkgXQe9QiMztcPudzKlNsQa2Rhq6uwnOEzpbFZ+wbAClLYDRne7T/6CmfI59uXvlL dAJAdUkD+6jfVJFZIMdSRqe0lTyqPltHpvIvspk8MDs6XT+ulEmtUivq3fiVMptnfLFl mimQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778861510; x=1779466310; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eOUGu7otXKU83Ptl5ObFnUx6XOop4vjyk0yP3QaWBlM=; b=VGrJa/cPX4Sj7noCrshcNzkblAXVF3t/rHrKHJdWlZW5XnJZPxzyEzPkDQMUP4kOLz nAzrp47nz9MfiqOEpBIae/18RSKlArA08NS25Sqzvs2sFAVqetqU4N+wKohU+81Ko+UN 84GoNRd2qNkGFln6ZzV6P8aTqfExvzfAxgBqxI3sS/C0G4gjRwdXuymhR9ilQ/YnN0nf kAGU6Wk9kHE7WKEBh+5lEz01cwi/hLlbrc+PI1p9at90UM6ewZp47KfhJiPsumM25gm4 MEE6trQrx5EzwgdgVxkEpU6r2hR7PBQ5LSRcDRVkBGHc6t2G0PTHDneeg6wFXTORV1mf LCdg== X-Forwarded-Encrypted: i=1; AFNElJ/gTjAYhA7+dPL3p78mH+vsWC3bLhlqlx+lO3WfzmTewW/uzPl5mz85KYg5HuM+SfRR/N9uoO+3hS3QoqU=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+5AwdRO8RqOxzOJ/FXNwTYxvNtpmbqyVmLFMc3t/UpGUbymCJ UOasRO97vCCHSJvNvI0cS47465Flybng1yD9beVqYle4b+B7dgEPZ84TFK+IuQ== X-Gm-Gg: Acq92OE+dZjvmwV/dAs4kDvYbw1Pu75SADRUGStBSbngRsdvYyVCOMbsyLETAlLBEFq xzz4Z4TgQExtCUljg0eSTimM2xOjSlEeT2UtAhLETw62d3J0WSq0e1W4Nw6qiY1ADIaJLTP8Edp O+Bp8M68R+6FoOfGNihknu3LWJSLyehNzMaoTK7+MAEs4FtVGv40raTJoEF6HmQSdg1DnfeRbAN tM84tbMn5JwP6/RxZXCvNxNEOC4aAQHqKbgLI0JGU/qa4tM/6SLl7ycrcJHqTUCJpdFUaVj5veW Ze0O0KCGtEpAD4/X73USdrFCrESCqARzOmGs2Q+oh80Ihbulh1T0f/vNu385Y8rljrDgz4WPvWj NkyDzNgDY5GlbDFdw03mb13PPyLd8h5vhVHuyrUH6AQbwLRf1Eq8n6sJITAsthVCGhgI4ayVFON sCpfvW8QMWKxxNIStXNRSUXrJ4ahIiNuMq+Ojhn05Jcw== X-Received: by 2002:a05:7022:69a9:b0:12d:de3e:86b9 with SMTP id a92af1059eb24-1350592f049mr2344958c88.41.1778861510101; Fri, 15 May 2026 09:11:50 -0700 (PDT) Received: from ehlo.thunderbird.net ([2607:fb91:ae5:914c:ad3:d358:6b31:e32e]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-134cbed2232sm11072949c88.7.2026.05.15.09.11.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 May 2026 09:11:49 -0700 (PDT) Date: Fri, 15 May 2026 09:11:48 -0700 From: "Derek J. Clark" To: Louis Clinckx , Mark Pearson , Jiri Kosina , Benjamin Tissoires CC: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/2] HID: lenovo-go: clean up USB assumption User-Agent: Thunderbird for Android In-Reply-To: References: Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On May 15, 2026 7:57:38 AM PDT, Louis Clinckx = wrote: >These drivers' id_tables only match HID_USB_DEVICE() entries and the >code freely assumes a USB transport (to_usb_interface() on hdev->dev=2Epa= rent, >endpoint access in raw_event)=2E Make the assumption explicit at probe an= d >drop a NULL check that the compiler-level definition of to_usb_interface(= ) >makes unreachable=2E > >No functional change for the supported (USB) devices=2E > >Louis Clinckx (2): > HID: lenovo-go: reject non-USB transports in probe > HID: lenovo-go: drop dead NULL check on to_usb_interface() > > drivers/hid/hid-lenovo-go-s=2Ec | 11 ++++++----- > drivers/hid/hid-lenovo-go=2Ec | 6 +++--- > 2 files changed, 9 insertions(+), 8 deletions(-) > >--- >Changes since v1: > - Resubmitted on linux-input as a quality fix per Benjamin's review of v= 1 > (sent to security@kernel=2Eorg; the HID_USB_DEVICE() id_table already > filters BUS_USB, so no exploitable path)=2E > - Added patch 2 to remove the dead NULL check, at Derek's suggestion=2E > >base-commit: 50897c955902c93ae71c38698abb910525ebdc89 >-- >2=2E39=2E5 > Thanks for the quick turnaround on this=2E I've already tested these chang= es, so for the series: Reviewed-by: Derek J=2E Clark Tested-by: Derek J=2E Clark Thanks, Derek