From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-186.mta1.migadu.com (out-186.mta1.migadu.com [95.215.58.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E30226B2D2 for ; Wed, 29 Apr 2026 11:35:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.186 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777462530; cv=none; b=Jg3Ckc2Pz3Dj5NNxYvhQMj9L+kJ86XPKODwwYzQgpSnbSHM/1uCeWJ3cyS2M2x/WYRSysQRLXES1RP3RMhTfFNiR5z4aFrNjRcmCINUQOY9QYiGpQoeYAgNUxDjCJV0Dukfa6NQesDbZy7h2jmyqNmTlAisfLXk105ghu8GKeC0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777462530; c=relaxed/simple; bh=kYGAGeHCPt/7/exyEXC+ixGmsyjkga5qj+sDZ3ryGnA=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=Pk6sVU7g5gDb8LRoODd1wOyNC3rk54z8hLnIer95o8o/DOC/QRQpMFW7e4weReluzI/XflCKfFWfdx4/WXFKqq4Hu+Dm37jcw7aQygczBOtwKwxCu6sAwUSlk/WjXjYE+9J+wUXwp4E5b+R2ZDFOXq62jyZa2NV01zxXAU6rrqI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=aHQIxoj4; arc=none smtp.client-ip=95.215.58.186 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="aHQIxoj4" Date: Wed, 29 Apr 2026 13:34:41 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1777462516; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kYGAGeHCPt/7/exyEXC+ixGmsyjkga5qj+sDZ3ryGnA=; b=aHQIxoj4Ieu7ngiySX44nWAFbZ7NzMQb0zdbQumfWSPU53Z9s7+l/Ttq0XX4HgTftu2l3m 5I08N/N/+AZioidh22EzfkKi8sD1vxUMYZJG0Ma+gZcq3Jbr5SGr85rTsh/NC1XWcNZtFf MSeVxsHo1kkdwPjDL6d2HWtkCF36JGc= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Luka Gejak To: Linus Probert CC: linus.probert@gmail.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, luka.gejak@linux.dev Subject: Re: [PATCH 0/8] staging: rtl8723bs: remove warnings in rtw_btcoex.h In-Reply-To: <177745958799.1254637.4289009650997698120.b4-reply@b4> References: <12186A7D-522A-4900-9E4A-E2B575930A72@linux.dev> <2097F9CE-F003-4BE1-AEF5-0B30294973FB@linux.dev> <177745958799.1254637.4289009650997698120.b4-reply@b4> Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT On April 29, 2026 12:46:27 PM GMT+02:00, Linus Probert wrote: >On 2026-04-29 12:24:53+02:00, Luka Gejak wrote: >> On April 29, 2026 12:18:12 PM GMT+02:00, Luka Gejak wrote: >>=20 >> >> This series eliminates all remaining checkpatch warnings in >> > >> >LGTM, so for the patch series: >> > >> >Reviewed-by: Luka Gejak >> > >> >Best regards, >> >Luka Gejak >>=20 >> One note: >> For the future cleanup series, feel free to squash identical logical=20 >> changes into a single patch to keep the commit history concise=2E It's= =20 >> up to Greg if he wants v2 but logic is sound as is=2E >> Best regards, >> Luka Gejak > >I will make a note of that=2E In this case what do you consider an >identical logical change? What would you suggest that I squash? > >Br, >Linus > A logical change refers to the type of cleanup being done=2E In your=20 series, patches 3-8 all do the exact same thing: fix CamelCase names=20 for functions defined in rtw_btcoex=2Eh=2E Instead of 6 separate commits,= =20 those could be squashed into a single patch=2E But as I already said it=20 is up to Greg if he wants v2 or if he wants to keep v1 as is=2E Either=20 way code itself is good=2E Best regards, Luka Gejak