From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754022AbbL2XAQ (ORCPT ); Tue, 29 Dec 2015 18:00:16 -0500 Received: from mail-oi0-f49.google.com ([209.85.218.49]:36862 "EHLO mail-oi0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753156AbbL2XAM (ORCPT ); Tue, 29 Dec 2015 18:00:12 -0500 User-Agent: K-9 Mail for Android In-Reply-To: <1451287341-16453-4-git-send-email-zhengxing@rock-chips.com> References: <1451287341-16453-1-git-send-email-zhengxing@rock-chips.com> <1451287341-16453-4-git-send-email-zhengxing@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Subject: Re: [RESEND PATCH v1 3/4] net: ethernet: arc: Add support emac for RK3036 From: Florian Fainelli Date: Tue, 29 Dec 2015 14:59:59 -0800 To: Xing Zheng , linux-rockchip@lists.infradead.org CC: heiko@sntech.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Gortmaker , Geert Uytterhoeven , keescook@google.com, leozwang@google.comi, davem@davemloft.net, linux-arm-kernel@lists.infradead.org Message-ID: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On December 27, 2015 11:22:20 PM PST, Xing Zheng wrote: >The RK3036's GRFs offset are different with RK3066/RK3188, and need to >set >mac TX/RX clock before probe emac. > >Signed-off-by: Xing Zheng >--- > }; > > static const struct of_device_id emac_rockchip_dt_ids[] = { >- { .compatible = "rockchip,rk3066-emac", .data = >&emac_rockchip_dt_data[0] }, >- { .compatible = "rockchip,rk3188-emac", .data = >&emac_rockchip_dt_data[1] }, >+ { .compatible = "rockchip,rk3036-emac", .data = >&emac_rockchip_dt_data[0] }, >+ { .compatible = "rockchip,rk3066-emac", .data = >&emac_rockchip_dt_data[1] }, >+ { .compatible = "rockchip,rk3188-emac", .data = >&emac_rockchip_dt_data[2] }, > { /* Sentinel */ } Food for thought, you might want to use an enum here to index emac_rockchip_dt_data which would be less error prone if you add/remove entries in this structure. -- Florian