From: Karl Palsson <karlp@tweak.net.au>
To: "Chen-Yu Tsai" <wens@csie.org>
Cc: "Maxime Ripard" <mripard@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] ARM: dts: sun8i: add FriendlyARM NanoPi Duo2
Date: Fri, 01 Nov 2019 10:00:33 -0000 [thread overview]
Message-ID: <FbCSL9o7LLRZJoCAokdTzGW6y5cRWs88rHTPoqG2238c@mailpile> (raw)
In-Reply-To: <CAGb2v67PLemQvj+SOF2h_cfc4HcnAyvs866Bas7GRUF9Y1Lo1A@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 639 bytes --]
Chen-Yu Tsai <wens@csie.org> wrote:
(will fix all other comments)
> > + // on opi-win, shutdown is pl4, is BT-RST-N is moduel pin 34
> > + // YES; PG13 is correct.
>
> I'm guessing all these comments are from your development
> cycle? Please remove them.
Yes, gross mistake squishing it all and rebasing, my apologies.
>
> > + shutdown-gpios = <&pio 6 13 GPIO_ACTIVE_HIGH>; /* PG13 */
> > + };
> > +};
>
> The board also has SPI flash. Can you add that as well?
It doesn't come mounted standard, it's just a blank footprint, so
I felt it should be left out?
Sincerely,
Karl Palsson
[-- Attachment #2: OpenPGP Digital Signature --]
[-- Type: application/pgp-signature, Size: 1175 bytes --]
next prev parent reply other threads:[~2019-11-01 10:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 23:12 [PATCH 2/3] ARM: dts: sun8i: add FriendlyARM NanoPi Duo2 Karl Palsson
2019-10-31 23:12 ` [PATCH 3/3] ARM: dts: sun8i: add FriendlyARM NanoPi Duo2-IoT Box Karl Palsson
2019-11-01 3:03 ` Chen-Yu Tsai
2019-11-01 9:10 ` Maxime Ripard
2019-11-01 9:55 ` Karl Palsson
2019-11-03 16:22 ` Maxime Ripard
2019-11-01 3:01 ` [PATCH 2/3] ARM: dts: sun8i: add FriendlyARM NanoPi Duo2 Chen-Yu Tsai
2019-11-01 10:00 ` Karl Palsson [this message]
2019-11-01 9:08 ` Maxime Ripard
-- strict thread matches above, loose matches on Subject: below --
2018-12-18 21:24 [PATCH 1/3] ARM: dts: sunxi: h3/h5: add missing uart2 rts/cts pins Karl Palsson
2018-12-18 21:24 ` [PATCH 2/3] ARM: dts: sun8i: add FriendlyARM NanoPi Duo2 Karl Palsson
2018-12-19 7:08 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FbCSL9o7LLRZJoCAokdTzGW6y5cRWs88rHTPoqG2238c@mailpile \
--to=karlp@tweak.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox