From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 188C3C433E0 for ; Mon, 21 Dec 2020 14:10:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D45A922BED for ; Mon, 21 Dec 2020 14:10:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726939AbgLUOKq convert rfc822-to-8bit (ORCPT ); Mon, 21 Dec 2020 09:10:46 -0500 Received: from aposti.net ([89.234.176.197]:59550 "EHLO aposti.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725807AbgLUOKp (ORCPT ); Mon, 21 Dec 2020 09:10:45 -0500 Date: Mon, 21 Dec 2020 14:09:53 +0000 From: Paul Cercueil Subject: Re: [PATCH] MIPS: zboot: head.S clean up To: Jiaxun Yang Cc: linux-mips@vger.kernel.org, Thomas Bogendoerfer , linux-kernel@vger.kernel.org Message-Id: In-Reply-To: <20201221130048.7753-1-jiaxun.yang@flygoat.com> References: <20201221130048.7753-1-jiaxun.yang@flygoat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jiaxun, Le lun. 21 déc. 2020 à 21:00, Jiaxun Yang a écrit : > .cprestore is removed as we don't except Position Independent > zboot ELF. > > .noreorder is also removed and rest instructions is massaged > to improve readability. > > t9 register is used to indirect jump as MIPS ABI requirement. > > Reported-by: Paul Cercueil > Signed-off-by: Jiaxun Yang > --- > arch/mips/boot/compressed/head.S | 17 +++++++---------- > 1 file changed, 7 insertions(+), 10 deletions(-) > > diff --git a/arch/mips/boot/compressed/head.S > b/arch/mips/boot/compressed/head.S > index 409cb483a9ff..977218c90bc8 100644 > --- a/arch/mips/boot/compressed/head.S > +++ b/arch/mips/boot/compressed/head.S > @@ -15,8 +15,6 @@ > #include > #include > > - .set noreorder > - .cprestore > LEAF(start) > start: You can also remove the 'start' label, since it's declared inside the LEAF() macro as well. GNU's assembler won't mind, but LLVM will choke on that. Cheers, -Paul > /* Save boot rom start args */ > @@ -35,21 +33,20 @@ start: > PTR_LA a0, (.heap) /* heap address */ > PTR_LA sp, (.stack + 8192) /* stack address */ > > - PTR_LA ra, 2f > - PTR_LA k0, decompress_kernel > - jr k0 > - nop > + PTR_LA t9, decompress_kernel > + jalr t9 > + > 2: > move a0, s0 > move a1, s1 > move a2, s2 > move a3, s3 > - PTR_LI k0, KERNEL_ENTRY > - jr k0 > - nop > + PTR_LI t9, KERNEL_ENTRY > + jalr t9 > + > 3: > b 3b > - nop > + > END(start) > > .comm .heap,BOOT_HEAP_SIZE,4 > -- > 2.29.2 >