Re: Question about node naming in [PATCH v3 13/18] ARM: dts: qcom: sdx55: Add spmi node

Manivannan Sadhasivam
2021-12-22T09:19:18Z

On Tue, Dec 21, 2021 at 12:42:25PM +0530, Manivannan Sadhasivam wrote:
> On Mon, Dec 20, 2021 at 09:27:17PM +0100, David Heidelberg wrote:
> > Hello Manivannan,
> >
> > I'd like to ask, if you had any particular reason to name node `qcom,spmi@`
> > instead of basic `spmi@`.
> >
>
> "spmi" node label was not documented by devicetree spec at that time. So I was
> using "qcom,spmi" but it was not correct either.
>
> I've submitted a PR now to devicetree-spec repo [1] for listing it as the
> generic node name. So once it got accepted, we can use "spmi@" for the node
> name.
>

PR is merged now. So you can proceed with using "spmi" node name in all dts.

Thanks,
Mani

> Thanks,
> Mani
>
> [1] https://github.com/devicetree-org/devicetree-specification/pull/50
>
> > I'm currently converting binding for
> > Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb and I'm
> > considering adding qcom,spmi into qcom,spmi-pmic-arb or just rename this and
> > arch/arm64/boot/dts/qcom/msm8996.dtsi `qcom,spmi@` occurences to `spmi@`.
> >
> > Ideas, inputs?
> >
> > Thank you
> > David
> >
> >