* [PATCH iwl-next v1] ixgbevf: remove unused fields from struct ixgbevf_adapter
@ 2025-07-17 8:46 Yuto Ohnuki
2025-07-17 9:29 ` [Intel-wired-lan] " Dawid Osuchowski
2025-07-17 9:33 ` Loktionov, Aleksandr
0 siblings, 2 replies; 6+ messages in thread
From: Yuto Ohnuki @ 2025-07-17 8:46 UTC (permalink / raw)
To: Tony Nguyen, Przemek Kitszel
Cc: Andrew Lunn, David S . Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, intel-wired-lan, netdev, linux-kernel, Yuto Ohnuki
Remove hw_rx_no_dma_resources and eitr_param fields from struct
ixgbevf_adapter since these fields are never referenced in the driver.
Note that the interrupt throttle rate is controlled by the
rx_itr_setting and tx_itr_setting variables.
This change simplifies the ixgbevf driver by removing unused fields,
which improves maintainability.
Signed-off-by: Yuto Ohnuki <ytohnuki@amazon.com>
---
drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
index 4384e892f967..3a379e6a3a2a 100644
--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
@@ -346,7 +346,6 @@ struct ixgbevf_adapter {
int num_rx_queues;
struct ixgbevf_ring *rx_ring[MAX_TX_QUEUES]; /* One per active queue */
u64 hw_csum_rx_error;
- u64 hw_rx_no_dma_resources;
int num_msix_vectors;
u64 alloc_rx_page_failed;
u64 alloc_rx_buff_failed;
@@ -363,8 +362,6 @@ struct ixgbevf_adapter {
/* structs defined in ixgbe_vf.h */
struct ixgbe_hw hw;
u16 msg_enable;
- /* Interrupt Throttle Rate */
- u32 eitr_param;
struct ixgbevf_hw_stats stats;
--
2.47.1
Amazon Web Services EMEA SARL, 38 avenue John F. Kennedy, L-1855 Luxembourg, R.C.S. Luxembourg B186284
Amazon Web Services EMEA SARL, Irish Branch, One Burlington Plaza, Burlington Road, Dublin 4, Ireland, branch registration number 908705
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Intel-wired-lan] [PATCH iwl-next v1] ixgbevf: remove unused fields from struct ixgbevf_adapter
2025-07-17 8:46 [PATCH iwl-next v1] ixgbevf: remove unused fields from struct ixgbevf_adapter Yuto Ohnuki
@ 2025-07-17 9:29 ` Dawid Osuchowski
2025-07-17 9:33 ` Loktionov, Aleksandr
1 sibling, 0 replies; 6+ messages in thread
From: Dawid Osuchowski @ 2025-07-17 9:29 UTC (permalink / raw)
To: Yuto Ohnuki, Tony Nguyen, Przemek Kitszel
Cc: Andrew Lunn, David S . Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, intel-wired-lan, netdev, linux-kernel
On 2025-07-17 10:46 AM, Yuto Ohnuki wrote:
> Remove hw_rx_no_dma_resources and eitr_param fields from struct
> ixgbevf_adapter since these fields are never referenced in the driver.
>
> Note that the interrupt throttle rate is controlled by the
> rx_itr_setting and tx_itr_setting variables.
>
> This change simplifies the ixgbevf driver by removing unused fields,
> which improves maintainability.
>
> Signed-off-by: Yuto Ohnuki <ytohnuki@amazon.com>
> ---
> drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
> index 4384e892f967..3a379e6a3a2a 100644
> --- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
> +++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
> @@ -346,7 +346,6 @@ struct ixgbevf_adapter {
> int num_rx_queues;
> struct ixgbevf_ring *rx_ring[MAX_TX_QUEUES]; /* One per active queue */
> u64 hw_csum_rx_error;
> - u64 hw_rx_no_dma_resources;
> int num_msix_vectors;
> u64 alloc_rx_page_failed;
> u64 alloc_rx_buff_failed;
> @@ -363,8 +362,6 @@ struct ixgbevf_adapter {
> /* structs defined in ixgbe_vf.h */
> struct ixgbe_hw hw;
> u16 msg_enable;
> - /* Interrupt Throttle Rate */
> - u32 eitr_param;
>
> struct ixgbevf_hw_stats stats;
>
Reviewed-by: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>
Thanks,
Dawid
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [Intel-wired-lan] [PATCH iwl-next v1] ixgbevf: remove unused fields from struct ixgbevf_adapter
2025-07-17 8:46 [PATCH iwl-next v1] ixgbevf: remove unused fields from struct ixgbevf_adapter Yuto Ohnuki
2025-07-17 9:29 ` [Intel-wired-lan] " Dawid Osuchowski
@ 2025-07-17 9:33 ` Loktionov, Aleksandr
2025-07-17 20:08 ` Tony Nguyen
1 sibling, 1 reply; 6+ messages in thread
From: Loktionov, Aleksandr @ 2025-07-17 9:33 UTC (permalink / raw)
To: Yuto Ohnuki, Nguyen, Anthony L, Kitszel, Przemyslaw
Cc: Andrew Lunn, David S . Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf
> Of Yuto Ohnuki
> Sent: Thursday, July 17, 2025 10:46 AM
> To: Nguyen, Anthony L <anthony.l.nguyen@intel.com>; Kitszel,
> Przemyslaw <przemyslaw.kitszel@intel.com>
> Cc: Andrew Lunn <andrew+netdev@lunn.ch>; David S . Miller
> <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub
> Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; intel-
> wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; Yuto Ohnuki <ytohnuki@amazon.com>
> Subject: [Intel-wired-lan] [PATCH iwl-next v1] ixgbevf: remove unused
> fields from struct ixgbevf_adapter
>
> Remove hw_rx_no_dma_resources and eitr_param fields from struct
> ixgbevf_adapter since these fields are never referenced in the driver.
>
> Note that the interrupt throttle rate is controlled by the
> rx_itr_setting and tx_itr_setting variables.
>
> This change simplifies the ixgbevf driver by removing unused fields,
> which improves maintainability.
>
> Signed-off-by: Yuto Ohnuki <ytohnuki@amazon.com>
Can you add 'Fixes:' or 'Cleanup:' tag ?
Alex
> ---
> drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
> b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
> index 4384e892f967..3a379e6a3a2a 100644
> --- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
> +++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
> @@ -346,7 +346,6 @@ struct ixgbevf_adapter {
> int num_rx_queues;
> struct ixgbevf_ring *rx_ring[MAX_TX_QUEUES]; /* One per active
> queue */
> u64 hw_csum_rx_error;
> - u64 hw_rx_no_dma_resources;
> int num_msix_vectors;
> u64 alloc_rx_page_failed;
> u64 alloc_rx_buff_failed;
> @@ -363,8 +362,6 @@ struct ixgbevf_adapter {
> /* structs defined in ixgbe_vf.h */
> struct ixgbe_hw hw;
> u16 msg_enable;
> - /* Interrupt Throttle Rate */
> - u32 eitr_param;
>
> struct ixgbevf_hw_stats stats;
>
> --
> 2.47.1
>
>
>
>
> Amazon Web Services EMEA SARL, 38 avenue John F. Kennedy, L-1855
> Luxembourg, R.C.S. Luxembourg B186284
>
> Amazon Web Services EMEA SARL, Irish Branch, One Burlington Plaza,
> Burlington Road, Dublin 4, Ireland, branch registration number 908705
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-wired-lan] [PATCH iwl-next v1] ixgbevf: remove unused fields from struct ixgbevf_adapter
2025-07-17 9:33 ` Loktionov, Aleksandr
@ 2025-07-17 20:08 ` Tony Nguyen
2025-07-21 11:47 ` Loktionov, Aleksandr
0 siblings, 1 reply; 6+ messages in thread
From: Tony Nguyen @ 2025-07-17 20:08 UTC (permalink / raw)
To: Loktionov, Aleksandr, Yuto Ohnuki, Kitszel, Przemyslaw
Cc: Andrew Lunn, David S . Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
On 7/17/2025 2:33 AM, Loktionov, Aleksandr wrote:
>
>
>> -----Original Message-----
>> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf
>> Of Yuto Ohnuki
>> Sent: Thursday, July 17, 2025 10:46 AM
>> To: Nguyen, Anthony L <anthony.l.nguyen@intel.com>; Kitszel,
>> Przemyslaw <przemyslaw.kitszel@intel.com>
>> Cc: Andrew Lunn <andrew+netdev@lunn.ch>; David S . Miller
>> <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub
>> Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; intel-
>> wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux-
>> kernel@vger.kernel.org; Yuto Ohnuki <ytohnuki@amazon.com>
>> Subject: [Intel-wired-lan] [PATCH iwl-next v1] ixgbevf: remove unused
>> fields from struct ixgbevf_adapter
>>
>> Remove hw_rx_no_dma_resources and eitr_param fields from struct
>> ixgbevf_adapter since these fields are never referenced in the driver.
>>
>> Note that the interrupt throttle rate is controlled by the
>> rx_itr_setting and tx_itr_setting variables.
>>
>> This change simplifies the ixgbevf driver by removing unused fields,
>> which improves maintainability.
>>
>> Signed-off-by: Yuto Ohnuki <ytohnuki@amazon.com>
> Can you add 'Fixes:' or 'Cleanup:' tag ?
As there's no user bug, I don't believe this warrants a Fixes: tag.
I'm not familiar with a Cleanup: tag; on quick browse of git log, I'm
not seeing one being used(?)
Thanks,
Tony
>
> Alex
>> ---
>> drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
>> b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
>> index 4384e892f967..3a379e6a3a2a 100644
>> --- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
>> +++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
>> @@ -346,7 +346,6 @@ struct ixgbevf_adapter {
>> int num_rx_queues;
>> struct ixgbevf_ring *rx_ring[MAX_TX_QUEUES]; /* One per active
>> queue */
>> u64 hw_csum_rx_error;
>> - u64 hw_rx_no_dma_resources;
>> int num_msix_vectors;
>> u64 alloc_rx_page_failed;
>> u64 alloc_rx_buff_failed;
>> @@ -363,8 +362,6 @@ struct ixgbevf_adapter {
>> /* structs defined in ixgbe_vf.h */
>> struct ixgbe_hw hw;
>> u16 msg_enable;
>> - /* Interrupt Throttle Rate */
>> - u32 eitr_param;
>>
>> struct ixgbevf_hw_stats stats;
>>
>> --
>> 2.47.1
>>
>>
>>
>>
>> Amazon Web Services EMEA SARL, 38 avenue John F. Kennedy, L-1855
>> Luxembourg, R.C.S. Luxembourg B186284
>>
>> Amazon Web Services EMEA SARL, Irish Branch, One Burlington Plaza,
>> Burlington Road, Dublin 4, Ireland, branch registration number 908705
>>
>>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [Intel-wired-lan] [PATCH iwl-next v1] ixgbevf: remove unused fields from struct ixgbevf_adapter
2025-07-17 20:08 ` Tony Nguyen
@ 2025-07-21 11:47 ` Loktionov, Aleksandr
2025-07-21 16:12 ` Tony Nguyen
0 siblings, 1 reply; 6+ messages in thread
From: Loktionov, Aleksandr @ 2025-07-21 11:47 UTC (permalink / raw)
To: Nguyen, Anthony L, Yuto Ohnuki, Kitszel, Przemyslaw
Cc: Andrew Lunn, David S . Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
> -----Original Message-----
> From: Nguyen, Anthony L <anthony.l.nguyen@intel.com>
> Sent: Thursday, July 17, 2025 10:08 PM
> To: Loktionov, Aleksandr <aleksandr.loktionov@intel.com>; Yuto Ohnuki
> <ytohnuki@amazon.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@intel.com>
> Cc: Andrew Lunn <andrew+netdev@lunn.ch>; David S . Miller
> <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub
> Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; intel-
> wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1] ixgbevf: remove
> unused fields from struct ixgbevf_adapter
>
>
>
> On 7/17/2025 2:33 AM, Loktionov, Aleksandr wrote:
> >
> >
> >> -----Original Message-----
> >> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On
> Behalf
> >> Of Yuto Ohnuki
> >> Sent: Thursday, July 17, 2025 10:46 AM
> >> To: Nguyen, Anthony L <anthony.l.nguyen@intel.com>; Kitszel,
> >> Przemyslaw <przemyslaw.kitszel@intel.com>
> >> Cc: Andrew Lunn <andrew+netdev@lunn.ch>; David S . Miller
> >> <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub
> >> Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; intel-
> >> wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux-
> >> kernel@vger.kernel.org; Yuto Ohnuki <ytohnuki@amazon.com>
> >> Subject: [Intel-wired-lan] [PATCH iwl-next v1] ixgbevf: remove
> unused
> >> fields from struct ixgbevf_adapter
> >>
> >> Remove hw_rx_no_dma_resources and eitr_param fields from struct
> >> ixgbevf_adapter since these fields are never referenced in the
> driver.
> >>
> >> Note that the interrupt throttle rate is controlled by the
> >> rx_itr_setting and tx_itr_setting variables.
> >>
> >> This change simplifies the ixgbevf driver by removing unused
> fields,
> >> which improves maintainability.
> >>
> >> Signed-off-by: Yuto Ohnuki <ytohnuki@amazon.com>
> > Can you add 'Fixes:' or 'Cleanup:' tag ?
>
> As there's no user bug, I don't believe this warrants a Fixes: tag.
>
> I'm not familiar with a Cleanup: tag; on quick browse of git log, I'm
> not seeing one being used(?)
>
> Thanks,
> Tony
>
Good day, Tony
Examples of the tag could be get: git log --grep="^Cleanup:" --oneline
ff9fb2e Merge tag 'samsung-soc-5.19' of git://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux into arm/soc
15b5b76 Merge tag 'samsung-soc-5.19' of git://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux into arm/drivers
566d336 mm: warn on deleting redirtied only if accounted
35189b8 kernel/acct.c: use #elif instead of #end and #elif
0bbe4ce iommu/amd: Fix the overwritten field in IVMD header
521ec1c Merge tag 'renesas-dt-bindings-for-v4.18' of https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas into next/dt
878e917 Merge tag 'renesas-dt2-for-v4.13' of https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas into next/dt
c3acc32 Merge tag 'renesas-arm64-dt2-for-v4.12' of https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas into next/dt64
8855e14 Merge tag 'renesas-dt-for-v4.12' of https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas into next/dt
5344df6 Merge tag 'renesas-arm64-dt-for-v4.12' of https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas into next/dt64
837a90e netfilter: ipset: Regroup ip_set_put_extensions and add extern
...
> >
> > Alex
> >> ---
> >> drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 3 ---
> >> 1 file changed, 3 deletions(-)
> >>
> >> diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
> >> b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
> >> index 4384e892f967..3a379e6a3a2a 100644
> >> --- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
> >> +++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
> >> @@ -346,7 +346,6 @@ struct ixgbevf_adapter {
> >> int num_rx_queues;
> >> struct ixgbevf_ring *rx_ring[MAX_TX_QUEUES]; /* One per active
> >> queue */
> >> u64 hw_csum_rx_error;
> >> - u64 hw_rx_no_dma_resources;
> >> int num_msix_vectors;
> >> u64 alloc_rx_page_failed;
> >> u64 alloc_rx_buff_failed;
> >> @@ -363,8 +362,6 @@ struct ixgbevf_adapter {
> >> /* structs defined in ixgbe_vf.h */
> >> struct ixgbe_hw hw;
> >> u16 msg_enable;
> >> - /* Interrupt Throttle Rate */
> >> - u32 eitr_param;
> >>
> >> struct ixgbevf_hw_stats stats;
> >>
> >> --
> >> 2.47.1
> >>
> >>
> >>
> >>
> >> Amazon Web Services EMEA SARL, 38 avenue John F. Kennedy, L-1855
> >> Luxembourg, R.C.S. Luxembourg B186284
> >>
> >> Amazon Web Services EMEA SARL, Irish Branch, One Burlington Plaza,
> >> Burlington Road, Dublin 4, Ireland, branch registration number
> 908705
> >>
> >>
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-wired-lan] [PATCH iwl-next v1] ixgbevf: remove unused fields from struct ixgbevf_adapter
2025-07-21 11:47 ` Loktionov, Aleksandr
@ 2025-07-21 16:12 ` Tony Nguyen
0 siblings, 0 replies; 6+ messages in thread
From: Tony Nguyen @ 2025-07-21 16:12 UTC (permalink / raw)
To: Loktionov, Aleksandr, Yuto Ohnuki, Kitszel, Przemyslaw
Cc: Andrew Lunn, David S . Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
On 7/21/2025 4:47 AM, Loktionov, Aleksandr wrote:
>
>
>> -----Original Message-----
>> From: Nguyen, Anthony L <anthony.l.nguyen@intel.com>
>> Sent: Thursday, July 17, 2025 10:08 PM
>> To: Loktionov, Aleksandr <aleksandr.loktionov@intel.com>; Yuto Ohnuki
>> <ytohnuki@amazon.com>; Kitszel, Przemyslaw
>> <przemyslaw.kitszel@intel.com>
>> Cc: Andrew Lunn <andrew+netdev@lunn.ch>; David S . Miller
>> <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub
>> Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; intel-
>> wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux-
>> kernel@vger.kernel.org
>> Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1] ixgbevf: remove
>> unused fields from struct ixgbevf_adapter
>>
>>
>>
>> On 7/17/2025 2:33 AM, Loktionov, Aleksandr wrote:
>>>
>>>
>>>> -----Original Message-----
>>>> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On
>> Behalf
>>>> Of Yuto Ohnuki
>>>> Sent: Thursday, July 17, 2025 10:46 AM
>>>> To: Nguyen, Anthony L <anthony.l.nguyen@intel.com>; Kitszel,
>>>> Przemyslaw <przemyslaw.kitszel@intel.com>
>>>> Cc: Andrew Lunn <andrew+netdev@lunn.ch>; David S . Miller
>>>> <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub
>>>> Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; intel-
>>>> wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux-
>>>> kernel@vger.kernel.org; Yuto Ohnuki <ytohnuki@amazon.com>
>>>> Subject: [Intel-wired-lan] [PATCH iwl-next v1] ixgbevf: remove
>> unused
>>>> fields from struct ixgbevf_adapter
>>>>
>>>> Remove hw_rx_no_dma_resources and eitr_param fields from struct
>>>> ixgbevf_adapter since these fields are never referenced in the
>> driver.
>>>>
>>>> Note that the interrupt throttle rate is controlled by the
>>>> rx_itr_setting and tx_itr_setting variables.
>>>>
>>>> This change simplifies the ixgbevf driver by removing unused
>> fields,
>>>> which improves maintainability.
>>>>
>>>> Signed-off-by: Yuto Ohnuki <ytohnuki@amazon.com>
>>> Can you add 'Fixes:' or 'Cleanup:' tag ?
>>
>> As there's no user bug, I don't believe this warrants a Fixes: tag.
>>
>> I'm not familiar with a Cleanup: tag; on quick browse of git log, I'm
>> not seeing one being used(?)
>>
>> Thanks,
>> Tony
>>
> Good day, Tony
> Examples of the tag could be get: git log --grep="^Cleanup:" --oneline
> ff9fb2e Merge tag 'samsung-soc-5.19' of git://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux into arm/soc
> 15b5b76 Merge tag 'samsung-soc-5.19' of git://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux into arm/drivers
> 566d336 mm: warn on deleting redirtied only if accounted
> 35189b8 kernel/acct.c: use #elif instead of #end and #elif
> 0bbe4ce iommu/amd: Fix the overwritten field in IVMD header
> 521ec1c Merge tag 'renesas-dt-bindings-for-v4.18' of https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas into next/dt
> 878e917 Merge tag 'renesas-dt2-for-v4.13' of https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas into next/dt
> c3acc32 Merge tag 'renesas-arm64-dt2-for-v4.12' of https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas into next/dt64
> 8855e14 Merge tag 'renesas-dt-for-v4.12' of https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas into next/dt
> 5344df6 Merge tag 'renesas-arm64-dt-for-v4.12' of https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas into next/dt64
> 837a90e netfilter: ipset: Regroup ip_set_put_extensions and add extern
> ...
From what I saw all the 'Merge tags' are using this as part of the pull
request to categorize the 'Cleanup:' patches. The other patches are
using this line in the commit message to explain the cleanup that is
being done. I'm not opposed to the latter, but it seems the commit
message gives a reasonable explanation already and I don't think it's
worth respinning this to repeat, or reformat, what's already there.
Thanks,
Tony
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-07-21 16:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-17 8:46 [PATCH iwl-next v1] ixgbevf: remove unused fields from struct ixgbevf_adapter Yuto Ohnuki
2025-07-17 9:29 ` [Intel-wired-lan] " Dawid Osuchowski
2025-07-17 9:33 ` Loktionov, Aleksandr
2025-07-17 20:08 ` Tony Nguyen
2025-07-21 11:47 ` Loktionov, Aleksandr
2025-07-21 16:12 ` Tony Nguyen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).