From: Marco Scardovi <scardracs@disroot.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: corentin.chary@gmail.com, luke@ljones.dev,
denis.benato@linux.dev, Hans de Goede <hansg@kernel.org>,
platform-driver-x86@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: asus-armoury: fix Use-After-Free and memory leak in driver init
Date: Wed, 01 Jul 2026 15:25:42 +0200 [thread overview]
Message-ID: <IGLRyNPIS6-bIiJOwf3pHw@disroot.org> (raw)
In-Reply-To: <f1c70b62-7e5d-7ed3-afbf-b80e3a0f2daf@linux.intel.com>
In data mercoledì 1 luglio 2026 13:01:12 Ora legale dell’Europa centrale, Ilpo Järvinen ha scritto:
> On Sun, 14 Jun 2026, Marco Scardovi wrote:
>
> > ...
>
> Why do you need to set these to NULL?
>
> I'd also prefer to use goto + rollback path pattern even if there's only
> one entry at this point.
>
Hi Ilpo,
thanks for looking into it. If I have to be completely honest is because
I didn't think at it as a solution: I'd also prefer to use goto + rollback.
I'll open a new thread with your suggestion.
With best regards,
Marco
prev parent reply other threads:[~2026-07-01 16:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-14 16:37 [PATCH] platform/x86: asus-armoury: fix Use-After-Free and memory leak in driver init Marco Scardovi
2026-07-01 11:01 ` Ilpo Järvinen
2026-07-01 13:25 ` Marco Scardovi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=IGLRyNPIS6-bIiJOwf3pHw@disroot.org \
--to=scardracs@disroot.org \
--cc=corentin.chary@gmail.com \
--cc=denis.benato@linux.dev \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox