From: "Alex Scheele" <alex@packetstorm.nu>
To: "Roger Massey" <rmassey@avaya.com>
Cc: "Lkml" <linux-kernel@vger.kernel.org>
Subject: RE: 2.4.17 panic on boot - patch for ide-pci
Date: Tue, 5 Feb 2002 18:59:09 +0100 [thread overview]
Message-ID: <IOEMLDKDBECBHMIOCKODCECACJAA.alex@packetstorm.nu> (raw)
In-Reply-To: <029b01c1ae68$5df20b20$12320987@dr.avaya.com>
[snip]
> --- drivers/ide/ide-pci.c Mon Feb 4 19:44:02 2002
> +++ drivers/ide/ide-pci.orig.c Mon Feb 4 19:37:50 2002
> @@ -836,11 +836,7 @@
> pci_read_config_dword(dev, PCI_CLASS_REVISION, &class_rev);
> class_rev &= 0xff;
>
> - if(class_rev >= (sizeof(chipset_names)/sizeof(char *))) {
> - class_rev = (sizeof(chipset_names)/sizeof(char *)) - 1;
> - }
> -
> - strncpy(d->name, chipset_names[class_rev], strlen(d->name));
> + strcpy(d->name, chipset_names[class_rev]);
>
> switch(class_rev) {
> case 4:
> --- drivers/ide/hpt366.c Mon Feb 4 19:32:45 2002
> +++ drivers/ide/hpt366.orig.c Mon Feb 4 19:33:30 2002
> @@ -214,9 +214,6 @@
> pci_read_config_dword(bmide_dev, PCI_CLASS_REVISION, &class_rev);
> class_rev &= 0xff;
>
> - if(class_rev >= (sizeof(chipset_names)/sizeof(char *)))
> - class_rev = (sizeof(chipset_names)/sizeof(char *)) -1;
> -
> /*
> * at that point bibma+0x2 et bibma+0xa are byte registers
> * to investigate:
Seems u diffed the wrong way :) original file should be first.
--
Alex (alex@packetstorm.nu)
prev parent reply other threads:[~2002-02-05 17:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-05 17:13 2.4.17 panic on boot - patch for ide-pci Roger Massey
2002-02-05 17:59 ` Alex Scheele [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=IOEMLDKDBECBHMIOCKODCECACJAA.alex@packetstorm.nu \
--to=alex@packetstorm.nu \
--cc=linux-kernel@vger.kernel.org \
--cc=rmassey@avaya.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox