From: Paul Cercueil <paul@crapouillou.net>
To: Siarhei Volkau <lis8215@gmail.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org
Subject: Re: [PATCH v2 1/4] MIPS: ingenic: add new machine type MACH_JZ4755
Date: Mon, 17 Oct 2022 10:09:56 +0100 [thread overview]
Message-ID: <K44WJR.2LW3IFMAMTV73@crapouillou.net> (raw)
In-Reply-To: <20221016150110.3020451-2-lis8215@gmail.com>
Hi Siarhei,
Le dim., oct. 16 2022 at 18:01:06 +0300, Siarhei Volkau
<lis8215@gmail.com> a écrit :
> which is close to jz4725b because it is actually a low price
> successor of the jz4755.
> It has the same MIPS32r1 core with Xburst(R) extension
> MXU version 1 release 2.
>
> Signed-off-by: Siarhei Volkau <lis8215@gmail.com>
This patch doesn't really belong in the CGU patchset. It should go
through the MIPS tree.
I see why you include it, but you do not need to have the MACH_JZ4755
symbol defined anywhere for the "default MACH_JZ4755" to work, it will
just default to false until the patchset that adds JZ4755 support is
merged in the MIPS tree.
Cheers,
-Paul
> ---
> arch/mips/ingenic/Kconfig | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/mips/ingenic/Kconfig b/arch/mips/ingenic/Kconfig
> index f595b339a..edd84cf13 100644
> --- a/arch/mips/ingenic/Kconfig
> +++ b/arch/mips/ingenic/Kconfig
> @@ -4,6 +4,7 @@ config MACH_INGENIC_GENERIC
> bool
> select MACH_INGENIC
> select MACH_JZ4740
> + select MACH_JZ4755
> select MACH_JZ4725B
> select MACH_JZ4770
> select MACH_JZ4780
> @@ -53,6 +54,10 @@ config MACH_JZ4740
> bool
> select SYS_HAS_CPU_MIPS32_R1
>
> +config MACH_JZ4755
> + bool
> + select SYS_HAS_CPU_MIPS32_R1
> +
> config MACH_JZ4770
> bool
> select MIPS_CPU_SCACHE
> --
> 2.36.1
>
next prev parent reply other threads:[~2022-10-17 9:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-16 15:01 [PATCH v2 0/4] Add Ingenic JZ4755 CGU driver Siarhei Volkau
2022-10-16 15:01 ` [PATCH v2 1/4] MIPS: ingenic: add new machine type MACH_JZ4755 Siarhei Volkau
2022-10-17 9:09 ` Paul Cercueil [this message]
2022-10-17 16:40 ` Siarhei Volkau
2022-10-16 15:01 ` [PATCH v2 2/4] dt-bindings: ingenic: Add support for the JZ4755 CGU Siarhei Volkau
2022-10-16 15:31 ` Krzysztof Kozlowski
2022-10-16 15:01 ` [PATCH v2 3/4] dt-bindings: clock: Add Ingenic JZ4755 CGU header Siarhei Volkau
2022-10-16 15:32 ` Krzysztof Kozlowski
2022-10-16 18:21 ` Siarhei Volkau
2022-10-17 1:00 ` Krzysztof Kozlowski
2022-10-17 18:34 ` Rob Herring
2022-10-16 15:01 ` [PATCH v2 4/4] clk: Add Ingenic JZ4755 CGU driver Siarhei Volkau
2022-10-17 9:24 ` Paul Cercueil
2022-10-17 17:10 ` Siarhei Volkau
2022-10-17 17:24 ` Paul Cercueil
2022-10-17 18:07 ` Siarhei Volkau
2022-10-18 13:30 ` Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=K44WJR.2LW3IFMAMTV73@crapouillou.net \
--to=paul@crapouillou.net \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=lis8215@gmail.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox