From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1F5BC4332F for ; Wed, 5 Jan 2022 09:41:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238991AbiAEJl4 convert rfc822-to-8bit (ORCPT ); Wed, 5 Jan 2022 04:41:56 -0500 Received: from aposti.net ([89.234.176.197]:39238 "EHLO aposti.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234299AbiAEJlz (ORCPT ); Wed, 5 Jan 2022 04:41:55 -0500 Date: Wed, 05 Jan 2022 09:41:44 +0000 From: Paul Cercueil Subject: Re: [PATCH 1/2] dt-bindings: hwmon: Introduce common properties To: Rob Herring Cc: Jean Delvare , Guenter Roeck , linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Message-Id: In-Reply-To: References: <20211221175029.144906-1-paul@crapouillou.net> <20211221175029.144906-2-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, Le mer., déc. 22 2021 at 15:36:23 -0400, Rob Herring a écrit : > On Tue, Dec 21, 2021 at 05:50:28PM +0000, Paul Cercueil wrote: >> Introduce a file for common properties of hwmon sensors. >> >> As of now it contains only the "label" property, which can contain a >> descriptive label that allows to uniquely identify a device within >> the >> system. > > I don't think we need this. What we need is a global (in dtschema) > type definition and then any users just add 'label: true'. I created a PR there: https://github.com/devicetree-org/dt-schema/pull/65 Cheers, -Paul > >> >> Signed-off-by: Paul Cercueil >> --- >> .../devicetree/bindings/hwmon/common.yaml | 31 >> +++++++++++++++++++ >> 1 file changed, 31 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/hwmon/common.yaml >> >> diff --git a/Documentation/devicetree/bindings/hwmon/common.yaml >> b/Documentation/devicetree/bindings/hwmon/common.yaml >> new file mode 100644 >> index 000000000000..997f74127d8c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/hwmon/common.yaml >> @@ -0,0 +1,31 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/hwmon/common.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Common properties for hwmon sensors >> + >> +maintainers: >> + - Jean Delvare >> + - Guenter Roeck >> + >> +description: | >> + This document defines device tree properties common to several >> hwmon >> + sensors. It doesn't constitue a device tree binding >> specification by itself but >> + is meant to be referenced by device tree bindings. >> + >> + When referenced from sensor tree bindings the properties defined >> in this >> + document are defined as follows. The sensor tree bindings are >> responsible for >> + defining whether each property is required or optional. >> + >> +properties: >> + label: >> + $ref: /schemas/types.yaml#/definitions/string >> + description: > >> + Descriptive label that allows to uniquely identify a device >> within >> + the system. >> + >> +additionalProperties: true >> + >> +... >> -- >> 2.34.1 >> >>