public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Luke Jones <luke@ljones.dev>
To: Takashi Iwai <tiwai@suse.de>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
	perex@perex.cz, tiwai@suse.com
Subject: Re: [PATCH] ALSA: hda/realtek: Add quirk for 2nd ASUS GU603
Date: Thu, 04 May 2023 12:41:09 +1200	[thread overview]
Message-ID: <L8Z3UR.OO4MSH3SX5VD3@ljones.dev> (raw)
In-Reply-To: <87h6sune0i.wl-tiwai@suse.de>



On Wed, May 3 2023 at 08:08:13 +0200, Takashi Iwai <tiwai@suse.de> 
wrote:
> On Wed, 03 May 2023 05:50:35 +0200,
> Luke D. Jones wrote:
>> 
>>  Add quirk for GU603 with 0x1c62 variant of codec.
>> 
>>  Signed-off-by: Luke D. Jones <luke@ljones.dev>
>>  ---
>>   sound/pci/hda/patch_realtek.c | 1 +
>>   1 file changed, 1 insertion(+)
>> 
>>  diff --git a/sound/pci/hda/patch_realtek.c 
>> b/sound/pci/hda/patch_realtek.c
>>  index 3b9f077a227f..4a585050edc3 100644
>>  --- a/sound/pci/hda/patch_realtek.c
>>  +++ b/sound/pci/hda/patch_realtek.c
>>  @@ -9501,6 +9501,7 @@ static const struct snd_pci_quirk 
>> alc269_fixup_tbl[] = {
>>   	SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A", 
>> ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A),
>>   	SND_PCI_QUIRK(0x1043, 0x1662, "ASUS GV301QH", 
>> ALC294_FIXUP_ASUS_DUAL_SPK),
>>   	SND_PCI_QUIRK(0x1043, 0x16b2, "ASUS GU603", 
>> ALC289_FIXUP_ASUS_GA401),
>>  +	SND_PCI_QUIRK(0x1043, 0x1c62, "ASUS GU603", 
>> ALC289_FIXUP_ASUS_GA401),
>>   	SND_PCI_QUIRK(0x1043, 0x16e3, "ASUS UX50", 
>> ALC269_FIXUP_STEREO_DMIC),
>>   	SND_PCI_QUIRK(0x1043, 0x1740, "ASUS UX430UA", 
>> ALC295_FIXUP_ASUS_DACS),
>>   	SND_PCI_QUIRK(0x1043, 0x17d1, "ASUS UX431FL", 
>> ALC294_FIXUP_ASUS_DUAL_SPK),
> 
> Could you try to put the new entry at the right place?
> The table is sorted in the PCI SSID order.
> 
> 
> thanks,
> 
> Takashi

Sure no problem. Sorry, seems I read `0x1c62` and `0x16c2` :(



  reply	other threads:[~2023-05-04  0:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-03  3:50 [PATCH] ALSA: hda/realtek: Add quirk for 2nd ASUS GU603 Luke D. Jones
2023-05-03  6:08 ` Takashi Iwai
2023-05-04  0:41   ` Luke Jones [this message]
2023-05-05 15:15     ` Takashi Iwai
2023-05-05 23:59       ` Luke Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=L8Z3UR.OO4MSH3SX5VD3@ljones.dev \
    --to=luke@ljones.dev \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox