From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20530C77B75 for ; Thu, 4 May 2023 00:41:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229711AbjEDAlh (ORCPT ); Wed, 3 May 2023 20:41:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229463AbjEDAle (ORCPT ); Wed, 3 May 2023 20:41:34 -0400 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5677599 for ; Wed, 3 May 2023 17:41:33 -0700 (PDT) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 016735C026B; Wed, 3 May 2023 20:41:31 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 03 May 2023 20:41:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ljones.dev; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1683160890; x=1683247290; bh=Wh UV0l8/rjHDLwkMVOzmkF9d+1HvMPc48i2JyNsR/tE=; b=T6ZfHQhsXfaB3ZQK3b g4oOY7rb9xWmYbC0c4eYIUtaUZjFDZlIUuzoch7hhqM5eYmAhKvJ43noNWFFce69 CmDAgxVeDHJuJM6TrSzDIFVkKQWT/qaSrX6/WQ6BPiF/6U7GwN0Kc31y/aqbltDq uxqW4iLtlIp4fs4K4lz6uEyxrXl4QjdB7J5GX9ShaHbq3H+NLp4aUfXNOxZ0AjY2 Z+/rS7o6amq0bfYybyNxq5/JkUKCxt7VX8TUd5o7bkIkUEfANgR76m3phjSiXsci Kl7RUM/obq7oNQBQXkNp7OdtBZHgTMdL1Npl0g3y9dI5ttuO/fhdkRVobVo0cDF/ KNAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1683160890; x=1683247290; bh=WhUV0l8/rjHDL wkMVOzmkF9d+1HvMPc48i2JyNsR/tE=; b=TDekByPZSF4GPV3dp0jEKAPy1J3Aj JGqIbGPfoJr5KEP4O9vD+cujjD1fyrZVJZxEuTkti/JAuqdpy0/ayKRK+QRIqoOR QbBjvJRH7hsDQAA0F+w8yeogiH+jYNCGcVJQ0ViXuaJWfIu2QMXjYp0y53C+il8h TDoBKrJnMN7TknheuQyaUQK9JwflzhScg1oConqiBTREtzhyvVDekQs0UduI/Dwn aJaNi3dU7+rLH17LEBVFyfzE6DlJeQVDIS/efd8sc1exg2UoYLab9yTZB8/Qn2st WAdMiZCVxvbmZAwtwuiUjRM303rUu3z007fvhrRacNps307cW+Kbff/hA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfedvledgfeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhuffvvefkjghfofggtgesthdtredtredtvdenucfhrhhomhepnfhukhgv ucflohhnvghsuceolhhukhgvsehljhhonhgvshdruggvvheqnecuggftrfgrthhtvghrnh epvddvgeeltdehfeeijefgveegfeeihfdtveetfeetudfhvedtfeeltefhteegledunecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheplhhukhgvse hljhhonhgvshdruggvvh X-ME-Proxy: Feedback-ID: i5ec1447f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 3 May 2023 20:41:24 -0400 (EDT) Date: Thu, 04 May 2023 12:41:09 +1200 From: Luke Jones Subject: Re: [PATCH] ALSA: hda/realtek: Add quirk for 2nd ASUS GU603 To: Takashi Iwai Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, perex@perex.cz, tiwai@suse.com Message-Id: In-Reply-To: <87h6sune0i.wl-tiwai@suse.de> References: <20230503035035.254346-1-luke@ljones.dev> <87h6sune0i.wl-tiwai@suse.de> X-Mailer: geary/43.0 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 3 2023 at 08:08:13 +0200, Takashi Iwai wrote: > On Wed, 03 May 2023 05:50:35 +0200, > Luke D. Jones wrote: >> >> Add quirk for GU603 with 0x1c62 variant of codec. >> >> Signed-off-by: Luke D. Jones >> --- >> sound/pci/hda/patch_realtek.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/sound/pci/hda/patch_realtek.c >> b/sound/pci/hda/patch_realtek.c >> index 3b9f077a227f..4a585050edc3 100644 >> --- a/sound/pci/hda/patch_realtek.c >> +++ b/sound/pci/hda/patch_realtek.c >> @@ -9501,6 +9501,7 @@ static const struct snd_pci_quirk >> alc269_fixup_tbl[] = { >> SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A", >> ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A), >> SND_PCI_QUIRK(0x1043, 0x1662, "ASUS GV301QH", >> ALC294_FIXUP_ASUS_DUAL_SPK), >> SND_PCI_QUIRK(0x1043, 0x16b2, "ASUS GU603", >> ALC289_FIXUP_ASUS_GA401), >> + SND_PCI_QUIRK(0x1043, 0x1c62, "ASUS GU603", >> ALC289_FIXUP_ASUS_GA401), >> SND_PCI_QUIRK(0x1043, 0x16e3, "ASUS UX50", >> ALC269_FIXUP_STEREO_DMIC), >> SND_PCI_QUIRK(0x1043, 0x1740, "ASUS UX430UA", >> ALC295_FIXUP_ASUS_DACS), >> SND_PCI_QUIRK(0x1043, 0x17d1, "ASUS UX431FL", >> ALC294_FIXUP_ASUS_DUAL_SPK), > > Could you try to put the new entry at the right place? > The table is sorted in the PCI SSID order. > > > thanks, > > Takashi Sure no problem. Sorry, seems I read `0x1c62` and `0x16c2` :(