From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A74D9C433F5 for ; Thu, 23 Dec 2021 10:12:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347641AbhLWKMa convert rfc822-to-8bit (ORCPT ); Thu, 23 Dec 2021 05:12:30 -0500 Received: from aposti.net ([89.234.176.197]:37094 "EHLO aposti.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242964AbhLWKM3 (ORCPT ); Thu, 23 Dec 2021 05:12:29 -0500 Date: Thu, 23 Dec 2021 10:12:21 +0000 From: Paul Cercueil Subject: Re: [PATCH 1/2] dt-bindings: hwmon: Introduce common properties To: Rob Herring Cc: Jean Delvare , Guenter Roeck , linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Message-Id: In-Reply-To: References: <20211221175029.144906-1-paul@crapouillou.net> <20211221175029.144906-2-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le jeu., déc. 23 2021 at 09:19:43 +0000, Paul Cercueil a écrit : > Hi Rob, > > Le mer., déc. 22 2021 at 15:36:23 -0400, Rob Herring > a écrit : >> On Tue, Dec 21, 2021 at 05:50:28PM +0000, Paul Cercueil wrote: >>> Introduce a file for common properties of hwmon sensors. >>> >>> As of now it contains only the "label" property, which can contain >>> a >>> descriptive label that allows to uniquely identify a device within >>> the >>> system. >> >> I don't think we need this. What we need is a global (in dtschema) >> type definition and then any users just add 'label: true'. > > Well, users would also need to set an actual label, otherwise this > defeats the point :) Disregard that, I'm stupid. 'label: true' is for the schema and not the DTS files. -Paul