From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00CB93AE707 for ; Tue, 28 Apr 2026 11:43:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777376618; cv=pass; b=IdIY6n6ep86WhQ5GIM8DXIoj5scKnelQjgoaghh+uIhO9ra1gr2636v6GDN6zDB6vKTLKRm7gJnzpDYHGcXU6HFprZfpe9+4h0e76A4+n2/Dz914MKDuGnRipBp9XHpsR6Cs07tURFOCqr/HJxEQd/eSCu2vOvyqNwtSPm6S5Tk= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777376618; c=relaxed/simple; bh=rRdgu/iiSvCZgr1rL5F4HqDEey+QjtPqj5uQioUoz2U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=rs5311Nepl7g+8PDs7f9AuS08xjeNgOqC4Na86J7Lc/HbQDyCnYXnRe+ilnJ56ZIo0yyHe0rCX8avuuFou+I1dlJR4mK23lXSiI8lWvNNO6I32Ner5FA8+fDDTdzAAQFKrQ7dWmmvFRl6FURLRqCVVFLBtY7wYlc3RVodG2nCA4= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=TMxJ+KoQ; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="TMxJ+KoQ" ARC-Seal: i=1; a=rsa-sha256; t=1777376580; cv=none; d=zohomail.com; s=zohoarc; b=M8SJNFjjWP9OohOj1L5U/Ak4kn2dAl7BnntUyIPQVcXSiq6dh5PrXHs+IznEQBpu1qnhgNWmqYC6bTb+/MFQbrtMQDXcLjUljR1Ip5c2ZnYv0fnNruJx6Av7QOwRmA8Kpy7VzqeeF3tT7CyNQ1DN/5wKi5RVbQg91U3PgYUmI/Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777376580; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=TlhFPL8ND+WbfcUGfTmCK2EdpsIx2XJ/qy/5oRg5djc=; b=Ou58zUfUJJJjh8pKc3x942+vgKqV9Y0h5klakiHiZz6f/3GSRy5N2gy7fw13Bw2aVoNkUaLU61x6rB445r3Pr8O3fQQbDWgVe+tlD8p0T2SnHTx0kXxsOV6QQoINkipA6bM73wB4V8c1CdnnTRnBCWBUn/gkeZdjWfKNL4Tui5Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1777376580; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Content-Type:Message-Id:Reply-To; bh=TlhFPL8ND+WbfcUGfTmCK2EdpsIx2XJ/qy/5oRg5djc=; b=TMxJ+KoQESywS2WFOZsDEHeSkQX7kq79HVwVINdBJMYJf54FxAXsa39Wzqi+K6n5 3W6MuK2HoCJybpJhJkYCIaH57WMAm3v66lq4RGf7x8lcRGc/++5l0NNfOZEs+GXuJtr 2SVYdt5ecKKV2ccBqWMLNtOXM9tn+SnEKgNtgA/E= Received: by mx.zohomail.com with SMTPS id 1777376578422414.75549572481907; Tue, 28 Apr 2026 04:42:58 -0700 (PDT) From: Nicolas Frattaroli To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org Cc: Christian Hewitt , Diederik de Haas , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Jonas Karlman Subject: Re: [PATCH v3 11/13] drm: bridge: dw_hdmi: Extract dw_hdmi_connector_status_update() Date: Tue, 28 Apr 2026 13:42:52 +0200 Message-ID: In-Reply-To: <20260403185303.80748-12-jonas@kwiboo.se> References: <20260403185303.80748-1-jonas@kwiboo.se> <20260403185303.80748-12-jonas@kwiboo.se> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" On Friday, 3 April 2026 20:52:57 Central European Summer Time Jonas Karlman wrote: > Move connector EDID update and CEC phys addr handling to a helper > function as a preparation before moving EDID refresh from get_modes > funcs to detect/force funcs. > > Signed-off-by: Jonas Karlman > --- > v3: New patch > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 30 +++++++++++++---------- > 1 file changed, 17 insertions(+), 13 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > index 4a0498922476..0d42fdf9a386 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > @@ -2467,6 +2467,21 @@ static const struct drm_edid *dw_hdmi_edid_read(struct dw_hdmi *hdmi, > * DRM Connector Operations > */ > > +static void > +dw_hdmi_connector_status_update(struct drm_connector *connector, > + enum drm_connector_status status) > +{ > + struct dw_hdmi *hdmi = container_of(connector, struct dw_hdmi, connector); > + const struct drm_edid *drm_edid; > + > + drm_edid = dw_hdmi_edid_read(hdmi, connector); > + drm_edid_connector_update(connector, drm_edid); > + drm_edid_free(drm_edid); > + > + cec_notifier_set_phys_addr(hdmi->cec_notifier, > + connector->display_info.source_physical_address); > +} > + > static enum drm_connector_status > dw_hdmi_connector_detect(struct drm_connector *connector, bool force) > { > @@ -2484,20 +2499,9 @@ dw_hdmi_connector_detect(struct drm_connector *connector, bool force) > > static int dw_hdmi_connector_get_modes(struct drm_connector *connector) > { > - struct dw_hdmi *hdmi = container_of(connector, struct dw_hdmi, > - connector); > - const struct drm_edid *drm_edid; > - int ret; > + dw_hdmi_connector_status_update(connector, connector->status); > > - drm_edid = dw_hdmi_edid_read(hdmi, connector); > - > - drm_edid_connector_update(connector, drm_edid); > - cec_notifier_set_phys_addr(hdmi->cec_notifier, > - connector->display_info.source_physical_address); > - ret = drm_edid_connector_add_modes(connector); > - drm_edid_free(drm_edid); > - > - return ret; > + return drm_edid_connector_add_modes(connector); > } > > static int dw_hdmi_connector_atomic_check(struct drm_connector *connector, > Reviewed-by: Nicolas Frattaroli