Re: [PATCH v3 12/13] drm: bridge: dw_hdmi: Use dw_hdmi_connector_status_update()

Dmitry Baryshkov
2026-04-29T01:54:22Z

On Tue, 28 Apr 2026 at 21:53, Jonas Karlman <jonas@kwiboo.se> wrote:
>
> Hi Dmitry,
>
> On 4/28/2026 2:42 PM, Dmitry Baryshkov wrote:
> > On Fri, Apr 03, 2026 at 06:52:58PM +0000, Jonas Karlman wrote:
> >> Update connector EDID and CEC phys addr from detect and force funcs to
> >> ensure that userspace always have access to latest read EDID after a
> >> sink use a HPD low voltage pulse to indicate that EDID has changed.
> >>
> >> With EDID being updated in detect and force funcs, there should no
> >> longer be a need to re-read EDID in get_modes funcs, so drop it.
> >>
> >> This change make the dw-hdmi connector work more closely like the bridge
> >> connector does with a hdmi bridge.
> >
> > Please consider using drm_atomic_helper_connector_hdmi_update()
> > directly.
>
> It is unfortunately not possible to use that helper unless
> connector->hdmi.funcs has been assigned a value, currently something
> that is only done in drmm_connector_hdmi_init().

Ack. Looking forward to reviewing your patches.

>
> As briefly mentioned in the cover letter, I am working on converting
> dw-hdmi to be a hdmi bridge, so this function will be replaced/removed
> in a future series.
>
> See [1] for a work-in-progres snapshot where dw-hdmi use the bridge
> connector and has been converted to a hdmi bridge. This works great on
> Rockchip RK3328, RK3399 and RK3568. More testing and cleanup is needed
> before something beyond the initial HPD, CEC and EDID rework/cleanup
> currently handled in this series is ready for posing to ML.
>
> [1] https://github.com/Kwiboo/linux-rockchip/commits/next-20260427-rk-hdmi-v2/
>
> Regards,
> Jonas
>
> >
> >>
> >> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
> >> ---
> >> v3: Reworked 'Update EDID during hotplug processing' patch
> >> ---
> >> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 24 +++++++++++++----------
> >> 1 file changed, 14 insertions(+), 10 deletions(-)
> >>
> >
>

--
With best wishes
Dmitry