From: "David Schwartz" <davids@webmaster.com>
To: "Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
<schwab@suse.de>
Subject: RE: [patch 2.6.19-rc6] Stop gcc 4.1.0 optimizing wait_hpet_tick away
Date: Fri, 1 Dec 2006 06:03:26 -0800 [thread overview]
Message-ID: <MDEHLPKNGKAHNMBLJOLKCEEDABAC.davids@webmaster.com> (raw)
In-Reply-To: <jehcwflrv4.fsf@sykes.suse.de>
> "David Schwartz" <davids@webmaster.com> writes:
>
> > The problem is that '*(volatile unsigned int *)' results in a 'volatile
> > unsigned int'.
>
> No, it doesn't. Values don't have qualifiers, only objects have.
> Qualifiers on rvalues are meaningless.
Yeah. That's the problem here. The 'volatile' has no object to qualify. You
are essentially lying to the compiler (telling it the pointer points to a
volatile object when it doesn't) and hoping it does the right thing.
Nothing in the standard requires any special behavior for accesses through
volatile-qualified pointers. It only requires special behavior for access to
objects that are in fact volatile.
I think the technically right solution is some mechanism to define an object
(which can be volatile-qualified) that exists at a particular address.
Accessing this object would be accessing a volatile object and you'd get all
the things the standard promises.
An adequate solution would probably be to make 'readl' return a
volatile-qualified unsigned integer. However, I'd have no complaints if GCC
provided stronger volatile guarantees than the C standard does, assuring
that even subsequent casts or other changes still assure the access takes
place where you expect it to. Just the guarantees in the standard get you
only signals and longjmp.
It comes down to just what those guarantees GCC provides actually are.
DS
next prev parent reply other threads:[~2006-12-01 14:04 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-29 2:22 [patch 2.6.19-rc6] Stop gcc 4.1.0 optimizing wait_hpet_tick away Keith Owens
2006-11-29 3:08 ` Nicholas Miell
2006-11-29 3:56 ` Keith Owens
2006-11-29 4:04 ` David Miller
2006-11-29 4:30 ` Keith Owens
2006-11-29 4:57 ` Nicholas Miell
2006-11-30 1:04 ` David Schwartz
2006-12-01 5:50 ` Kyle Moffett
2006-12-01 11:24 ` David Schwartz
2006-12-01 12:08 ` Kyle Moffett
2006-12-01 13:52 ` David Schwartz
2006-12-02 9:02 ` Jan Engelhardt
2006-12-01 12:31 ` Andreas Schwab
2006-12-01 14:03 ` David Schwartz [this message]
2006-12-02 10:39 ` Kyle Moffett
2006-12-03 4:29 ` David Schwartz
2006-12-07 14:02 ` Kyle Moffett
2006-12-08 4:22 ` David Schwartz
2006-11-29 9:08 ` Jakub Jelinek
2006-11-29 20:14 ` Willy Tarreau
2006-12-01 5:05 ` Andrew Morton
2006-12-01 5:14 ` Keith Owens
2006-12-01 5:26 ` Willy Tarreau
2006-12-01 6:32 ` Keith Owens
2006-12-01 7:28 ` Willy Tarreau
2006-12-01 7:57 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MDEHLPKNGKAHNMBLJOLKCEEDABAC.davids@webmaster.com \
--to=davids@webmaster.com \
--cc=linux-kernel@vger.kernel.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox