The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: xtex <xtex@envs.net>
To: Bingwu Zhang <xtex@envs.net>, Gao Xiang <xiang@kernel.org>,
	Chao Yu <chao@kernel.org>, Yue Hu <zbestahu@gmail.com>,
	Jeffle Xu <jefflexu@linux.alibaba.com>,
	Sandeep Dhavale <dhavale@google.com>,
	Hongbo Li <hongbohbli@tencent.com>,
	Chunhai Guo <guochunhai@vivo.com>,
	linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	Bingwu Zhang <xtex@astrafall.org>
Subject: Re: [PATCH] erofs: remove erofs_dev_context->rwsem
Date: Sun, 16 Aug 2026 11:11:28 +0800	[thread overview]
Message-ID: <MkLn7nwBTr2E85Djml6mgQ@envs.net> (raw)
In-Reply-To: <aoEpHV2r6ye_Ff3c@XiangdeMacBook-Pro.local>

Hi,

On Sunday, August 16, 2026 11:06:05 AM China Standard Time Gao Xiang wrote:
> Hi Bingwu,
> 
> On Sun, Aug 16, 2026 at 10:00:12AM +0800, Bingwu Zhang wrote:
> > From: Bingwu Zhang <xtex@astrafall.org>
> > 
> > devs->tree is only modified in initialization and
> > destruction code paths and will never be concurrent
> > with data reading. Thus there is no need to guard
> > idr_alloc/idr_find with a rwsem.
> 
> Thanks for the patch.
> 
> In principle, yes, but it's also no problem to leave it as-is in case
> some use cases later need adjust the device_info of a dev for example
> at runtime.
> 
> Or if it causes any noticeable performance penalty, that will be one
> reason to drop it now.

Thanks for the reply. I don't think it caused any notice performance 
difference so it looks good to me to keep the rwsem.

Thanks,
Bingwu Zhang

> 
> Thanks,
> Gao Xiang
> 
> > Signed-off-by: Bingwu Zhang <xtex@astrafall.org>





      reply	other threads:[~2026-08-16  3:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-16  2:00 [PATCH] erofs: remove erofs_dev_context->rwsem Bingwu Zhang
2026-08-16  3:06 ` Gao Xiang
2026-08-16  3:11   ` xtex [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MkLn7nwBTr2E85Djml6mgQ@envs.net \
    --to=xtex@envs.net \
    --cc=chao@kernel.org \
    --cc=dhavale@google.com \
    --cc=guochunhai@vivo.com \
    --cc=hongbohbli@tencent.com \
    --cc=jefflexu@linux.alibaba.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xiang@kernel.org \
    --cc=xtex@astrafall.org \
    --cc=zbestahu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox