* [PATCH v2] ASoC: amd: yc: Fix non-functional mic on Lenovo 82YM
@ 2023-09-27 19:35 Sven Frotscher
2023-09-27 20:19 ` August Wikerfors
0 siblings, 1 reply; 2+ messages in thread
From: Sven Frotscher @ 2023-09-27 19:35 UTC (permalink / raw)
To: broonie
Cc: git, alsa-devel, lgirdwood, linux-kernel, mario.limonciello,
regressions
Like the Lenovo 82TL, 82V2, 82QF and 82UG, the 82YM (Yoga 7 14ARP8)
requires an entry in the quirk list to enable the internal microphone.
The latter two received similar fixes in commit 1263cc0f414d.
Fixes: c008323fe361 ("ASoC: amd: yc: Fix a non-functional mic on Lenovo
82SJ")
Cc: stable@vger.kernel.org
Signed-off-by: Sven Frotscher <sven.frotscher@gmail.com>
---
v1->v2 changes:
* add Fixes and Cc tags to commit message
* remove redundant LKML link from commit message
* fix mangled diff
sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/sound/soc/amd/yc/acp6x-mach.c
b/sound/soc/amd/yc/acp6x-mach.c
index 3d8a51351e29..e3d2b9d01552 100644
--- a/sound/soc/amd/yc/acp6x-mach.c
+++ b/sound/soc/amd/yc/acp6x-mach.c
@@ -241,6 +241,13 @@ static const struct dmi_system_id
yc_acp_quirk_table[] = {
DMI_MATCH(DMI_PRODUCT_NAME, "82V2"),
}
},
+ {
+ .driver_data = &acp6x_card,
+ .matches = {
+ DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "82YM"),
+ }
+ },
{
.driver_data = &acp6x_card,
.matches = {
--
2.42.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] ASoC: amd: yc: Fix non-functional mic on Lenovo 82YM
2023-09-27 19:35 [PATCH v2] ASoC: amd: yc: Fix non-functional mic on Lenovo 82YM Sven Frotscher
@ 2023-09-27 20:19 ` August Wikerfors
0 siblings, 0 replies; 2+ messages in thread
From: August Wikerfors @ 2023-09-27 20:19 UTC (permalink / raw)
To: Sven Frotscher
Cc: broonie, alsa-devel, lgirdwood, linux-kernel, mario.limonciello,
regressions
Hi Sven,
On 2023-09-27 21:35, Sven Frotscher wrote:
>
> Like the Lenovo 82TL, 82V2, 82QF and 82UG, the 82YM (Yoga 7 14ARP8)
> requires an entry in the quirk list to enable the internal microphone.
> The latter two received similar fixes in commit 1263cc0f414d.
>
> Fixes: c008323fe361 ("ASoC: amd: yc: Fix a non-functional mic on Lenovo
> 82SJ")
> Cc: stable@vger.kernel.org
> Signed-off-by: Sven Frotscher <sven.frotscher@gmail.com>
> ---
> v1->v2 changes:
> * add Fixes and Cc tags to commit message
> * remove redundant LKML link from commit message
> * fix mangled diff
>
> sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
> index 3d8a51351e29..e3d2b9d01552 100644
> --- a/sound/soc/amd/yc/acp6x-mach.c
> +++ b/sound/soc/amd/yc/acp6x-mach.c
> @@ -241,6 +241,13 @@ static const struct dmi_system_id
> yc_acp_quirk_table[] = {
> DMI_MATCH(DMI_PRODUCT_NAME, "82V2"),
> }
> },
> + {
> + .driver_data = &acp6x_card,
> + .matches = {
> + DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "82YM"),
> + }
> + },
> {
> .driver_data = &acp6x_card,
> .matches = {
This diff still doesn't look right, some of the lines are indented by
one tab too little compared to the original code. Also, the e-mail is
sent with format=flowed which git am complains about:
> warning: Patch sent with format=flowed; space at the end of lines might be lost.
> Applying: ASoC: amd: yc: Fix non-functional mic on Lenovo 82YM
> error: corrupt patch at line 15
It's better to send patches with git send-email to avoid these problems.
Regards,
August Wikerfors
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-27 20:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-27 19:35 [PATCH v2] ASoC: amd: yc: Fix non-functional mic on Lenovo 82YM Sven Frotscher
2023-09-27 20:19 ` August Wikerfors
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox