[PATCH 00/16] MIPS: some compilation fixes for the Lantiq platform

[PATCH 00/16] MIPS: some compilation fixes for the Lantiq platform

[Shiji Yang]

This patch series fixes some MIPS Lantiq platform compilation issues
found on the 6.12 kernel[1].

[1] https://github.com/openwrt/openwrt/pull/18751

Shiji Yang (16):
  MIPS: lantiq: xway: mark ltq_ar9_sys_hz() as static
  MIPS: lantiq: xway: mark dma_init() as static
  MIPS: lantiq: xway: mark dcdc_init() as static
  MIPS: lantiq: irq: fix misc missing-prototypes warnings
  MIPS: lantiq: xway: add prototype for ltq_get_cp1_base()
  MIPS: pci: lantiq: marks pcibios_init() as static
  MIPS: lantiq: falcon: fix misc missing-prototypes warnings
  MIPS: lantiq: falcon: sysctrl: remove unused falcon_trigger_hrst()
  MIPS: lantiq: falcon: sysctrl: add missing header prom.h
  MIPS: lantiq: falcon: sysctrl: fix request memory check logic
  MIPS: lantiq: xway: gptu: mark gptu_init() as static
  MIPS: vpe-mt: mark vpe_free() and vpe_stop() as static
  MIPS: vpe-mt: drop unused functions vpe_alloc() and vpe_start()
  pinctrl: xway: mark xway_pinconf_group_set() as static
  pinctrl: falcon: mark pinctrl_falcon_init() as static
  spi: falcon: mark falcon_sflash_xfer() as static

 .../include/asm/mach-lantiq/xway/lantiq_soc.h |  3 ++
 arch/mips/kernel/vpe-mt.c                     | 35 ++-----------------
 arch/mips/lantiq/falcon/prom.c                |  4 +--
 arch/mips/lantiq/falcon/sysctrl.c             | 29 ++++++---------
 arch/mips/lantiq/irq.c                        |  3 +-
 arch/mips/lantiq/xway/clk.c                   |  2 +-
 arch/mips/lantiq/xway/dcdc.c                  |  2 +-
 arch/mips/lantiq/xway/dma.c                   |  2 +-
 arch/mips/lantiq/xway/gptu.c                  |  2 +-
 arch/mips/pci/pci-lantiq.c                    |  2 +-
 drivers/pinctrl/pinctrl-falcon.c              |  2 +-
 drivers/pinctrl/pinctrl-xway.c                |  2 +-
 drivers/spi/spi-falcon.c                      |  2 +-
 13 files changed, 28 insertions(+), 62 deletions(-)

-- 
2.50.0

[PATCH 01/16] MIPS: lantiq: xway: mark ltq_ar9_sys_hz() as static

[Shiji Yang]

Fix the following missing-prototypes warning:

arch/mips/lantiq/xway/clk.c:77:15: error: no previous prototype for 'ltq_ar9_sys_hz' [-Werror=missing-prototypes]
   77 | unsigned long ltq_ar9_sys_hz(void)
      |               ^~~~~~~~~~~~~~

Signed-off-by: Shiji Yang <yangshiji66@outlook.com>
---
 arch/mips/lantiq/xway/clk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/lantiq/xway/clk.c b/arch/mips/lantiq/xway/clk.c
index 47ad21430..39fb3ecdd 100644
--- a/arch/mips/lantiq/xway/clk.c
+++ b/arch/mips/lantiq/xway/clk.c
@@ -74,7 +74,7 @@ unsigned long ltq_danube_pp32_hz(void)
 	return clk;
 }
 
-unsigned long ltq_ar9_sys_hz(void)
+static unsigned long ltq_ar9_sys_hz(void)
 {
 	if (((ltq_cgu_r32(CGU_SYS) >> 3) & 0x3) == 0x2)
 		return CLOCK_393M;
-- 
2.50.0

[PATCH 02/16] MIPS: lantiq: xway: mark dma_init() as static

[Shiji Yang]

Fix the following missing-prototypes build warning:

arch/mips/lantiq/xway/dma.c:293:1: error: no previous prototype for 'dma_init' [-Werror=missing-prototypes]
  293 | dma_init(void)
      | ^~~~~~~~

Signed-off-by: Shiji Yang <yangshiji66@outlook.com>
---
 arch/mips/lantiq/xway/dma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/lantiq/xway/dma.c b/arch/mips/lantiq/xway/dma.c
index 934ac7293..4693eba6c 100644
--- a/arch/mips/lantiq/xway/dma.c
+++ b/arch/mips/lantiq/xway/dma.c
@@ -289,7 +289,7 @@ static struct platform_driver dma_driver = {
 	},
 };
 
-int __init
+static int __init
 dma_init(void)
 {
 	return platform_driver_register(&dma_driver);
-- 
2.50.0

[PATCH 03/16] MIPS: lantiq: xway: mark dcdc_init() as static

[Shiji Yang]

Fix the following missing-prototypes build warning:

arch/mips/lantiq/xway/dcdc.c:49:12: error: no previous prototype for 'dcdc_init' [-Werror=missing-prototypes]
   49 | int __init dcdc_init(void)
      |            ^~~~~~~~~

Signed-off-by: Shiji Yang <yangshiji66@outlook.com>
---
 arch/mips/lantiq/xway/dcdc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/lantiq/xway/dcdc.c b/arch/mips/lantiq/xway/dcdc.c
index 4a808f8c5..b79c462fd 100644
--- a/arch/mips/lantiq/xway/dcdc.c
+++ b/arch/mips/lantiq/xway/dcdc.c
@@ -46,7 +46,7 @@ static struct platform_driver dcdc_driver = {
 	},
 };
 
-int __init dcdc_init(void)
+static int __init dcdc_init(void)
 {
 	int ret = platform_driver_register(&dcdc_driver);
 
-- 
2.50.0

[PATCH 04/16] MIPS: lantiq: irq: fix misc missing-prototypes warnings

[Shiji Yang]

Fix the following build warnings:

arch/mips/lantiq/irq.c:340:12: error: no previous prototype for 'icu_of_init' [-Werror=missing-prototypes]
  340 | int __init icu_of_init(struct device_node *node, struct device_node *parent)
      |            ^~~~~~~~~~~
arch/mips/lantiq/irq.c:418:5: error: no previous prototype for 'get_c0_perfcount_int' [-Werror=missing-prototypes]
  418 | int get_c0_perfcount_int(void)
      |     ^~~~~~~~~~~~~~~~~~~~
arch/mips/lantiq/irq.c:424:14: error: no previous prototype for 'get_c0_compare_int' [-Werror=missing-prototypes]
  424 | unsigned int get_c0_compare_int(void)
      |              ^~~~~~~~~~~~~~~~~~

Signed-off-by: Shiji Yang <yangshiji66@outlook.com>
---
 arch/mips/lantiq/irq.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/mips/lantiq/irq.c b/arch/mips/lantiq/irq.c
index a112573b6..961c55933 100644
--- a/arch/mips/lantiq/irq.c
+++ b/arch/mips/lantiq/irq.c
@@ -16,6 +16,7 @@
 
 #include <asm/bootinfo.h>
 #include <asm/irq_cpu.h>
+#include <asm/time.h>
 
 #include <lantiq_soc.h>
 #include <irq.h>
@@ -335,7 +336,8 @@ static const struct irq_domain_ops irq_domain_ops = {
 	.map = icu_map,
 };
 
-int __init icu_of_init(struct device_node *node, struct device_node *parent)
+static int __init
+icu_of_init(struct device_node *node, struct device_node *parent)
 {
 	struct device_node *eiu_node;
 	struct resource res;
-- 
2.50.0

[PATCH 05/16] MIPS: lantiq: xway: add prototype for ltq_get_cp1_base()

[Shiji Yang]

ltq_get_cp1_base() is an exported function, we must define
its prototype on header file. Fix warning:

arch/mips/lantiq/xway/vmmc.c:22:15: error: no previous prototype for 'ltq_get_cp1_base' [-Werror=missing-prototypes]
   22 | unsigned int *ltq_get_cp1_base(void)
      |               ^~~~~~~~~~~~~~~~

Signed-off-by: Shiji Yang <yangshiji66@outlook.com>
---
 arch/mips/include/asm/mach-lantiq/xway/lantiq_soc.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/mips/include/asm/mach-lantiq/xway/lantiq_soc.h b/arch/mips/include/asm/mach-lantiq/xway/lantiq_soc.h
index c2e0acb75..dd9f621d0 100644
--- a/arch/mips/include/asm/mach-lantiq/xway/lantiq_soc.h
+++ b/arch/mips/include/asm/mach-lantiq/xway/lantiq_soc.h
@@ -99,5 +99,8 @@ extern __iomem void *ltq_cgu_membase;
 extern void ltq_pmu_enable(unsigned int module);
 extern void ltq_pmu_disable(unsigned int module);
 
+/* VMMC */
+extern unsigned int *ltq_get_cp1_base(void);
+
 #endif /* CONFIG_SOC_TYPE_XWAY */
 #endif /* _LTQ_XWAY_H__ */
-- 
2.50.0

[PATCH 06/16] MIPS: pci: lantiq: marks pcibios_init() as static

[Shiji Yang]

Fix the following missing-prototypes build warning:

arch/mips/pci/pci-lantiq.c:239:12: error: no previous prototype for 'pcibios_init' [-Werror=missing-prototypes]
  239 | int __init pcibios_init(void)
      |            ^~~~~~~~~~~~

Signed-off-by: Shiji Yang <yangshiji66@outlook.com>
---
 arch/mips/pci/pci-lantiq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/pci/pci-lantiq.c b/arch/mips/pci/pci-lantiq.c
index 68a8cefed..0e85839b8 100644
--- a/arch/mips/pci/pci-lantiq.c
+++ b/arch/mips/pci/pci-lantiq.c
@@ -234,7 +234,7 @@ static struct platform_driver ltq_pci_driver = {
 	},
 };
 
-int __init pcibios_init(void)
+static int __init pcibios_init(void)
 {
 	int ret = platform_driver_register(&ltq_pci_driver);
 	if (ret)
-- 
2.50.0

[PATCH 07/16] MIPS: lantiq: falcon: fix misc missing-prototypes warnings

[Shiji Yang]

Fix the following build warnings:

arch/mips/lantiq/falcon/prom.c:39:13: error: no previous prototype for 'ltq_soc_nmi_setup' [-Werror=missing-prototypes]
   39 | void __init ltq_soc_nmi_setup(void)
      |             ^~~~~~~~~~~~~~~~~
arch/mips/lantiq/falcon/prom.c:46:13: error: no previous prototype for 'ltq_soc_ejtag_setup' [-Werror=missing-prototypes]
   46 | void __init ltq_soc_ejtag_setup(void)
      |             ^~~~~~~~~~~~~~~~~~~

Signed-off-by: Shiji Yang <yangshiji66@outlook.com>
---
 arch/mips/lantiq/falcon/prom.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/mips/lantiq/falcon/prom.c b/arch/mips/lantiq/falcon/prom.c
index 7b98def10..2a38c4267 100644
--- a/arch/mips/lantiq/falcon/prom.c
+++ b/arch/mips/lantiq/falcon/prom.c
@@ -36,14 +36,14 @@
 #define BOOT_NVEC	(BOOT_REG_BASE | 0x04)
 #define BOOT_EVEC	(BOOT_REG_BASE | 0x08)
 
-void __init ltq_soc_nmi_setup(void)
+static void __init ltq_soc_nmi_setup(void)
 {
 	extern void (*nmi_handler)(void);
 
 	ltq_w32((unsigned long)&nmi_handler, (void *)BOOT_NVEC);
 }
 
-void __init ltq_soc_ejtag_setup(void)
+static void __init ltq_soc_ejtag_setup(void)
 {
 	extern void (*ejtag_debug_handler)(void);
 
-- 
2.50.0

[PATCH 08/16] MIPS: lantiq: falcon: sysctrl: remove unused falcon_trigger_hrst()

[Shiji Yang]

This is a defined but unused function. Fix warning:

arch/mips/lantiq/falcon/sysctrl.c:75:6: error: no previous prototype for 'falcon_trigger_hrst' [-Werror=missing-prototypes]
   75 | void falcon_trigger_hrst(int level)
      |      ^~~~~~~~~~~~~~~~~~~

Signed-off-by: Shiji Yang <yangshiji66@outlook.com>
---
 arch/mips/lantiq/falcon/sysctrl.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/arch/mips/lantiq/falcon/sysctrl.c b/arch/mips/lantiq/falcon/sysctrl.c
index 1187729d8..c65f05115 100644
--- a/arch/mips/lantiq/falcon/sysctrl.c
+++ b/arch/mips/lantiq/falcon/sysctrl.c
@@ -72,11 +72,6 @@
 static void __iomem *sysctl_membase[3], *status_membase;
 void __iomem *ltq_sys1_membase, *ltq_ebu_membase;
 
-void falcon_trigger_hrst(int level)
-{
-	sysctl_w32(SYSCTL_SYS1, level & 1, SYS1_HRSTOUTC);
-}
-
 static inline void sysctl_wait(struct clk *clk,
 		unsigned int test, unsigned int reg)
 {
-- 
2.50.0

[PATCH 09/16] MIPS: lantiq: falcon: sysctrl: add missing header prom.h

[Shiji Yang]

"prom.h" includes the prototype of ltq_soc_init(). Fix warning:

arch/mips/lantiq/falcon/sysctrl.c:185:13: error: no previous prototype for 'ltq_soc_init' [-Werror=missing-prototypes]
  185 | void __init ltq_soc_init(void)
      |             ^~~~~~~~~~~~

Signed-off-by: Shiji Yang <yangshiji66@outlook.com>
---
 arch/mips/lantiq/falcon/sysctrl.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/mips/lantiq/falcon/sysctrl.c b/arch/mips/lantiq/falcon/sysctrl.c
index c65f05115..9a8616c36 100644
--- a/arch/mips/lantiq/falcon/sysctrl.c
+++ b/arch/mips/lantiq/falcon/sysctrl.c
@@ -14,6 +14,7 @@
 #include <lantiq_soc.h>
 
 #include "../clk.h"
+#include "../prom.h"
 
 /* infrastructure control register */
 #define SYS1_INFRAC		0x00bc
-- 
2.50.0

[PATCH 10/16] MIPS: lantiq: falcon: sysctrl: fix request memory check logic

[Shiji Yang]

request_mem_region() will return NULL instead of error code
when the memory request fails. Therefore, we should check if
the return value is non-zero instead of less than zero. In
this way, this patch also fixes the build warnings:

arch/mips/lantiq/falcon/sysctrl.c:214:50: error: ordered comparison of pointer with integer zero [-Werror=extra]
  214 |                                 res_status.name) < 0) ||
      |                                                  ^
arch/mips/lantiq/falcon/sysctrl.c:216:47: error: ordered comparison of pointer with integer zero [-Werror=extra]
  216 |                                 res_ebu.name) < 0) ||
      |                                               ^
arch/mips/lantiq/falcon/sysctrl.c:219:50: error: ordered comparison of pointer with integer zero [-Werror=extra]
  219 |                                 res_sys[0].name) < 0) ||
      |                                                  ^
arch/mips/lantiq/falcon/sysctrl.c:222:50: error: ordered comparison of pointer with integer zero [-Werror=extra]
  222 |                                 res_sys[1].name) < 0) ||
      |                                                  ^
arch/mips/lantiq/falcon/sysctrl.c:225:50: error: ordered comparison of pointer with integer zero [-Werror=extra]
  225 |                                 res_sys[2].name) < 0))
      |

Signed-off-by: Shiji Yang <yangshiji66@outlook.com>
---
 arch/mips/lantiq/falcon/sysctrl.c | 23 ++++++++++-------------
 1 file changed, 10 insertions(+), 13 deletions(-)

diff --git a/arch/mips/lantiq/falcon/sysctrl.c b/arch/mips/lantiq/falcon/sysctrl.c
index 9a8616c36..577e6e630 100644
--- a/arch/mips/lantiq/falcon/sysctrl.c
+++ b/arch/mips/lantiq/falcon/sysctrl.c
@@ -210,19 +210,16 @@ void __init ltq_soc_init(void)
 	of_node_put(np_syseth);
 	of_node_put(np_sysgpe);
 
-	if ((request_mem_region(res_status.start, resource_size(&res_status),
-				res_status.name) < 0) ||
-		(request_mem_region(res_ebu.start, resource_size(&res_ebu),
-				res_ebu.name) < 0) ||
-		(request_mem_region(res_sys[0].start,
-				resource_size(&res_sys[0]),
-				res_sys[0].name) < 0) ||
-		(request_mem_region(res_sys[1].start,
-				resource_size(&res_sys[1]),
-				res_sys[1].name) < 0) ||
-		(request_mem_region(res_sys[2].start,
-				resource_size(&res_sys[2]),
-				res_sys[2].name) < 0))
+	if ((!request_mem_region(res_status.start, resource_size(&res_status),
+				 res_status.name)) ||
+	    (!request_mem_region(res_ebu.start, resource_size(&res_ebu),
+				 res_ebu.name)) ||
+	    (!request_mem_region(res_sys[0].start, resource_size(&res_sys[0]),
+				 res_sys[0].name)) ||
+	    (!request_mem_region(res_sys[1].start, resource_size(&res_sys[1]),
+				 res_sys[1].name)) ||
+	    (!request_mem_region(res_sys[2].start, resource_size(&res_sys[2]),
+				 res_sys[2].name)))
 		pr_err("Failed to request core resources");
 
 	status_membase = ioremap(res_status.start,
-- 
2.50.0

[PATCH 11/16] MIPS: lantiq: xway: gptu: mark gptu_init() as static

[Shiji Yang]

Fix the following missing-prototypes warning:

arch/mips/lantiq/xway/gptu.c:197:12: error: no previous prototype for 'gptu_init' [-Werror=missing-prototypes]
  197 | int __init gptu_init(void)
      |            ^~~~~~~~~

Signed-off-by: Shiji Yang <yangshiji66@outlook.com>
---
 arch/mips/lantiq/xway/gptu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/lantiq/xway/gptu.c b/arch/mips/lantiq/xway/gptu.c
index 8d5200130..484c9e300 100644
--- a/arch/mips/lantiq/xway/gptu.c
+++ b/arch/mips/lantiq/xway/gptu.c
@@ -194,7 +194,7 @@ static struct platform_driver dma_driver = {
 	},
 };
 
-int __init gptu_init(void)
+static int __init gptu_init(void)
 {
 	int ret = platform_driver_register(&dma_driver);
 
-- 
2.50.0

[PATCH 12/16] MIPS: vpe-mt: mark vpe_free() and vpe_stop() as static

[Shiji Yang]

These functions are only used in the current source file "vpe-mt.c".
Do not export them and mark them as static to silence the missing
prototypes warnings:

arch/mips/kernel/vpe-mt.c:208:5: error: no previous prototype for 'vpe_stop' [-Werror=missing-prototypes]
  208 | int vpe_stop(void *vpe)
      |     ^~~~~~~~
arch/mips/kernel/vpe-mt.c:229:5: error: no previous prototype for 'vpe_free' [-Werror=missing-prototypes]
  229 | int vpe_free(void *vpe)
      |     ^~~~~~~~

Signed-off-by: Shiji Yang <yangshiji66@outlook.com>
---
 arch/mips/kernel/vpe-mt.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/mips/kernel/vpe-mt.c b/arch/mips/kernel/vpe-mt.c
index 84124ac2d..694b3bfc1 100644
--- a/arch/mips/kernel/vpe-mt.c
+++ b/arch/mips/kernel/vpe-mt.c
@@ -202,7 +202,7 @@ int vpe_start(void *vpe, unsigned long start)
 EXPORT_SYMBOL(vpe_start);
 
 /* halt it for now */
-int vpe_stop(void *vpe)
+static int vpe_stop(void *vpe)
 {
 	struct vpe *v = vpe;
 	struct tc *t;
@@ -220,10 +220,9 @@ int vpe_stop(void *vpe)
 
 	return 0;
 }
-EXPORT_SYMBOL(vpe_stop);
 
 /* I've done with it thank you */
-int vpe_free(void *vpe)
+static int vpe_free(void *vpe)
 {
 	struct vpe *v = vpe;
 	struct tc *t;
@@ -255,7 +254,6 @@ int vpe_free(void *vpe)
 
 	return 0;
 }
-EXPORT_SYMBOL(vpe_free);
 
 static ssize_t store_kill(struct device *dev, struct device_attribute *attr,
 			  const char *buf, size_t len)
-- 
2.50.0

[PATCH 13/16] MIPS: vpe-mt: drop unused functions vpe_alloc() and vpe_start()

[Shiji Yang]

These two functions are defined but unused. Removing them to silence
the missing prototypes warnings:

arch/mips/kernel/vpe-mt.c:180:7: error: no previous prototype for 'vpe_alloc' [-Werror=missing-prototypes]
  180 | void *vpe_alloc(void)
      |       ^~~~~~~~~
arch/mips/kernel/vpe-mt.c:198:5: error: no previous prototype for 'vpe_start' [-Werror=missing-prototypes]
  198 | int vpe_start(void *vpe, unsigned long start)
      |     ^~~~~~~~~

Signed-off-by: Shiji Yang <yangshiji66@outlook.com>
---
 arch/mips/kernel/vpe-mt.c | 29 -----------------------------
 1 file changed, 29 deletions(-)

diff --git a/arch/mips/kernel/vpe-mt.c b/arch/mips/kernel/vpe-mt.c
index 694b3bfc1..a6dd358bc 100644
--- a/arch/mips/kernel/vpe-mt.c
+++ b/arch/mips/kernel/vpe-mt.c
@@ -172,35 +172,6 @@ void cleanup_tc(struct tc *tc)
 	local_irq_restore(flags);
 }
 
-/* module wrapper entry points */
-/* give me a vpe */
-void *vpe_alloc(void)
-{
-	int i;
-	struct vpe *v;
-
-	/* find a vpe */
-	for (i = 1; i < MAX_VPES; i++) {
-		v = get_vpe(i);
-		if (v != NULL) {
-			v->state = VPE_STATE_INUSE;
-			return v;
-		}
-	}
-	return NULL;
-}
-EXPORT_SYMBOL(vpe_alloc);
-
-/* start running from here */
-int vpe_start(void *vpe, unsigned long start)
-{
-	struct vpe *v = vpe;
-
-	v->__start = start;
-	return vpe_run(v);
-}
-EXPORT_SYMBOL(vpe_start);
-
 /* halt it for now */
 static int vpe_stop(void *vpe)
 {
-- 
2.50.0

[PATCH 14/16] pinctrl: xway: mark xway_pinconf_group_set() as static

[Shiji Yang]

Fix the following missing-prototypes build warning:

drivers/pinctrl/pinctrl-xway.c:1231:5: error: no previous prototype for 'xway_pinconf_group_set' [-Werror=missing-prototypes]
 1231 | int xway_pinconf_group_set(struct pinctrl_dev *pctldev,
      |     ^~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Shiji Yang <yangshiji66@outlook.com>
---
 drivers/pinctrl/pinctrl-xway.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-xway.c b/drivers/pinctrl/pinctrl-xway.c
index 48f8aabf3..d2da944e9 100644
--- a/drivers/pinctrl/pinctrl-xway.c
+++ b/drivers/pinctrl/pinctrl-xway.c
@@ -1228,10 +1228,11 @@ static int xway_pinconf_set(struct pinctrl_dev *pctldev,
 	return 0;
 }
 
-int xway_pinconf_group_set(struct pinctrl_dev *pctldev,
-			unsigned selector,
-			unsigned long *configs,
-			unsigned num_configs)
+static int
+xway_pinconf_group_set(struct pinctrl_dev *pctldev,
+		       unsigned selector,
+		       unsigned long *configs,
+		       unsigned num_configs)
 {
 	struct ltq_pinmux_info *info = pinctrl_dev_get_drvdata(pctldev);
 	int i, ret = 0;
-- 
2.50.0

[PATCH 15/16] pinctrl: falcon: mark pinctrl_falcon_init() as static

[Shiji Yang]

Fix the following missing-prototypes build warning:

drivers/pinctrl/pinctrl-falcon.c:508:12: error: no previous prototype for 'pinctrl_falcon_init' [-Werror=missing-prototypes]
  508 | int __init pinctrl_falcon_init(void)
      |            ^~~~~~~~~~~~~~~~~~~

Signed-off-by: Shiji Yang <yangshiji66@outlook.com>
---
 drivers/pinctrl/pinctrl-falcon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-falcon.c b/drivers/pinctrl/pinctrl-falcon.c
index 0bf9ffbcc..100eed175 100644
--- a/drivers/pinctrl/pinctrl-falcon.c
+++ b/drivers/pinctrl/pinctrl-falcon.c
@@ -505,7 +505,7 @@ static struct platform_driver pinctrl_falcon_driver = {
 	},
 };
 
-int __init pinctrl_falcon_init(void)
+static int __init pinctrl_falcon_init(void)
 {
 	return platform_driver_register(&pinctrl_falcon_driver);
 }
-- 
2.50.0

[PATCH 16/16] spi: falcon: mark falcon_sflash_xfer() as static

[Shiji Yang]

Fix the following missing-prototypes build warning:

drivers/spi/spi-falcon.c:97:5: error: no previous prototype for 'falcon_sflash_xfer' [-Werror=missing-prototypes]
   97 | int falcon_sflash_xfer(struct spi_device *spi, struct spi_transfer *t,
      |     ^~~~~~~~~~~~~~~~~~

Signed-off-by: Shiji Yang <yangshiji66@outlook.com>
---
 drivers/spi/spi-falcon.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-falcon.c b/drivers/spi/spi-falcon.c
index 84279058f..faa893f83 100644
--- a/drivers/spi/spi-falcon.c
+++ b/drivers/spi/spi-falcon.c
@@ -94,8 +94,9 @@ struct falcon_sflash {
 	struct spi_controller *host;
 };
 
-int falcon_sflash_xfer(struct spi_device *spi, struct spi_transfer *t,
-		unsigned long flags)
+static int
+falcon_sflash_xfer(struct spi_device *spi, struct spi_transfer *t,
+		   unsigned long flags)
 {
 	struct device *dev = &spi->dev;
 	struct falcon_sflash *priv = spi_controller_get_devdata(spi->controller);
-- 
2.50.0

Re: [PATCH 16/16] spi: falcon: mark falcon_sflash_xfer() as static

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 714 bytes --]

On Wed, Jun 18, 2025 at 10:53:29PM +0800, Shiji Yang wrote:
> Fix the following missing-prototypes build warning:
> 
> drivers/spi/spi-falcon.c:97:5: error: no previous prototype for 'falcon_sflash_xfer' [-Werror=missing-prototypes]
>    97 | int falcon_sflash_xfer(struct spi_device *spi, struct spi_transfer *t,
>       |     ^~~~~~~~~~~~~~~~~~
> 
> Signed-off-by: Shiji Yang <yangshiji66@outlook.com>

I believe there's no actual dependency on the rest of the series?  In
general it is better not to mix patches for different subsystems in a
single series unless there's some interaction between them, it just
means people get more mail and makes it a bit less clear how things
should be applied.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: (subset) [PATCH 00/16] MIPS: some compilation fixes for the Lantiq platform

[Mark Brown]

On Wed, 18 Jun 2025 22:53:13 +0800, Shiji Yang wrote:
> This patch series fixes some MIPS Lantiq platform compilation issues
> found on the 6.12 kernel[1].
> 
> [1] https://github.com/openwrt/openwrt/pull/18751
> 
> Shiji Yang (16):
>   MIPS: lantiq: xway: mark ltq_ar9_sys_hz() as static
>   MIPS: lantiq: xway: mark dma_init() as static
>   MIPS: lantiq: xway: mark dcdc_init() as static
>   MIPS: lantiq: irq: fix misc missing-prototypes warnings
>   MIPS: lantiq: xway: add prototype for ltq_get_cp1_base()
>   MIPS: pci: lantiq: marks pcibios_init() as static
>   MIPS: lantiq: falcon: fix misc missing-prototypes warnings
>   MIPS: lantiq: falcon: sysctrl: remove unused falcon_trigger_hrst()
>   MIPS: lantiq: falcon: sysctrl: add missing header prom.h
>   MIPS: lantiq: falcon: sysctrl: fix request memory check logic
>   MIPS: lantiq: xway: gptu: mark gptu_init() as static
>   MIPS: vpe-mt: mark vpe_free() and vpe_stop() as static
>   MIPS: vpe-mt: drop unused functions vpe_alloc() and vpe_start()
>   pinctrl: xway: mark xway_pinconf_group_set() as static
>   pinctrl: falcon: mark pinctrl_falcon_init() as static
>   spi: falcon: mark falcon_sflash_xfer() as static
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[16/16] spi: falcon: mark falcon_sflash_xfer() as static
        commit: 5fc2c383125c2b4b6037e02ad8796b776b25e6d0

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

Re: [PATCH 00/16] MIPS: some compilation fixes for the Lantiq platform

[Linus Walleij]

On Wed, Jun 18, 2025 at 4:54 PM Shiji Yang <yangshiji66@outlook.com> wrote:

> This patch series fixes some MIPS Lantiq platform compilation issues
> found on the 6.12 kernel[1].

Thanks!

(...)
>   pinctrl: xway: mark xway_pinconf_group_set() as static

I already got a similar patch from Bartosz.

>   pinctrl: falcon: mark pinctrl_falcon_init() as static

Patch applied!

Yours,
Linus Walleij

Re: [PATCH 12/16] MIPS: vpe-mt: mark vpe_free() and vpe_stop() as static

[Thomas Bogendoerfer]

On Wed, Jun 18, 2025 at 10:53:25PM +0800, Shiji Yang wrote:
> These functions are only used in the current source file "vpe-mt.c".
> Do not export them and mark them as static to silence the missing
> prototypes warnings:

you are breaking the whole idea of this interface, The functions are
exported for other kernel modules. By removing it you break them.

If we know that this interface is unsued, we should remove the
whole kernel module, but I don't know if it used somewhere.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

Re: [PATCH 00/16] MIPS: some compilation fixes for the Lantiq platform

[Thomas Bogendoerfer]

On Wed, Jun 18, 2025 at 10:53:13PM +0800, Shiji Yang wrote:
> This patch series fixes some MIPS Lantiq platform compilation issues
> found on the 6.12 kernel[1].
> 
> [1] https://github.com/openwrt/openwrt/pull/18751
> 
> Shiji Yang (16):
>   MIPS: lantiq: xway: mark ltq_ar9_sys_hz() as static
>   MIPS: lantiq: xway: mark dma_init() as static
>   MIPS: lantiq: xway: mark dcdc_init() as static
>   MIPS: lantiq: irq: fix misc missing-prototypes warnings
>   MIPS: lantiq: xway: add prototype for ltq_get_cp1_base()
>   MIPS: pci: lantiq: marks pcibios_init() as static
>   MIPS: lantiq: falcon: fix misc missing-prototypes warnings
>   MIPS: lantiq: falcon: sysctrl: remove unused falcon_trigger_hrst()
>   MIPS: lantiq: falcon: sysctrl: add missing header prom.h
>   MIPS: lantiq: falcon: sysctrl: fix request memory check logic
>   MIPS: lantiq: xway: gptu: mark gptu_init() as static
>   MIPS: vpe-mt: mark vpe_free() and vpe_stop() as static
>   MIPS: vpe-mt: drop unused functions vpe_alloc() and vpe_start()
>   pinctrl: xway: mark xway_pinconf_group_set() as static
>   pinctrl: falcon: mark pinctrl_falcon_init() as static
>   spi: falcon: mark falcon_sflash_xfer() as static
> 
>  .../include/asm/mach-lantiq/xway/lantiq_soc.h |  3 ++
>  arch/mips/kernel/vpe-mt.c                     | 35 ++-----------------
>  arch/mips/lantiq/falcon/prom.c                |  4 +--
>  arch/mips/lantiq/falcon/sysctrl.c             | 29 ++++++---------
>  arch/mips/lantiq/irq.c                        |  3 +-
>  arch/mips/lantiq/xway/clk.c                   |  2 +-
>  arch/mips/lantiq/xway/dcdc.c                  |  2 +-
>  arch/mips/lantiq/xway/dma.c                   |  2 +-
>  arch/mips/lantiq/xway/gptu.c                  |  2 +-
>  arch/mips/pci/pci-lantiq.c                    |  2 +-
>  drivers/pinctrl/pinctrl-falcon.c              |  2 +-
>  drivers/pinctrl/pinctrl-xway.c                |  2 +-
>  drivers/spi/spi-falcon.c                      |  2 +-
>  13 files changed, 28 insertions(+), 62 deletions(-)

applied patches 1-11 to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

Re: [PATCH 12/16] MIPS: vpe-mt: mark vpe_free() and vpe_stop() as static

[Shiji Yang]

On  Wed, 2 Jul 2025 14:06:28 +0200, Thomas Bogendoerfer wrote:

> On Wed, Jun 18, 2025 at 10:53:25PM +0800, Shiji Yang wrote:
> > These functions are only used in the current source file "vpe-mt.c".
> > Do not export them and mark them as static to silence the missing
> > prototypes warnings:
> 
> you are breaking the whole idea of this interface, The functions are
> exported for other kernel modules. By removing it you break them.
> 
> If we know that this interface is unsued, we should remove the
> whole kernel module, but I don't know if it used somewhere.
> 
> Thomas.

Thank you for your review. It seems that MIPS/Lantiq platform still
rely on the vpe-mt module. I've sent another patch to fix these
vpe-mt compilation warnings. Suppress patches 12 and 13:

https://lore.kernel.org/linux-mips/OSBPR01MB16706BF0ABF807E870C79A86BC43A@OSBPR01MB1670.jpnprd01.prod.outlook.com/

Regards,
Shiji Yang