linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] MIPS: ralink: some build fixes
@ 2025-06-18 15:40 Shiji Yang
  2025-06-18 15:40 ` [PATCH 1/2] MIPS: ralink: add missing header include Shiji Yang
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Shiji Yang @ 2025-06-18 15:40 UTC (permalink / raw)
  To: linux-mips
  Cc: Thomas Bogendoerfer, John Crispin, Sergio Paracuellos,
	Mieczyslaw Nalewaj, linux-kernel, Shiji Yang

This patch series fixes some MIPS Ralink platform compilation issues
founded on the OpenWrt distribution 6.12 kernel[1].

[1] https://github.com/openwrt/openwrt/pull/18654

Mieczyslaw Nalewaj (2):
  MIPS: ralink: add missing header include
  MIPS: pci-rt2880: make pcibios_init() static

 arch/mips/pci/pci-rt2880.c | 2 +-
 arch/mips/ralink/irq.c     | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

-- 
2.50.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/2] MIPS: ralink: add missing header include
  2025-06-18 15:40 [PATCH 0/2] MIPS: ralink: some build fixes Shiji Yang
@ 2025-06-18 15:40 ` Shiji Yang
  2025-06-18 15:40 ` [PATCH 2/2] MIPS: pci-rt2880: make pcibios_init() static Shiji Yang
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Shiji Yang @ 2025-06-18 15:40 UTC (permalink / raw)
  To: linux-mips
  Cc: Thomas Bogendoerfer, John Crispin, Sergio Paracuellos,
	Mieczyslaw Nalewaj, linux-kernel, Shiji Yang

From: Mieczyslaw Nalewaj <namiltd@yahoo.com>

Add the missing header "asm/time.h" which defines the function
prototypes of get_c0_perfcount_int() and get_c0_compare_int().
This patch fixes the following build warnings:

arch/mips/ralink/irq.c:86:5: error: no previous prototype for 'get_c0_perfcount_int' [-Werror=missing-prototypes]
   86 | int get_c0_perfcount_int(void)
      |     ^~~~~~~~~~~~~~~~~~~~
arch/mips/ralink/irq.c:92:14: error: no previous prototype for 'get_c0_compare_int' [-Werror=missing-prototypes]
   92 | unsigned int get_c0_compare_int(void)
      |              ^~~~~~~~~~~~~~~~~~

Signed-off-by: Mieczyslaw Nalewaj <namiltd@yahoo.com>
Signed-off-by: Shiji Yang <yangshiji66@outlook.com>
---
 arch/mips/ralink/irq.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/mips/ralink/irq.c b/arch/mips/ralink/irq.c
index af5bbbea9..955b36e89 100644
--- a/arch/mips/ralink/irq.c
+++ b/arch/mips/ralink/irq.c
@@ -15,6 +15,7 @@
 
 #include <asm/irq_cpu.h>
 #include <asm/mipsregs.h>
+#include <asm/time.h>
 
 #include "common.h"
 
-- 
2.50.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] MIPS: pci-rt2880: make pcibios_init() static
  2025-06-18 15:40 [PATCH 0/2] MIPS: ralink: some build fixes Shiji Yang
  2025-06-18 15:40 ` [PATCH 1/2] MIPS: ralink: add missing header include Shiji Yang
@ 2025-06-18 15:40 ` Shiji Yang
  2025-06-19  4:00 ` [PATCH 0/2] MIPS: ralink: some build fixes Sergio Paracuellos
  2025-07-02 12:02 ` Thomas Bogendoerfer
  3 siblings, 0 replies; 5+ messages in thread
From: Shiji Yang @ 2025-06-18 15:40 UTC (permalink / raw)
  To: linux-mips
  Cc: Thomas Bogendoerfer, John Crispin, Sergio Paracuellos,
	Mieczyslaw Nalewaj, linux-kernel, Shiji Yang

From: Mieczyslaw Nalewaj <namiltd@yahoo.com>

This function is only used in the current source file. Mark it as
static to fix the compilation error:

arch/mips/pci/pci-rt2880.c:267:12: error: no previous prototype for 'pcibios_init' [-Werror=missing-prototypes]
  267 | int __init pcibios_init(void)
      |            ^~~~~~~~~~~~

Signed-off-by: Mieczyslaw Nalewaj <namiltd@yahoo.com>
Signed-off-by: Shiji Yang <yangshiji66@outlook.com>
---
 arch/mips/pci/pci-rt2880.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/pci/pci-rt2880.c b/arch/mips/pci/pci-rt2880.c
index 1cada09fa..006e2bbab 100644
--- a/arch/mips/pci/pci-rt2880.c
+++ b/arch/mips/pci/pci-rt2880.c
@@ -264,7 +264,7 @@ static struct platform_driver rt288x_pci_driver = {
 	},
 };
 
-int __init pcibios_init(void)
+static int __init pcibios_init(void)
 {
 	int ret = platform_driver_register(&rt288x_pci_driver);
 
-- 
2.50.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/2] MIPS: ralink: some build fixes
  2025-06-18 15:40 [PATCH 0/2] MIPS: ralink: some build fixes Shiji Yang
  2025-06-18 15:40 ` [PATCH 1/2] MIPS: ralink: add missing header include Shiji Yang
  2025-06-18 15:40 ` [PATCH 2/2] MIPS: pci-rt2880: make pcibios_init() static Shiji Yang
@ 2025-06-19  4:00 ` Sergio Paracuellos
  2025-07-02 12:02 ` Thomas Bogendoerfer
  3 siblings, 0 replies; 5+ messages in thread
From: Sergio Paracuellos @ 2025-06-19  4:00 UTC (permalink / raw)
  To: Shiji Yang
  Cc: linux-mips, Thomas Bogendoerfer, John Crispin, Mieczyslaw Nalewaj,
	linux-kernel

On Wed, Jun 18, 2025 at 5:40 PM Shiji Yang <yangshiji66@outlook.com> wrote:
>
> This patch series fixes some MIPS Ralink platform compilation issues
> founded on the OpenWrt distribution 6.12 kernel[1].
>
> [1] https://github.com/openwrt/openwrt/pull/18654
>
> Mieczyslaw Nalewaj (2):
>   MIPS: ralink: add missing header include
>   MIPS: pci-rt2880: make pcibios_init() static
>
>  arch/mips/pci/pci-rt2880.c | 2 +-
>  arch/mips/ralink/irq.c     | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/2] MIPS: ralink: some build fixes
  2025-06-18 15:40 [PATCH 0/2] MIPS: ralink: some build fixes Shiji Yang
                   ` (2 preceding siblings ...)
  2025-06-19  4:00 ` [PATCH 0/2] MIPS: ralink: some build fixes Sergio Paracuellos
@ 2025-07-02 12:02 ` Thomas Bogendoerfer
  3 siblings, 0 replies; 5+ messages in thread
From: Thomas Bogendoerfer @ 2025-07-02 12:02 UTC (permalink / raw)
  To: Shiji Yang
  Cc: linux-mips, John Crispin, Sergio Paracuellos, Mieczyslaw Nalewaj,
	linux-kernel

On Wed, Jun 18, 2025 at 11:40:24PM +0800, Shiji Yang wrote:
> This patch series fixes some MIPS Ralink platform compilation issues
> founded on the OpenWrt distribution 6.12 kernel[1].
> 
> [1] https://github.com/openwrt/openwrt/pull/18654
> 
> Mieczyslaw Nalewaj (2):
>   MIPS: ralink: add missing header include
>   MIPS: pci-rt2880: make pcibios_init() static
> 
>  arch/mips/pci/pci-rt2880.c | 2 +-
>  arch/mips/ralink/irq.c     | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)

series applied to mips-next

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2025-07-02 13:19 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-18 15:40 [PATCH 0/2] MIPS: ralink: some build fixes Shiji Yang
2025-06-18 15:40 ` [PATCH 1/2] MIPS: ralink: add missing header include Shiji Yang
2025-06-18 15:40 ` [PATCH 2/2] MIPS: pci-rt2880: make pcibios_init() static Shiji Yang
2025-06-19  4:00 ` [PATCH 0/2] MIPS: ralink: some build fixes Sergio Paracuellos
2025-07-02 12:02 ` Thomas Bogendoerfer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).