From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D00523D34AA for ; Tue, 28 Apr 2026 11:53:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777377230; cv=pass; b=GVJPyRo3vTAHKHgcvJ1iLZIzvyGSfM5MphqiyysTOK1P5VcTLOjY4UIltX8K/Cm6Hnt6UYEPkskGKzB883IMKu/t30jjFLfALSGx4wFPstAIHgrxsEbGGewFtgCzhvpjp+PbUXhNHeJvyEgOKVDgz8XfVEXdIM5UjNIZRxwsetU= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777377230; c=relaxed/simple; bh=CXabOrnjHXGfZMEOtoQCBv/kGAE+mgixZWtd2/zwDOA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=gGSsSyA1Moa+A5ejKENnRtdDVjLfWL9Bakwv7/jxjb8KkReY4dH+mbVDB7L1CD0wyTUrWGP+nXjYiIiPx8WtAVOjd/gJYmlL6zUi0Gahu94zCfGYWeZKdyDHGWuG2M5rJg6lZucvFsI3BVISJoqf/EmekdEl4cpfwqFl7yP+VDg= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=UxXEr3ag; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="UxXEr3ag" ARC-Seal: i=1; a=rsa-sha256; t=1777377195; cv=none; d=zohomail.com; s=zohoarc; b=E5GFnmQ+w9FJtR5uk5OjEOOIZcsRYIKwqhQ/iWwxEzH9Oem0OU9VvEWzXYCgtYkhH/XMLdrbVFtnqGTirvvCeV1SF2gTdvBr/OMhKYZMSCVC1S1VWwjmQ/aU3KXl13M9lhmD3C3kL/y2k/Tdp9ucZcJNpewTNvj6JlFL8QFu6A0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777377195; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=GNY2Rj/fNIB+sQInt5TTNsgyPXJLAGIuY5+XWaQw4IE=; b=D1EYSXDLCCXY5UPmObFxa0KPnIMDzVW3nyWp1gj4EZSYypP5NXZWP2yxi5u0oY8xDz7OlMCIZrXYcvblAYJDDmOdV+f/QVJgdrzS+erKChWBQeMJnFtsk/HSQdzGA6/y7/iismtyQoHkbbJ2thO3MDUpIbLi2lTTKSOJtl0OM1o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1777377195; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Content-Type:Message-Id:Reply-To; bh=GNY2Rj/fNIB+sQInt5TTNsgyPXJLAGIuY5+XWaQw4IE=; b=UxXEr3agy8MOZCIQeXrdI2htGzgYzphYyck4Sy/YjB3SDATWmd84GhR4P0vPDzz5 st93qStXhh7ZjztYZma8LVxmfcuvwwMlNglbnlK3mqKvpDt77lszxjpoY0t4L0X+Ymg uawqOwzcoUmwWzRK59y/RQCZ12KAZ9m8mE9bC/j4= Received: by mx.zohomail.com with SMTPS id 1777377193741544.8805847787758; Tue, 28 Apr 2026 04:53:13 -0700 (PDT) From: Nicolas Frattaroli To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org Cc: Christian Hewitt , Diederik de Haas , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Jonas Karlman Subject: Re: [PATCH v3 12/13] drm: bridge: dw_hdmi: Use dw_hdmi_connector_status_update() Date: Tue, 28 Apr 2026 13:53:08 +0200 Message-ID: In-Reply-To: <20260403185303.80748-13-jonas@kwiboo.se> References: <20260403185303.80748-1-jonas@kwiboo.se> <20260403185303.80748-13-jonas@kwiboo.se> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" On Friday, 3 April 2026 20:52:58 Central European Summer Time Jonas Karlman wrote: > Update connector EDID and CEC phys addr from detect and force funcs to > ensure that userspace always have access to latest read EDID after a > sink use a HPD low voltage pulse to indicate that EDID has changed. > > With EDID being updated in detect and force funcs, there should no > longer be a need to re-read EDID in get_modes funcs, so drop it. > > This change make the dw-hdmi connector work more closely like the bridge > connector does with a hdmi bridge. > > Signed-off-by: Jonas Karlman > --- > v3: Reworked 'Update EDID during hotplug processing' patch > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 24 +++++++++++++---------- > 1 file changed, 14 insertions(+), 10 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > index 0d42fdf9a386..5b5654ef6015 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > @@ -2474,33 +2474,36 @@ dw_hdmi_connector_status_update(struct drm_connector *connector, > struct dw_hdmi *hdmi = container_of(connector, struct dw_hdmi, connector); > const struct drm_edid *drm_edid; > > + if (status == connector_status_disconnected) { > + drm_edid_connector_update(connector, NULL); > + cec_notifier_phys_addr_invalidate(hdmi->cec_notifier); > + return; > + } > + > drm_edid = dw_hdmi_edid_read(hdmi, connector); > drm_edid_connector_update(connector, drm_edid); > drm_edid_free(drm_edid); > > - cec_notifier_set_phys_addr(hdmi->cec_notifier, > - connector->display_info.source_physical_address); > + if (status == connector_status_connected) > + cec_notifier_set_phys_addr(hdmi->cec_notifier, > + connector->display_info.source_physical_address); > } > > static enum drm_connector_status > dw_hdmi_connector_detect(struct drm_connector *connector, bool force) > { > - struct dw_hdmi *hdmi = container_of(connector, struct dw_hdmi, > - connector); > + struct dw_hdmi *hdmi = container_of(connector, struct dw_hdmi, connector); > enum drm_connector_status status; > > status = dw_hdmi_detect(hdmi); > > - if (status == connector_status_disconnected) > - cec_notifier_phys_addr_invalidate(hdmi->cec_notifier); > + dw_hdmi_connector_status_update(connector, status); > > return status; > } > > static int dw_hdmi_connector_get_modes(struct drm_connector *connector) > { > - dw_hdmi_connector_status_update(connector, connector->status); > - > return drm_edid_connector_add_modes(connector); > } Are we absolutely sure status_update is called before this, so that the EDID doesn't need to be re-read? E.g. drm_connector_helper_get_modes does do an EDID read beforehand. Speaking of which: if we had connector->ddc set, we could just use drm_connector_helper_get_modes for this callback. But maybe it's not worth spending the time refactoring the resource handling around hdmi->ddc when the eventual goal is to refactor this all into using a bridge connector anyway. > > @@ -2530,14 +2533,15 @@ static int dw_hdmi_connector_atomic_check(struct drm_connector *connector, > > static void dw_hdmi_connector_force(struct drm_connector *connector) > { > - struct dw_hdmi *hdmi = container_of(connector, struct dw_hdmi, > - connector); > + struct dw_hdmi *hdmi = container_of(connector, struct dw_hdmi, connector); > > mutex_lock(&hdmi->mutex); > hdmi->force = connector->force; > hdmi->last_connector_result = connector->status; > dw_hdmi_update_phy_mask(hdmi); > mutex_unlock(&hdmi->mutex); > + > + dw_hdmi_connector_status_update(connector, connector->status); > } > > static const struct drm_connector_funcs dw_hdmi_connector_funcs = { >