From: Paul Cercueil <paul@crapouillou.net>
To: daniel@ffwll.ch
Cc: David Airlie <airlied@linux.ie>,
od@zcrc.me, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 0/2] Small cleanups to ingenic-drm driver
Date: Wed, 29 Jul 2020 02:28:01 +0200 [thread overview]
Message-ID: <PYF7EQ.CC652MXUV2R41@crapouillou.net> (raw)
In-Reply-To: <20200728220008.GI6419@phenom.ffwll.local>
Le mer. 29 juil. 2020 à 0:00, daniel@ffwll.ch a écrit :
> On Tue, Jul 28, 2020 at 10:17:36PM +0200, Sam Ravnborg wrote:
>> Hi Paul.
>>
>> On Tue, Jul 28, 2020 at 05:16:39PM +0200, Paul Cercueil wrote:
>> > Here are a few cleanups to the ingenic-drm driver.
>> > - some error paths were missing and have been added;
>> > - the mode validation has been moved to the .mode_valid helper
>> callback.
>> >
>> > Cheers,
>> > -Paul
>> >
>> > Paul Cercueil (2):
>> > drm/ingenic: Handle errors of drm_atomic_get_plane_state
>> > drm/ingenic: Validate mode in a .mode_valid callback
>>
>> Both looks fine, you can add my:
>> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
>>
>> I assume you will apply the patches.
>> Maybe wait for Daniel to take a look, he had some feedback on where
>> to add checks. I assume this is covered by the second patch.
>
> Yeah changelog for new versions would be great, but aside from that
> bickering patch 2 lgtm now.
This patchset is V1, I'm fixing issues you saw in the ingenic-drm
driver when reviewing a different patchset.
Thanks for the review, I'll apply now.
-Paul
>
next prev parent reply other threads:[~2020-07-29 0:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 15:16 [PATCH 0/2] Small cleanups to ingenic-drm driver Paul Cercueil
2020-07-28 15:16 ` [PATCH 1/2] drm/ingenic: Handle errors of drm_atomic_get_plane_state Paul Cercueil
2020-07-28 15:16 ` [PATCH 2/2] drm/ingenic: Validate mode in a .mode_valid callback Paul Cercueil
2020-07-28 20:17 ` [PATCH 0/2] Small cleanups to ingenic-drm driver Sam Ravnborg
2020-07-28 22:00 ` daniel
2020-07-29 0:28 ` Paul Cercueil [this message]
2020-07-31 9:11 ` daniel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PYF7EQ.CC652MXUV2R41@crapouillou.net \
--to=paul@crapouillou.net \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=od@zcrc.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox