From: Roman Zippel <zippel@linux-m68k.org>
To: Andreas Fester <Andreas.Fester@gmx.de>
Cc: linux-kernel@vger.kernel.org, Linus Torvalds <torvalds@osdl.org>
Subject: Re: [2.6 PATCH] persist qconf options
Date: Tue, 10 Feb 2004 01:35:50 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.58.0402100050230.7851@serv> (raw)
In-Reply-To: <4028075E.1070809@gmx.de>
Hi,
On Mon, 9 Feb 2004, Andreas Fester wrote:
> @@ -1145,6 +1162,10 @@
> menuList->updateListAll();
> }
>
> +bool ConfigMainWindow::getShowAll() {
> + return configList->showAll;
> +}
> +
> void ConfigMainWindow::setShowDebug(bool b)
> {
> if (showDebug == b)
All these access functions are really not neccessary.
If we change this I'd like to see this done properly. First all the
settings business should be moved into a small helper class, so that there
are not x number of new arguments to the ConfigList constructor. The
saving of the settings should be connected to aboutToQuit().
Bonus points if you also save the list mode and the position of the
splitter. :)
bye, Roman
next prev parent reply other threads:[~2004-02-10 1:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-09 22:19 [2.6 PATCH] persist qconf options Andreas Fester
2004-02-09 22:19 ` Randy.Dunlap
2004-02-10 0:35 ` Roman Zippel [this message]
2004-02-10 7:33 ` Andreas Fester
2004-02-10 18:57 ` Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0402100050230.7851@serv \
--to=zippel@linux-m68k.org \
--cc=Andreas.Fester@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox