From: Hugh Dickins <hugh@veritas.com>
To: Kirill Korotaev <dev@sw.ru>
Cc: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm acct accounting fix
Date: Wed, 11 May 2005 17:08:56 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.61.0505111701110.7331@goblin.wat.veritas.com> (raw)
In-Reply-To: <428223E0.2070200@sw.ru>
On Wed, 11 May 2005, Kirill Korotaev wrote:
> Sorry, forgot to write that all these patches are against 2.6.12-rc4...
>
> This patch fixes mm->total_vm and mm->locked_vm acctounting in case
> when move_page_tables() fails inside move_vma().
>
> Signed-Off-By: Kirill Korotaev <dev@sw.ru>
>
> --- ./mm/mremap.c.mmacct 2005-05-10 16:10:40.000000000 +0400
> +++ ./mm/mremap.c 2005-05-10 18:12:13.000000000 +0400
> @@ -213,6 +213,7 @@ static unsigned long move_vma(struct vm_
> old_len = new_len;
> old_addr = new_addr;
> new_addr = -ENOMEM;
> + new_len = 0;
> }
>
> /* Conceal VM_ACCOUNT so old reservation is not undone */
Are you sure?
The way it's supposed to work is that the do_munmap(,,old_len) which
follows, which normally unmaps the area moved from, when unsuccessful
unmaps the area moved to: which will "mistakenly" decrement total_vm etc.
by old_len, which needs to be bumped back up by that amount before leaving.
Hugh
next prev parent reply other threads:[~2005-05-11 16:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-11 15:25 [PATCH] mm acct accounting fix Kirill Korotaev
2005-05-11 16:08 ` Hugh Dickins [this message]
2005-05-12 8:00 ` Kirill Korotaev
2005-05-12 18:25 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.61.0505111701110.7331@goblin.wat.veritas.com \
--to=hugh@veritas.com \
--cc=akpm@osdl.org \
--cc=dev@sw.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox