public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Hugh Dickins <hugh@veritas.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Mark Fasheh <mark.fasheh@oracle.com>, linux-kernel@vger.kernel.org
Subject: [PATCH -rc2-mm2] update tmpfs for new delete_inode behavior
Date: Tue, 12 Jul 2005 15:22:11 +0100 (BST)	[thread overview]
Message-ID: <Pine.LNX.4.61.0507121508520.6933@goblin.wat.veritas.com> (raw)

LTP on tmpfs hits kernel BUG at mm/shmem.c:680!  shmem_delete_inode needs
to truncate_inode_pages for itself now.  It's not immediately obvious since
many cases get covered by shmem_truncate's followup truncate_inode_pages:
maybe with thought we can just call it once, but right now fix the BUG.

Signed-off-by: Hugh Dickins <hugh@veritas.com>

--- 2.6.13-rc2-mm2/mm/shmem.c	2005-07-06 11:23:52.000000000 +0100
+++ linux/mm/shmem.c	2005-07-12 13:58:26.000000000 +0100
@@ -668,6 +668,7 @@ static void shmem_delete_inode(struct in
 	struct shmem_inode_info *info = SHMEM_I(inode);
 
 	if (inode->i_op->truncate == shmem_truncate) {
+		truncate_inode_pages(inode->i_mapping, 0);
 		shmem_unacct_size(info->flags, inode->i_size);
 		inode->i_size = 0;
 		shmem_truncate(inode);

             reply	other threads:[~2005-07-12 14:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-12 14:22 Hugh Dickins [this message]
2005-07-12 20:52 ` [PATCH -rc2-mm2] update tmpfs for new delete_inode behavior Mark Fasheh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.61.0507121508520.6933@goblin.wat.veritas.com \
    --to=hugh@veritas.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.fasheh@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox