From: Esben Nielsen <nielsen.esben@googlemail.com>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>
Subject: [patch 5/5] [PREEMPT_RT] Changing interrupt handlers from running in thread to hardirq and back runtime.
Date: Fri, 2 Jun 2006 23:23:52 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0606022322230.9307@localhost> (raw)
In-Reply-To: 20060602165336.147812000@localhost
Make lpptest more compliant with the request_irq() interface. I don't think
the driver should set or remove flags on it's own!
Index: linux-2.6.16-rt23.spin_mutex/drivers/char/lpptest.c
===================================================================
--- linux-2.6.16-rt23.spin_mutex.orig/drivers/char/lpptest.c
+++ linux-2.6.16-rt23.spin_mutex/drivers/char/lpptest.c
@@ -150,13 +150,13 @@ static int __init lpptest_init (void)
return -EAGAIN;
}
- if (request_irq (LPPTEST_IRQ, lpptest_irq, 0, "lpptest", dev_id)) {
- printk (KERN_WARNING "lpptest: irq %d in use. Unload parport module!\n", LPPTEST_IRQ);
+ if (request_irq (LPPTEST_IRQ, lpptest_irq, SA_NODELAY | SA_INTERRUPT,
+ "lpptest", dev_id)) {
+ printk (KERN_WARNING "lpptest: irq %d in use. "
+ "Unload parport module!\n", LPPTEST_IRQ);
unregister_chrdev(LPPTEST_CHAR_MAJOR, LPPTEST_DEVICE_NAME);
return -EAGAIN;
}
- irq_desc[LPPTEST_IRQ].status |= IRQ_NODELAY;
- irq_desc[LPPTEST_IRQ].action->flags |= SA_NODELAY | SA_INTERRUPT;
INIT_PORT();
ENABLE_IRQ();
--
prev parent reply other threads:[~2006-06-02 21:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060602165336.147812000@localhost>
2006-06-02 22:23 ` [patch 1/5] [PREEMPT_RT] Changing interrupt handlers from running in thread to hardirq and back runtime Esben Nielsen
2006-06-02 22:23 ` [patch 2/5] " Esben Nielsen
2006-06-03 20:21 ` Steven Rostedt
2006-06-04 17:33 ` Esben Nielsen
2006-06-02 22:23 ` [patch 3/5] " Esben Nielsen
2006-06-03 20:39 ` Steven Rostedt
2006-06-04 17:34 ` Esben Nielsen
2006-06-02 22:23 ` [patch 4/5] " Esben Nielsen
2006-06-03 21:30 ` Steven Rostedt
2006-06-04 22:50 ` Esben Nielsen
2006-06-02 22:23 ` Esben Nielsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0606022322230.9307@localhost \
--to=nielsen.esben@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox