The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Robert P. J. Day" <rpjday@mindspring.com>
To: Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: [PATCH] MPT:  make all Fusion MPT sub-choices singly selectable
Date: Sat, 25 Nov 2006 06:34:55 -0500 (EST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0611250627200.20370@localhost.localdomain> (raw)


  Put all of the Fusion MPT sub-choices under a single top-level
config entry.

Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>

---

  Is there any reason that the sub-choices for Fusion MPT can't be
selected or deselected en masse, the way it's done for, say, MTD
support and other components?

  There are other locations where this simplification could be used
but I thought I'd wait for some feedback on this example first.

diff --git a/drivers/message/fusion/Kconfig b/drivers/message/fusion/Kconfig
index ea31d84..a4f0097 100644
--- a/drivers/message/fusion/Kconfig
+++ b/drivers/message/fusion/Kconfig
@@ -2,13 +2,12 @@
 menu "Fusion MPT device support"

 config FUSION
-	bool
+	bool "Fusion MPT device support"
 	default n

 config FUSION_SPI
 	tristate "Fusion MPT ScsiHost drivers for SPI"
-	depends on PCI && SCSI
-	select FUSION
+	depends on FUSION && PCI && SCSI
 	select SCSI_SPI_ATTRS
 	---help---
 	  SCSI HOST support for a parallel SCSI host adapters.
@@ -22,8 +21,7 @@ config FUSION_SPI

 config FUSION_FC
 	tristate "Fusion MPT ScsiHost drivers for FC"
-	depends on PCI && SCSI
-	select FUSION
+	depends on FUSION && PCI && SCSI
 	select SCSI_FC_ATTRS
 	---help---
 	  SCSI HOST support for a Fiber Channel host adapters.
@@ -39,8 +37,7 @@ config FUSION_FC

 config FUSION_SAS
 	tristate "Fusion MPT ScsiHost drivers for SAS"
-	depends on PCI && SCSI
- 	select FUSION
+	depends on FUSION && PCI && SCSI
 	select SCSI_SAS_ATTRS
 	---help---
 	  SCSI HOST support for a SAS host adapters.



             reply	other threads:[~2006-11-25 11:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-25 11:34 Robert P. J. Day [this message]
2006-11-25 20:12 ` [PATCH] MPT: make all Fusion MPT sub-choices singly selectable Randy Dunlap
2006-11-25 20:54   ` Robert P. J. Day
2006-11-25 21:44     ` Randy Dunlap
2006-11-25 21:22   ` Robert P. J. Day

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0611250627200.20370@localhost.localdomain \
    --to=rpjday@mindspring.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox