Re: retry [PATCH] partition : add support for sysv68 partitions

[Geert Uytterhoeven <geert@linux-m68k.org>]

On Wed, 9 May 2007, Philippe De Muyter wrote:
> On Tue, May 08, 2007 at 10:21:12PM +0200, Geert Uytterhoeven wrote:
> > On Fri, 13 Apr 2007, Philippe De Muyter wrote:
> > > Add support for the Motorola sysv68 disk partition table (slices in motorola
> > > doc).
> > > 
> > > Signed-off-by: Philippe De Muyter <phdm@macqel.be>
> > > 
> > > diff -r 1b54f1d81bc5 fs/partitions/Kconfig
> > > --- a/fs/partitions/Kconfig	Thu Apr 12 15:44:52 2007 -0700
> > > +++ b/fs/partitions/Kconfig	Fri Apr 13 15:51:58 2007 +0200
> > > @@ -236,3 +236,12 @@ config EFI_PARTITION
> > >  	help
> > >  	  Say Y here if you would like to use hard disks under Linux which
> > >  	  were partitioned using EFI GPT.
> > > +
> > > +config SYSV68_PARTITION
> > > +	bool "SYSV68 partition table support" if PARTITION_ADVANCED
> > > +	default y if M68K
> >         ^^^^^^^^^^^^^^^^^
> > > +	help
> > > +	  Say Y here if you would like to be able to read the hard disk
> > > +	  partition table format used by Motorola Delta machines (using
> > > +	  sysv68).
> > > +	  Otherwise, say N.
> > 
> > Bummer, I saw your patch before, but I never noticed the `default y if M68K'.
> > 
> > Can you please tell me on which platforms SYSV68 partition tables are commonly
> > used (I guess the Motorola MVME boards?), so we can enable it by default on a
> 
> The Motorola VME boards are the only ones I am aware of.  I must also add
> that the partitions themselves are sysv partitions.
> 
> > more sensible subset of M68K?
> 
> Feel free to replace or suppress the `default' directive.  I actually wrote
> that for a i586 laptop to access/reinstall disks of sysV68 machines using
> a USB/SCSI adapter, but I don't think `default y' is a good idea :).
> 
> What do you think of
> 	`default y if VME'
> or
> 	`default y if M68K && SYSV_FS'

I prefer `default y if VME'.

BTW, perhaps PPC based Motorola MVME boards use SYSV68 partition tables,
too?

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds