From: "Robert P. J. Day" <rpjday@mindspring.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] Make asm-generic/ioctl.h more generic using conditionals.
Date: Fri, 13 Jul 2007 05:58:30 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0707130557070.6531@localhost.localdomain> (raw)
In-Reply-To: <20070713095620.GD16304@infradead.org>
On Fri, 13 Jul 2007, Christoph Hellwig wrote:
> On Tue, Jul 10, 2007 at 06:33:26AM -0400, Robert P. J. Day wrote:
> > + * Let any architecture override either of the following before
> > + * including this file.
> > + */
> > +
> > +#ifndef _IOC_SIZEBITS
> > +# define _IOC_SIZEBITS 14
> > +#endif
> > +
> > +#ifndef _IOC_DIRBITS
> > +# define _IOC_DIRBITS 2
> > +#endif
>
> I don't think this is usefull. It just makes it less obvious to
> find this definition which must not change ever due to abi reasons
> anyway.
huh?
alpha:
#define _IOC_SIZEBITS 13
#define _IOC_DIRBITS 3
mips:
#define _IOC_SIZEBITS 13
#define _IOC_DIRBITS 3
powerpc:
#define _IOC_SIZEBITS 13
#define _IOC_DIRBITS 3
rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================
prev parent reply other threads:[~2007-07-13 10:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-10 10:33 [PATCH] Make asm-generic/ioctl.h more generic using conditionals Robert P. J. Day
2007-07-12 23:11 ` Andrew Morton
2007-07-13 0:51 ` Robert P. J. Day
2007-07-13 9:56 ` Christoph Hellwig
2007-07-13 9:58 ` Robert P. J. Day [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0707130557070.6531@localhost.localdomain \
--to=rpjday@mindspring.com \
--cc=akpm@osdl.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox