From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A110C77B60 for ; Sat, 29 Apr 2023 22:40:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230323AbjD2Wgt (ORCPT ); Sat, 29 Apr 2023 18:36:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229489AbjD2Wgr (ORCPT ); Sat, 29 Apr 2023 18:36:47 -0400 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1B68183 for ; Sat, 29 Apr 2023 15:36:46 -0700 (PDT) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 1A9055C00E4; Sat, 29 Apr 2023 18:36:46 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sat, 29 Apr 2023 18:36:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ljones.dev; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1682807806; x=1682894206; bh=HA yiyUR/zUDCPBYNGZPvHnuHWV4W2fCgiDxxlkg0pCk=; b=qIreNi0nj/LPd1crU1 A80YflKA8/aPp5DdIlvGdC4yvHDUlxzpI9aDAA6+Q6BYZCgvNS26IopJ02tJpvIg El6DV6oEedYDT/A5wDlri8d2t7A7/YYzHvOXENNI1Z+7D4vikb519F5/EMSWaZre Aqvd/r/5gfyQVq/xVEhJ+9QP9DIyvI0EuSCe/me0/denGoPY9AmG+8g+M/UKzdpU RwzshAeZIROUC5eDcTTuuOLGrWltygXnzKmd8knpocCd7mANeBtbMWUZYa+6ti8+ 51sXPe0hvyTj6B2UP5ERAycaDmkn7reNVx3iRrtFwHhDk7YYgXQk3Te40PCv5T0t knnw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1682807806; x=1682894206; bh=HAyiyUR/zUDCP BYNGZPvHnuHWV4W2fCgiDxxlkg0pCk=; b=H5savcPa8R1F97KMHiIm+J4cyEBWz 3hygslyvZdiccoHGPW6lhr5JugTxJOjcm6Zb9Cuq989U6hOgX1EwJTdDBt5QB3+a gCxKNyKSCHSLXVz0azwGtanWmmYFLh6PxKMmKACu1vBChu5KWLRLZNOCmRYQ3Hwb iSo4jZeFS/WqIhJXm6dMkngWdnEBJ6qhPUvz31u4G+nR/iaY5UmKT5abixd6xwxy xT5EZnsuim3iAV0/h9a5DIivG1/DLkpdRpMc6x+YPtIAs5IlUKM1JuGUnRn047Hk 8Uddjk25zz+AlurkAHRy7uhCn0Ycl0erBMeYHmkWNrWL9cqoUr/URiZFg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfedvuddgtdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffuvfevkfgjfhfogggtsehttd ertdertddvnecuhfhrohhmpefnuhhkvgculfhonhgvshcuoehluhhkvgeslhhjohhnvghs rdguvghvqeenucggtffrrghtthgvrhhnpedvvdegledtheefieejgfevgeefiefhtdevte efteduhfevtdefleethfetgeeludenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgr mhepmhgrihhlfhhrohhmpehluhhkvgeslhhjohhnvghsrdguvghv X-ME-Proxy: Feedback-ID: i5ec1447f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 29 Apr 2023 18:36:43 -0400 (EDT) Date: Sun, 30 Apr 2023 10:36:27 +1200 From: Luke Jones Subject: Re: [PATCH] drivers: fix keyboard not working under some laptops To: hqp1203hqp@163.com Cc: linux-kernel@vger.kernel.org Message-Id: In-Reply-To: References: X-Mailer: geary/43.0 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Additionally the patch isn't generated correctly. In your main git of Linux kernel where the last commit is your patch do `git format-patch HEAD^` You should then end up with 0001-drivers-fix-keyboard-not-working-under-some-laptops.patch On Sun, Apr 30 2023 at 10:32:03 +1200, Luke Jones wrote: > Hi, > > Because this is a quirk sepcific to the FA507NV: > > > + .matches = { > > + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), > > + DMI_MATCH(DMI_BOARD_NAME, "FA507NV"), > > + }, > > perhaps the patch title should be renamed to reflect that? > > I have a user with the same issue, I will confirm it fixes the > problem. >