From: "Luck, Tony" <tony.luck@intel.com>
To: "Zhuo, Qiuxu" <qiuxu.zhuo@intel.com>, "bp@alien8.de" <bp@alien8.de>
Cc: "james.morse@arm.com" <james.morse@arm.com>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"marmarek@invisiblethingslab.com"
<marmarek@invisiblethingslab.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"rric@kernel.org" <rric@kernel.org>
Subject: RE: [PATCH v2 1/2] EDAC/igen6: Fix NULL pointer dereference
Date: Wed, 18 Jun 2025 17:46:23 +0000 [thread overview]
Message-ID: <SJ1PR11MB6083A3234879FED2522B0148FC72A@SJ1PR11MB6083.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20250618162307.1523736-1-qiuxu.zhuo@intel.com>
> This issue occurred because one memory controller was disabled by
> the BIOS but the igen6_edac driver still checked all the memory
> controllers, including this absent one, to identify the source of
> the error. Accessing the null MMIO for the absent memory controller
> resulted in the oops above.
>
> Fix this issue by reverting the configuration structure to non-const
> and updating the field 'res_cfg->num_imc' to reflect the number of
> detected memory controllers.
>
> Fixes: 20e190b1c1fd ("EDAC/igen6: Skip absent memory controllers")
> Reported-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
> Closes: https://lore.kernel.org/all/aFFN7RlXkaK_loQb@mail-itl/
> Suggested-by: Borislav Petkov <bp@alien8.de>
> Tested-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
> Signed-off-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
Applied (both this and patch 2/2) to RAS edac-drivers branch.
Thanks
-Tony
prev parent reply other threads:[~2025-06-18 17:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-17 11:13 NULL pointer dereference in igen6_probe - 6.16-rc2 Marek Marczykowski-Górecki
2025-06-17 11:57 ` Borislav Petkov
2025-06-17 14:09 ` Zhuo, Qiuxu
2025-06-17 14:51 ` Borislav Petkov
2025-06-17 16:16 ` Zhuo, Qiuxu
2025-06-17 18:20 ` Borislav Petkov
2025-06-18 3:18 ` [PATCH 1/1] EDAC/igen6: Fix NULL pointer dereference Qiuxu Zhuo
2025-06-18 3:26 ` Zhuo, Qiuxu
2025-06-18 13:23 ` marmarek
2025-06-18 13:39 ` Zhuo, Qiuxu
2025-06-18 15:06 ` Luck, Tony
2025-06-18 15:42 ` Zhuo, Qiuxu
2025-06-18 16:23 ` [PATCH v2 1/2] " Qiuxu Zhuo
2025-06-18 16:23 ` [PATCH v2 2/2] EDAC/igen6: Reduce log level to debug for absent memory controllers Qiuxu Zhuo
2025-06-18 17:46 ` Luck, Tony [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ1PR11MB6083A3234879FED2522B0148FC72A@SJ1PR11MB6083.namprd11.prod.outlook.com \
--to=tony.luck@intel.com \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marmarek@invisiblethingslab.com \
--cc=mchehab@kernel.org \
--cc=qiuxu.zhuo@intel.com \
--cc=rric@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).