linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Luck, Tony" <tony.luck@intel.com>
To: Qinyun Tan <qinyuntan@linux.alibaba.com>
Cc: "H . Peter Anvin" <hpa@zytor.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"x86@kernel.org" <x86@kernel.org>,
	"Chatre, Reinette" <reinette.chatre@intel.com>
Subject: RE: [PATCH V2 1/1] x86/resctrl: Remove unappropriate references to cacheinfo in the resctrl subsystem.
Date: Thu, 29 May 2025 18:14:24 +0000	[thread overview]
Message-ID: <SJ1PR11MB6083BEDD3F7625B52E677647FC66A@SJ1PR11MB6083.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20250529031650.63880-2-qinyuntan@linux.alibaba.com>

> To resolve these issues:
>
> 1. Replace direct cacheinfo references in struct rdt_mon_domain and struct
> rmid_read with the cacheinfo ID (a unique identifier for the L3 cache).
>
> 2. The hdr.cpu_mask maintained by resctrl constitutes a subset of
> shared_cpu_map. When reading top-level events, we dynamically select a CPU
> from hdr.cpu_mask and utilize its corresponding shared_cpu_map for resctrl
> to determine valid CPUs for reading RMID counter via the MSR interface.
>
> Fixes: 328ea68874642 ("x86/resctrl: Prepare for new Sub-NUMA Cluster (SNC) monitor files")
> Signed-off-by: Qinyun Tan <qinyuntan@linux.alibaba.com>

Took this patch on a test run on a 2 socket Granite Rapids system configured
in SNC 3 mode.

While monitoring total memory bandwidth I took the first CPU on NUMA
nodes {1..5} offline. Monitoring kept working. Brought those back online.
Still OK. Took all CPUs on NUMA node 4 offline. Still good. Brought those
CPUs back online. Still good.

Tested-by: Tony Luck <tony.luck@intel.com>

-Tony

  parent reply	other threads:[~2025-05-29 18:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-29  3:16 [PATCH V2 0/1] x86/resctrl: Remove unappropriate references to cacheinfo in the resctrl subsystem Qinyun Tan
2025-05-29  3:16 ` [PATCH V2 1/1] " Qinyun Tan
2025-05-29 17:37   ` Reinette Chatre
2025-05-30  2:03     ` qinyuntan
2025-05-29 18:14   ` Luck, Tony [this message]
2025-05-30  1:42     ` qinyuntan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SJ1PR11MB6083BEDD3F7625B52E677647FC66A@SJ1PR11MB6083.namprd11.prod.outlook.com \
    --to=tony.luck@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=qinyuntan@linux.alibaba.com \
    --cc=reinette.chatre@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).