RE: [PATCH v3 9/9] arm64: dts: freescale: imx95: Add video codec node

[Nas Chung <nas.chung@chipsnmedia.com>]

Hi, Krzysztof.

>-----Original Message-----
>From: Krzysztof Kozlowski <krzk@kernel.org>
>Sent: Friday, August 29, 2025 11:08 PM
>To: Nas Chung <nas.chung@chipsnmedia.com>; mchehab@kernel.org;
>hverkuil@xs4all.nl; robh@kernel.org; krzk+dt@kernel.org;
>conor+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de
>Cc: linux-media@vger.kernel.org; devicetree@vger.kernel.org; linux-
>kernel@vger.kernel.org; linux-imx@nxp.com; linux-arm-
>kernel@lists.infradead.org; jackson.lee <jackson.lee@chipsnmedia.com>;
>lafley.kim <lafley.kim@chipsnmedia.com>
>Subject: Re: [PATCH v3 9/9] arm64: dts: freescale: imx95: Add video codec
>node
>
>On 29/08/2025 10:46, Nas Chung wrote:
>> diff --git a/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
>b/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
>> index 2f949a0d48d2..c9d8b78d5768 100644
>> --- a/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
>> +++ b/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
>> @@ -75,6 +75,11 @@ linux_cma: linux,cma {
>>  			linux,cma-default;
>>  			reusable;
>>  		};
>> +
>> +		vpu_boot: vpu_boot@a0000000 {
>
>Follow DTS coding style.

Okay, I will change the node name to "memory", e.g.:

		vpu_boot: memory@a0000000 {

>
>> +			reg = <0 0xa0000000 0 0x100000>;
>> +			no-map;
>> +		};
>>  	};
>>
>>  	flexcan1_phy: can-phy0 {
>> @@ -1044,3 +1049,8 @@ &tpm6 {
>>  	pinctrl-0 = <&pinctrl_tpm6>;
>>  	status = "okay";
>>  };
>> +
>> +&vpu {
>> +	memory-region = <&vpu_boot>;
>> +	sram = <&sram1>;
>> +};
>> diff --git a/arch/arm64/boot/dts/freescale/imx95-phycore-fpsc.dtsi
>b/arch/arm64/boot/dts/freescale/imx95-phycore-fpsc.dtsi
>> index 7519d5bd06ba..73c84ab60dfd 100644
>> --- a/arch/arm64/boot/dts/freescale/imx95-phycore-fpsc.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/imx95-phycore-fpsc.dtsi
>> @@ -59,6 +59,11 @@ linux,cma {
>>  			size = <0 0x3c000000>;
>>  			linux,cma-default;
>>  		};
>> +
>> +		vpu_boot: vpu_boot@a0000000 {
>
>Same problem.

I will fix it in the same way.

Thanks,
Nas.

>
>> +			reg = <0 0xa0000000 0 0x100000>;
>> +			no-map;
>> +		};
>>  	};
>
>> +
>Best regards,
>Krzysztof