From: Val Packett <val@packett.cool>
To: "Adrián Larumbe" <adrian.larumbe@collabora.com>
Cc: "Boris Brezillon" <boris.brezillon@collabora.com>,
"Rob Herring" <robh@kernel.org>,
"Steven Price" <steven.price@arm.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Christian König" <christian.koenig@amd.com>,
"Dmitry Osipenko" <dmitry.osipenko@collabora.com>,
"Zack Rusin" <zack.rusin@broadcom.com>,
kernel@collabora.com, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linaro-mm-sig@lists.linaro.org
Subject: Re: [PATCH v4 2/3] drm/lima: Fix dma_resv deadlock at drm object pin time
Date: Sun, 26 May 2024 05:27:29 -0300 [thread overview]
Message-ID: <TH33ES.VQFJ1AUXO5N81@packett.cool> (raw)
In-Reply-To: <20240523113236.432585-3-adrian.larumbe@collabora.com>
On Thu, May 23 2024 at 12:32:18 +01:00:00, Adrián Larumbe
<adrian.larumbe@collabora.com> wrote:
> Commit a78027847226 ("drm/gem: Acquire reservation lock in
> drm_gem_{pin/unpin}()") moved locking the DRM object's dma
> reservation to
> drm_gem_pin(), but Lima's pin callback kept calling drm_gem_shmem_pin,
> which also tries to lock the same dma_resv, leading to a double lock
> situation.
>
> As was already done for Panfrost in the previous commit, fix it by
> replacing drm_gem_shmem_pin() with its locked variant.
Hi, just found this while dealing with compositor lockups upon
launching a GL client on an old Rockchip RK3066 tablet, and it did fix
the problem :) Thank you.
Tested-by: Val Packett <val@packett.cool>
next prev parent reply other threads:[~2024-05-26 8:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-23 11:32 [PATCH v4 0/3] drm: Fix dma_resv deadlock at drm object pin time Adrián Larumbe
2024-05-23 11:32 ` [PATCH v4 1/3] drm/panfrost: " Adrián Larumbe
2024-05-23 12:13 ` Boris Brezillon
2024-05-23 11:32 ` [PATCH v4 2/3] drm/lima: " Adrián Larumbe
2024-05-23 12:13 ` Boris Brezillon
2024-05-26 8:27 ` Val Packett [this message]
2024-05-23 11:32 ` [PATCH v4 3/3] drm/gem-shmem: Add import attachment warning to locked pin function Adrián Larumbe
2024-05-23 12:13 ` Boris Brezillon
2024-05-29 7:32 ` [PATCH v4 0/3] drm: Fix dma_resv deadlock at drm object pin time Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TH33ES.VQFJ1AUXO5N81@packett.cool \
--to=val@packett.cool \
--cc=adrian.larumbe@collabora.com \
--cc=airlied@gmail.com \
--cc=boris.brezillon@collabora.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dmitry.osipenko@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@collabora.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
--cc=steven.price@arm.com \
--cc=sumit.semwal@linaro.org \
--cc=tzimmermann@suse.de \
--cc=zack.rusin@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox