From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3237C48BD1 for ; Thu, 10 Jun 2021 13:06:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A2A80613F5 for ; Thu, 10 Jun 2021 13:06:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230445AbhFJNIC convert rfc822-to-8bit (ORCPT ); Thu, 10 Jun 2021 09:08:02 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:37495 "EHLO relay10.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230130AbhFJNIA (ORCPT ); Thu, 10 Jun 2021 09:08:00 -0400 Received: (Authenticated sender: paul@opendingux.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 1F445240008; Thu, 10 Jun 2021 13:06:00 +0000 (UTC) Date: Thu, 10 Jun 2021 14:05:53 +0100 From: Paul Cercueil Subject: Re: [PATCH 1/2] iio: core: Support removing extended name in attribute filename To: Andy Shevchenko Cc: Jonathan Cameron , Lars-Peter Clausen , Michael Hennerich , linux-iio , Linux Kernel Mailing List Message-Id: In-Reply-To: References: <20210610124556.34507-1-paul@crapouillou.net> <20210610124556.34507-2-paul@crapouillou.net> X-Mailer: geary/40.0 MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andy, Le jeu., juin 10 2021 at 15:58:51 +0300, Andy Shevchenko a écrit : > On Thu, Jun 10, 2021 at 3:47 PM Paul Cercueil > wrote: >> >> By default, when a channel has an extended name, it will appear in >> the >> filename of channel attributes. E.g. if the extended name is "aux", >> the >> filename of a "sample_rate" attribute will be something like: >> in_voltage0_aux_sample_rate >> >> Add a mechanism to disable this feature. This will be used to add a >> "extended_name" channel attribute. > > I'm afraid, NAK. Otherwise, please put an explanation that clearly > shows that it will be no ABI breakage. > I.o.w. users for the existing drivers and devices will always get > those attributes at the same platform configuration(s). Well, the commit message says that I'm adding a mechanism to disable the feature. If it was actually doing anything else (like actually disabling it for any attribute) then I'd mention it in the commit message. I don't see how that possibly can be a ABI breakage. -Paul