From: Paul Cercueil <paul@crapouillou.net>
To: Simon Ser <contact@emersion.fr>
Cc: Maxime Ripard <maxime@cerno.tech>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
od@zcrc.me, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] drm: DON'T require each CRTC to have a unique primary plane
Date: Mon, 29 Mar 2021 16:32:17 +0100 [thread overview]
Message-ID: <TTLQQQ.OCR65URAWJVQ2@crapouillou.net> (raw)
In-Reply-To: <BoDZUOZSsZmHjkYkjHPb18dMl_t_U8ldrh8jZezjkA6a2O-IBkPGaER4wxZ2KlqRYuXlWM8xZwPnvweWEAATzoX-yuBJnBzjGKD3oXNfh5Y=@emersion.fr>
Hi Simon,
Le lun. 29 mars 2021 à 14:11, Simon Ser <contact@emersion.fr> a écrit
:
> On Monday, March 29th, 2021 at 4:07 PM, Maxime Ripard
> <maxime@cerno.tech> wrote:
>
>> Since it looks like you have two mutually exclusive planes, just
>> expose
>> one and be done with it?
>
> You can expose the other as an overlay. Clever user-space will be able
> to figure out that the more advanced plane can be used if the primary
> plane is disabled.
>
> But yeah, I don't think exposing two primary planes makes sense. The
> "primary" bit is just there for legacy user-space, it's a hint that
> it's the best plane to light up for fullscreen content. It has no
> other
> significance than that, and in particular it doesn't mean that it's
> incompatible with other primary planes.
Yes, from what I understood when writing the driver, there is not much
of a difference with primary vs. overlay planes when dealing with the
atomic DRM API, which I used exclusively.
Making the second plane an overlay would break the ABI, which is never
something I'm happy to do; but I'd prefer to do it now than later.
I still have concerns about the user-space being "clever" enough to
know it can disable the primary plane. Can e.g. wlroots handle that?
Cheers,
-Paul
next prev parent reply other threads:[~2021-03-29 15:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-27 11:22 [PATCH] drm: DON'T require each CRTC to have a unique primary plane Paul Cercueil
2021-03-27 11:24 ` Simon Ser
2021-03-27 11:26 ` Paul Cercueil
2021-03-29 8:15 ` Pekka Paalanen
2021-03-29 11:41 ` Paul Cercueil
2021-03-29 14:35 ` Pekka Paalanen
2021-03-29 15:21 ` Paul Cercueil
2021-03-29 14:07 ` Maxime Ripard
2021-03-29 14:11 ` Simon Ser
2021-03-29 15:32 ` Paul Cercueil [this message]
2021-03-29 15:36 ` Simon Ser
2021-03-30 6:55 ` Pekka Paalanen
2021-03-29 15:15 ` Paul Cercueil
2021-03-29 15:35 ` Maxime Ripard
2021-03-29 15:39 ` Paul Cercueil
2021-03-29 15:42 ` Simon Ser
2021-03-29 16:15 ` Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TTLQQQ.OCR65URAWJVQ2@crapouillou.net \
--to=paul@crapouillou.net \
--cc=airlied@linux.ie \
--cc=contact@emersion.fr \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxime@cerno.tech \
--cc=od@zcrc.me \
--cc=stable@vger.kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox