From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3A4AC433DB for ; Sun, 24 Jan 2021 08:37:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8669E22CB9 for ; Sun, 24 Jan 2021 08:37:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726524AbhAXIhi convert rfc822-to-8bit (ORCPT ); Sun, 24 Jan 2021 03:37:38 -0500 Received: from aposti.net ([89.234.176.197]:43088 "EHLO aposti.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726102AbhAXIh1 (ORCPT ); Sun, 24 Jan 2021 03:37:27 -0500 Date: Sun, 24 Jan 2021 08:36:29 +0000 From: Paul Cercueil Subject: Re: [PATCH] PHY: Ingenic: compile phy-ingenic-usb only if it was enabled To: Qiujun Huang Cc: kishon@ti.com, vkoul@kernel.org, zhouyanjie@wanyeetech.com, aric.pzqi@ingenic.com, linux-kernel@vger.kernel.org Message-Id: In-Reply-To: <20210123150146.11208-1-hqjagain@gmail.com> References: <20210123150146.11208-1-hqjagain@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, thank you for your patch. Le sam. 23 janv. 2021 à 23:01, Qiujun Huang a écrit : > We should compile this driver only if we opened PHY_INGENIC_USB. 'opened' -> 'enable'. > Signed-off-by: Qiujun Huang You will need to add a Fixes: tag and Cc linux-stable, since the problem is already in 5.10. Cheers, -Paul > --- > drivers/phy/ingenic/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/ingenic/Makefile > b/drivers/phy/ingenic/Makefile > index 65d5ea00fc9d..a00306651423 100644 > --- a/drivers/phy/ingenic/Makefile > +++ b/drivers/phy/ingenic/Makefile > @@ -1,2 +1,2 @@ > # SPDX-License-Identifier: GPL-2.0 > -obj-y += phy-ingenic-usb.o > +obj-$(PHY_INGENIC_USB) += phy-ingenic-usb.o > -- > 2.25.1 >