From: Chin-Ting Kuo <chin-ting_kuo@aspeedtech.com>
To: Guenter Roeck <linux@roeck-us.net>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
Patrick Williams <patrick@stwcx.xyz>,
"wim@linux-watchdog.org" <wim@linux-watchdog.org>
Cc: "joel@jms.id.au" <joel@jms.id.au>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"Peter.Yin@quantatw.com" <Peter.Yin@quantatw.com>,
"Patrick_NC_Lin@wiwynn.com" <Patrick_NC_Lin@wiwynn.com>,
"Bonnie_Lo@wiwynn.com" <Bonnie_Lo@wiwynn.com>,
"DELPHINE_CHIU@wiwynn.com" <DELPHINE_CHIU@wiwynn.com>,
BMC-SW <BMC-SW@aspeedtech.com>,
"chnguyen@amperecomputing.com" <chnguyen@amperecomputing.com>
Subject: RE: [PATCH v4 1/3] watchdog: aspeed: Update bootstatus handling
Date: Mon, 18 Nov 2024 12:46:43 +0000 [thread overview]
Message-ID: <TYZPR06MB52039DB39B62E6FA5220103AB2272@TYZPR06MB5203.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <9a1e64ef-81d9-48b0-b871-ce4ff792eae4@roeck-us.net>
Hi Guenter,
Thanks for the reply.
> -----Original Message-----
> From: Guenter Roeck <groeck7@gmail.com> On Behalf Of Guenter Roeck
> Sent: Friday, November 8, 2024 10:08 PM
> Subject: Re: [PATCH v4 1/3] watchdog: aspeed: Update bootstatus handling
>
> On 11/7/24 21:42, Chin-Ting Kuo wrote:
>
> > But now, I think it will be better to add a patch for creating a new
> > reset reason, e.g., WDIOF_REBOOT or WDIOF_RESTART, in watchdog.h of
> > uapi. Can I include this change, creating a new reset reason, in this
> > patch series? Or, should I create an extra new patch series for this
> > purpose?
> >
>
> This is a UAPI change. That is a major change. It needs to be discussed
> separately, on its own, and can not be sneaked in like this.
>
Agree. However, how to trigger this discussion? Can I just send a new
patch separately with only this UAPI modification? This is the first time
I change such common source code.
> Guenter
Chin-Ting
next prev parent reply other threads:[~2024-11-18 12:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 12:11 [PATCH v4 0/3] Update ASPEED WDT bootstatus Chin-Ting Kuo
2024-11-01 12:11 ` [PATCH v4 1/3] watchdog: aspeed: Update bootstatus handling Chin-Ting Kuo
2024-11-01 18:21 ` Patrick Williams
2024-11-04 0:01 ` Andrew Jeffery
2024-11-07 5:35 ` Chin-Ting Kuo
2024-11-07 23:49 ` Andrew Jeffery
2024-11-08 5:42 ` Chin-Ting Kuo
2024-11-08 14:07 ` Guenter Roeck
2024-11-18 12:46 ` Chin-Ting Kuo [this message]
2024-11-18 20:50 ` Guenter Roeck
2024-11-18 23:00 ` Andrew Jeffery
2024-11-19 1:27 ` Guenter Roeck
2024-11-20 4:54 ` Andrew Jeffery
2024-12-17 2:15 ` Chin-Ting Kuo
2024-11-07 5:34 ` Chin-Ting Kuo
2024-11-01 22:16 ` Guenter Roeck
2024-11-07 5:35 ` Chin-Ting Kuo
2024-11-01 12:12 ` [PATCH v4 2/3] watchdog: aspeed: Change aspeed_wdt_config struct name to aspeed_wdt_data Chin-Ting Kuo
2024-11-01 22:19 ` Guenter Roeck
2024-11-01 12:12 ` [PATCH v4 3/3] watchdog: aspeed: Update restart implementations Chin-Ting Kuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYZPR06MB52039DB39B62E6FA5220103AB2272@TYZPR06MB5203.apcprd06.prod.outlook.com \
--to=chin-ting_kuo@aspeedtech.com \
--cc=BMC-SW@aspeedtech.com \
--cc=Bonnie_Lo@wiwynn.com \
--cc=DELPHINE_CHIU@wiwynn.com \
--cc=Patrick_NC_Lin@wiwynn.com \
--cc=Peter.Yin@quantatw.com \
--cc=andrew@codeconstruct.com.au \
--cc=chnguyen@amperecomputing.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=patrick@stwcx.xyz \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox