public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andries.Brouwer@cwi.nl
To: jgarzik@mandrakesoft.com, linux-kernel@vger.kernel.org
Subject: rtl8139too in 2.4.5
Date: Sat, 2 Jun 2001 14:30:59 +0200 (MET DST)	[thread overview]
Message-ID: <UTC200106021230.OAA182199.aeb@vlet.cwi.nl> (raw)

My RTL8139 (Identified 8139 chip type 'RTL-8139A')
was fine in 2.4.3 and doesnt work in 2.4.5.
Copying the 2.4.3 version of 8139too.c makes things work again.

Since lots of people complained about this, I have not tried to
debug - maybe a fixed version already exists?

One remark:
2.4.5 says "eth1: media is unconnected, link down, or incompatible connection"
coming from 8139too.c line 1367. The code there is

	if (mii_reg5) {
		printk(KERN_INFO"%s: Setting %s%s-duplex based on"
			" auto-negotiated partner ability %4.4x.\n", dev->name,
			mii_reg5 == 0 ? "" :
			(mii_reg5 & 0x0180) ? "100mbps " : "10mbps ",
			tp->full_duplex ? "full" : "half", mii_reg5);
	} else {
		printk(KERN_INFO"%s: media is unconnected, link down, "
			"or incompatible connection\n",
			dev->name);
	}

where mii_reg5 is tested against zero inside a conditional
where we know that it is nonzero.
Probably the outer test is wrong.

Andries

             reply	other threads:[~2001-06-02 12:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-06-02 12:30 Andries.Brouwer [this message]
2001-06-02 12:36 ` rtl8139too in 2.4.5 Jeff Garzik
2001-06-02 16:30 ` Jaswinder Singh
2001-06-03 16:41 ` Rogier Wolff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=UTC200106021230.OAA182199.aeb@vlet.cwi.nl \
    --to=andries.brouwer@cwi.nl \
    --cc=jgarzik@mandrakesoft.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox