From: Andries.Brouwer@cwi.nl
To: Andries.Brouwer@cwi.nl, dalecki@evision-ventures.com
Cc: linux-kernel@vger.kernel.org, torvalds@transmeta.com
Subject: Re: [PATCH] size-in-bytes
Date: Sat, 16 Feb 2002 22:45:26 GMT [thread overview]
Message-ID: <UTC200202162245.WAA31932.aeb@cwi.nl> (raw)
From dalecki@evision-ventures.com Sat Feb 16 23:05:50 2002
Well I see that you have killed all places where it get's used - that's
fine!
But why don't just kill (fix) the initializations as well. You have already:
g->part[minor(dev)].nr_sects;
and friends right there at your hands ;-).
Yes, of course there is a reason this patch is called 02*.
I planned a road to happiness in 92 steps, where each of the steps
does something clear and simple, simplifies the tree, beautifies
the code, restructures in a clearly necessary way.
Indeed, your suggested steps are also there.
Five or six of these steps found their way into the kernel,
(some thanks to Christoph Hellwig) but there is still a long way to go.
The present patch is just a rediff of step 02.
I do not know what the best strategy is, these times.
I see you and Vojtech do good things to the IDE code,
but would myself prefer to do such things in a series
of really small steps. That way it is also very clear
for Andre what happens.
Andries
next reply other threads:[~2002-02-16 22:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-16 22:45 Andries.Brouwer [this message]
2002-02-16 23:10 ` [PATCH] size-in-bytes Martin Dalecki
-- strict thread matches above, loose matches on Subject: below --
2002-02-21 9:54 Andries.Brouwer
2002-02-18 23:29 Andries.Brouwer
2002-02-18 23:38 ` Daniel Phillips
2002-02-16 21:41 Andries.Brouwer
2002-02-16 22:05 ` Martin Dalecki
2002-02-16 16:09 Andries.Brouwer
2002-02-16 21:09 ` Martin Dalecki
2002-02-18 22:43 ` Daniel Phillips
2002-02-21 7:04 ` Benjamin LaHaise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=UTC200202162245.WAA31932.aeb@cwi.nl \
--to=andries.brouwer@cwi.nl \
--cc=dalecki@evision-ventures.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox