From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9CE8C433FE for ; Sat, 9 Apr 2022 12:37:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239813AbiDIMja (ORCPT ); Sat, 9 Apr 2022 08:39:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241198AbiDIMj1 (ORCPT ); Sat, 9 Apr 2022 08:39:27 -0400 Received: from aposti.net (aposti.net [89.234.176.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CE5624975; Sat, 9 Apr 2022 05:37:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1649507836; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ifBE7hLzyPPy+KwIFI4YoPCOsdLAAVtL/pcRZoRx3eg=; b=16eZFc8L+FfE+kmG9/d4QnEQoQUIuSB4Faqr2VU1OPxy5YvezIax7MxnUW7oDWmardXhCL aeAzlUu8eB5a47P9ZRSc7sujkU6F+FXUtR5FuSB71VVgL4uR/erNfX94MoSCWhrt5cnkvb sHwjLE24d0lyi7DhXA5hcvei+gqTy0A= Date: Sat, 09 Apr 2022 13:37:07 +0100 From: Paul Cercueil Subject: Re: [PATCH 13/18] dt-bindings: fix jz4780-nemc issue as reported by dtbscheck To: Krzysztof Kozlowski Cc: "H. Nikolaus Schaller" , Rob Herring , Thomas Bogendoerfer , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mips@vger.kernel.org, letux-kernel@openphoenux.org Message-Id: In-Reply-To: <036b66b2-c221-6e9e-6a56-510e7a0d20d3@linaro.org> References: <84adfe6237cd4cfd52cb9723416f69926e556e55.1649443080.git.hns@goldelico.com> <036b66b2-c221-6e9e-6a56-510e7a0d20d3@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, Le sam., avril 9 2022 at 13:26:25 +0200, Krzysztof Kozlowski=20 a =E9crit : > On 08/04/2022 20:37, H. Nikolaus Schaller wrote: >> jz4780-nemc needs to be compatible to simple-mfd as well or we get >>=20 >> arch/mips/boot/dts/ingenic/ci20.dtb: memory-controller@13410000:=20 >> compatible: 'oneOf' conditional failed, one must be fixed: >> ['ingenic,jz4780-nemc', 'simple-mfd'] is too long >> 'ingenic,jz4725b-nemc' was expected >> 'ingenic,jz4740-nemc' was expected >> From schema:=20 >> Documentation/devicetree/bindings/memory-controllers/ingenic,nemc.yaml >>=20 >> Signed-off-by: H. Nikolaus Schaller >> --- >> .../devicetree/bindings/memory-controllers/ingenic,nemc.yaml |=20 >> 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >>=20 >> diff --git=20 >> a/Documentation/devicetree/bindings/memory-controllers/ingenic,nemc.yaml= =20 >> b/Documentation/devicetree/bindings/memory-controllers/ingenic,nemc.yaml >> index 24f9e19820282..3b1116588de3d 100644 >> ---=20 >> a/Documentation/devicetree/bindings/memory-controllers/ingenic,nemc.yaml >> +++=20 >> b/Documentation/devicetree/bindings/memory-controllers/ingenic,nemc.yaml >> @@ -17,7 +17,7 @@ properties: >> oneOf: >> - enum: >> - ingenic,jz4740-nemc >> - - ingenic,jz4780-nemc >> + - [ ingenic,jz4780-nemc, simple-mfd ] >=20 > This is not correct representation. If you really need simple-mfd,=20 > then > this should be a separate item below oneOf. Correct. > The true question is whether you need simple-mfd. Isn't the binding=20 > (and > the driver) expected to instantiate its children? I can explain that one. There is the EFUSE controller located inside=20 the nemc's memory area, and the two are pretty much unrelated, hence=20 the "simple-mfd" compatible string. Cheers, -Paul