From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Stephan Gerhold <stephan@gerhold.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Peter Chen <Peter.Chen@nxp.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
"open list:ULTRA-WIDEBAND (UWB) SUBSYSTEM:"
<linux-usb@vger.kernel.org>, Thierry Reding <treding@nvidia.com>
Subject: Re: Infinite recursion in device_reorder_to_tail() due to circular device links
Date: Tue, 12 Jan 2021 19:04:45 +0100 [thread overview]
Message-ID: <X/3kveeVrb35qsvb@kroah.com> (raw)
In-Reply-To: <CAJZ5v0gAsZ45O8mv-gz0UvbyxnKA6fQBYvambBYEH6OSk3-m3g@mail.gmail.com>
On Tue, Jan 12, 2021 at 03:32:04PM +0100, Rafael J. Wysocki wrote:
> On Mon, Jan 11, 2021 at 7:46 PM Stephan Gerhold <stephan@gerhold.net> wrote:
> >
> > Hi,
> >
> > since 5.11-rc1 I get kernel crashes with infinite recursion in
> > device_reorder_to_tail() in some situations... It's a bit complicated to
> > explain so I want to apologize in advance for the long mail. :)
> >
> > Kernel panic - not syncing: kernel stack overflow
> > CPU: 1 PID: 33 Comm: kworker/1:1 Not tainted 5.11.0-rc3 #1
> > Hardware name: Qualcomm Technologies, Inc. APQ 8016 SBC (DT)
> > Call trace:
> > ...
> > device_reorder_to_tail+0x4c/0xf0
> > device_reorder_to_tail+0x98/0xf0
> > device_reorder_to_tail+0x60/0xf0
> > device_reorder_to_tail+0x60/0xf0
> > device_reorder_to_tail+0x60/0xf0
> > ...
> >
> > The crash happens only in 5.11 with commit 5b6164d3465f ("driver core:
> > Reorder devices on successful probe"). It stops happening when I revert
> > this commit.
>
> Thanks for the report!
>
> Greg, please revert commit 5b6164d3465f, it clearly is not an
> improvement, at least at this point.
Now reverted, thanks.
greg k-h
next prev parent reply other threads:[~2021-01-12 18:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 18:43 Infinite recursion in device_reorder_to_tail() due to circular device links Stephan Gerhold
2021-01-12 14:32 ` Rafael J. Wysocki
2021-01-12 18:04 ` Greg Kroah-Hartman [this message]
2021-01-23 23:37 ` Hugh Dickins
2021-01-24 8:13 ` Greg Kroah-Hartman
2021-01-24 20:06 ` Hugh Dickins
2021-01-12 18:24 ` Rafael J. Wysocki
2021-01-13 11:18 ` Stephan Gerhold
2021-01-14 0:54 ` Peter Chen
2021-01-14 8:17 ` Stephan Gerhold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/3kveeVrb35qsvb@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Peter.Chen@nxp.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=stephan@gerhold.net \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox