From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1A94C433E6 for ; Wed, 13 Jan 2021 18:34:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 675BB233FC for ; Wed, 13 Jan 2021 18:34:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728374AbhAMSeE (ORCPT ); Wed, 13 Jan 2021 13:34:04 -0500 Received: from mail.kernel.org ([198.145.29.99]:40280 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728285AbhAMSeD (ORCPT ); Wed, 13 Jan 2021 13:34:03 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id C30B7233ED; Wed, 13 Jan 2021 18:33:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1610562802; bh=gVAG2LQDgrcXGsfnLWrxjmYlxvDhqJhA+Xa6vYnElr0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YC/52rQBFyccqFv0pAVWA/24dDITKfuoR52pnFZiB3uPiNZqsmfjftWhbdwSxy9mg sulIhq8fWKYPP27srNlyj/RRv/invGgzOLkBt99cQTU9gEaWG6ZTP1dGdKWJsL3oDN CWsHEcXl2B6AXtJ+NbV1En7/zM5igjGZNOURs+gk= Date: Wed, 13 Jan 2021 19:34:28 +0100 From: Greg Kroah-Hartman To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Pavel Machek , linux-kernel@vger.kernel.org, Johan Hovold , Jacek Anaszewski , linux-serial@vger.kernel.org, Jiri Slaby , kernel@pengutronix.de, linux-leds@vger.kernel.org, Dan Murphy Subject: Re: [PATCH v11] leds: trigger: implement a tty trigger Message-ID: References: <20201218104246.591315-1-u.kleine-koenig@pengutronix.de> <20201218104246.591315-4-u.kleine-koenig@pengutronix.de> <20210113173018.bq2fkea2o3yp6rf6@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210113173018.bq2fkea2o3yp6rf6@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 13, 2021 at 06:30:18PM +0100, Uwe Kleine-König wrote: > Usage is as follows: > > myled=ledname > tty=ttyS0 > > echo tty > /sys/class/leds/$myled/trigger > echo $tty > /sys/class/leds/$myled/ttyname > > . When this new trigger is active it periodically checks the tty's > statistics and when it changed since the last check the led is flashed > once. > > Signed-off-by: Uwe Kleine-König > --- > Hello, > > On Wed, Jan 13, 2021 at 05:16:00PM +0100, Greg Kroah-Hartman wrote: > > This causes the following build warning with the patch applied: > > > > drivers/leds/trigger/ledtrig-tty.c:19:13: warning: ‘ledtrig_tty_halt’ defined but not used [-Wunused-function] > > 19 | static void ledtrig_tty_halt(struct ledtrig_tty_data *trigger_data) > > | ^~~~~~~~~~~~~~~~ > > > > Can you fix this up and just resend this patch (the other 2 are already > > in my tree), > > oh indeed. Thanks for catching this and so preventing me still more > shame when I have to receive a dozen or so patches that fix this :-) > Droping this function is the only change since v10. > > > so that I can queue it up? > > Oh, so you are LED maintainer now? My congratulations. > (Honestly, do you plan to apply this without their ack? Not that I'm > against you doing that, I'm happy if I can archive this patch series as > done, but I'm a bit surprised.) It's drug on for so long now, the infrastructure that this driver needs has now bee merged, so I see no reason why this driver can't be taken now. I offered up a "any objections?" in the past, and have gotten none, so I will take that for quiet acceptance :) thanks, greg k-h